You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/11/20 07:04:53 UTC

[GitHub] [camel] schernolyas opened a new pull request #4638: [CAMEL-15871] remove item name prefix

schernolyas opened a new pull request #4638:
URL: https://github.com/apache/camel/pull/4638


   - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/CAMEL) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
   - [ ] Each commit in the pull request should have a meaningful subject line and body.
   - [ ] If you're unsure, you can format the pull request title like `[CAMEL-XXX] Fixes bug in camel-file component`, where you replace `CAMEL-XXX` with the appropriate JIRA issue.
   - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [ ] Run `mvn clean install -Psourcecheck` in your module with source check enabled to make sure basic checks pass and there are no checkstyle violations. A more thorough check will be performed on your pull request automatically.
   Below are the contribution guidelines:
   https://github.com/apache/camel/blob/master/CONTRIBUTING.md


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] oscerd commented on pull request #4638: [CAMEL-15871] remove item name prefix

Posted by GitBox <gi...@apache.org>.
oscerd commented on pull request #4638:
URL: https://github.com/apache/camel/pull/4638#issuecomment-730957659


   This has been squashed and merged. Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] oscerd closed pull request #4638: [CAMEL-15871] remove item name prefix

Posted by GitBox <gi...@apache.org>.
oscerd closed pull request #4638:
URL: https://github.com/apache/camel/pull/4638


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] oscerd commented on a change in pull request #4638: [CAMEL-15871] remove item name prefix

Posted by GitBox <gi...@apache.org>.
oscerd commented on a change in pull request #4638:
URL: https://github.com/apache/camel/pull/4638#discussion_r527480580



##########
File path: components/camel-milo/src/main/java/org/apache/camel/component/milo/server/internal/CamelServerItem.java
##########
@@ -55,7 +55,7 @@ public CamelServerItem(final String itemId, final UaNodeContext nodeContext, fin
         this.itemId = itemId;
         this.baseNode = baseNode;
 
-        final NodeId nodeId = new NodeId(namespaceIndex, "items-" + itemId);
+        final NodeId nodeId = new NodeId(namespaceIndex, "" + itemId);

Review comment:
       I think you can remove the empty string concatenation.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] schernolyas commented on pull request #4638: [CAMEL-15871] remove item name prefix

Posted by GitBox <gi...@apache.org>.
schernolyas commented on pull request #4638:
URL: https://github.com/apache/camel/pull/4638#issuecomment-730954001


   > Please add the Camel issue number in the commit message along with the title of the issue, for tracking purpose. Thanks
   
   yes. I have appended it to last commit.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] schernolyas commented on a change in pull request #4638: [CAMEL-15871] remove item name prefix

Posted by GitBox <gi...@apache.org>.
schernolyas commented on a change in pull request #4638:
URL: https://github.com/apache/camel/pull/4638#discussion_r527481051



##########
File path: components/camel-milo/src/main/java/org/apache/camel/component/milo/server/internal/CamelServerItem.java
##########
@@ -55,7 +55,7 @@ public CamelServerItem(final String itemId, final UaNodeContext nodeContext, fin
         this.itemId = itemId;
         this.baseNode = baseNode;
 
-        final NodeId nodeId = new NodeId(namespaceIndex, "items-" + itemId);
+        final NodeId nodeId = new NodeId(namespaceIndex, "" + itemId);

Review comment:
       yes, of course. it is done.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org