You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opennlp.apache.org by jz...@apache.org on 2022/11/30 15:39:06 UTC
[opennlp] branch master updated: OPENNLP-1007 Typo in EvaluationMonitor method signature (#438)
This is an automated email from the ASF dual-hosted git repository.
jzemerick pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/opennlp.git
The following commit(s) were added to refs/heads/master by this push:
new ca4adbe0 OPENNLP-1007 Typo in EvaluationMonitor method signature (#438)
ca4adbe0 is described below
commit ca4adbe0dc2809333340dcf822120934b92eca0f
Author: Martin Wiesner <ma...@users.noreply.github.com>
AuthorDate: Wed Nov 30 16:38:58 2022 +0100
OPENNLP-1007 Typo in EvaluationMonitor method signature (#438)
- corrects the incorrect spelling 'missclassified' in `EvaluationMonitor` interface
- refactors all classes that call or implement this method, accordingly
---
.../src/main/java/opennlp/tools/cmdline/DetailedFMeasureListener.java | 2 +-
.../src/main/java/opennlp/tools/cmdline/EvaluationErrorPrinter.java | 2 +-
.../opennlp/tools/cmdline/chunker/ChunkEvaluationErrorListener.java | 2 +-
.../opennlp/tools/cmdline/doccat/DoccatEvaluationErrorListener.java | 2 +-
.../opennlp/tools/cmdline/doccat/DoccatFineGrainedReportListener.java | 2 +-
.../cmdline/langdetect/LanguageDetectorEvaluationErrorListener.java | 2 +-
.../cmdline/langdetect/LanguageDetectorFineGrainedReportListener.java | 2 +-
.../tools/cmdline/lemmatizer/LemmaEvaluationErrorListener.java | 2 +-
.../tools/cmdline/lemmatizer/LemmatizerFineGrainedReportListener.java | 2 +-
.../opennlp/tools/cmdline/namefind/NameEvaluationErrorListener.java | 2 +-
.../cmdline/namefind/TokenNameFinderFineGrainedReportListener.java | 2 +-
.../java/opennlp/tools/cmdline/postag/POSEvaluationErrorListener.java | 2 +-
.../tools/cmdline/postag/POSTaggerFineGrainedReportListener.java | 2 +-
.../tools/cmdline/sentdetect/SentenceEvaluationErrorListener.java | 2 +-
.../tools/cmdline/tokenizer/DetokenEvaluationErrorListener.java | 2 +-
.../opennlp/tools/cmdline/tokenizer/TokenEvaluationErrorListener.java | 2 +-
.../src/main/java/opennlp/tools/util/eval/EvaluationMonitor.java | 2 +-
opennlp-tools/src/main/java/opennlp/tools/util/eval/Evaluator.java | 2 +-
.../opennlp/tools/langdetect/LanguageDetectorCrossValidatorTest.java | 4 ++--
.../java/opennlp/tools/langdetect/LanguageDetectorEvaluatorTest.java | 4 ++--
20 files changed, 22 insertions(+), 22 deletions(-)
diff --git a/opennlp-tools/src/main/java/opennlp/tools/cmdline/DetailedFMeasureListener.java b/opennlp-tools/src/main/java/opennlp/tools/cmdline/DetailedFMeasureListener.java
index 4e3ec882..e354dd35 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/cmdline/DetailedFMeasureListener.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/cmdline/DetailedFMeasureListener.java
@@ -54,7 +54,7 @@ public abstract class DetailedFMeasureListener<T> implements
}
}
- public void missclassified(T reference, T prediction) {
+ public void misclassified(T reference, T prediction) {
samples++;
Span[] references = asSpanArray(reference);
Span[] predictions = asSpanArray(prediction);
diff --git a/opennlp-tools/src/main/java/opennlp/tools/cmdline/EvaluationErrorPrinter.java b/opennlp-tools/src/main/java/opennlp/tools/cmdline/EvaluationErrorPrinter.java
index beb9efd4..45408991 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/cmdline/EvaluationErrorPrinter.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/cmdline/EvaluationErrorPrinter.java
@@ -235,6 +235,6 @@ public abstract class EvaluationErrorPrinter<T> implements EvaluationMonitor<T>
// do nothing
}
- public abstract void missclassified(T reference, T prediction) ;
+ public abstract void misclassified(T reference, T prediction) ;
}
diff --git a/opennlp-tools/src/main/java/opennlp/tools/cmdline/chunker/ChunkEvaluationErrorListener.java b/opennlp-tools/src/main/java/opennlp/tools/cmdline/chunker/ChunkEvaluationErrorListener.java
index 7cda6863..d091fa9b 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/cmdline/chunker/ChunkEvaluationErrorListener.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/cmdline/chunker/ChunkEvaluationErrorListener.java
@@ -47,7 +47,7 @@ public class ChunkEvaluationErrorListener extends
}
@Override
- public void missclassified(ChunkSample reference, ChunkSample prediction) {
+ public void misclassified(ChunkSample reference, ChunkSample prediction) {
printError(reference.getPhrasesAsSpanList(),
prediction.getPhrasesAsSpanList(), reference, prediction,
reference.getSentence());
diff --git a/opennlp-tools/src/main/java/opennlp/tools/cmdline/doccat/DoccatEvaluationErrorListener.java b/opennlp-tools/src/main/java/opennlp/tools/cmdline/doccat/DoccatEvaluationErrorListener.java
index 8609a6c3..40b5faee 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/cmdline/doccat/DoccatEvaluationErrorListener.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/cmdline/doccat/DoccatEvaluationErrorListener.java
@@ -47,7 +47,7 @@ public class DoccatEvaluationErrorListener extends
}
@Override
- public void missclassified(DocumentSample reference, DocumentSample prediction) {
+ public void misclassified(DocumentSample reference, DocumentSample prediction) {
printError(reference, prediction);
}
diff --git a/opennlp-tools/src/main/java/opennlp/tools/cmdline/doccat/DoccatFineGrainedReportListener.java b/opennlp-tools/src/main/java/opennlp/tools/cmdline/doccat/DoccatFineGrainedReportListener.java
index 01436a03..7cac56c5 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/cmdline/doccat/DoccatFineGrainedReportListener.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/cmdline/doccat/DoccatFineGrainedReportListener.java
@@ -48,7 +48,7 @@ public class DoccatFineGrainedReportListener
// methods inherited from EvaluationMonitor
- public void missclassified(DocumentSample reference, DocumentSample prediction) {
+ public void misclassified(DocumentSample reference, DocumentSample prediction) {
statsAdd(reference, prediction);
}
diff --git a/opennlp-tools/src/main/java/opennlp/tools/cmdline/langdetect/LanguageDetectorEvaluationErrorListener.java b/opennlp-tools/src/main/java/opennlp/tools/cmdline/langdetect/LanguageDetectorEvaluationErrorListener.java
index eeec89de..386117fe 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/cmdline/langdetect/LanguageDetectorEvaluationErrorListener.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/cmdline/langdetect/LanguageDetectorEvaluationErrorListener.java
@@ -48,7 +48,7 @@ public class LanguageDetectorEvaluationErrorListener extends
}
@Override
- public void missclassified(LanguageSample reference, LanguageSample prediction) {
+ public void misclassified(LanguageSample reference, LanguageSample prediction) {
printError(reference, prediction);
}
diff --git a/opennlp-tools/src/main/java/opennlp/tools/cmdline/langdetect/LanguageDetectorFineGrainedReportListener.java b/opennlp-tools/src/main/java/opennlp/tools/cmdline/langdetect/LanguageDetectorFineGrainedReportListener.java
index 70bf3eb4..b1894fc1 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/cmdline/langdetect/LanguageDetectorFineGrainedReportListener.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/cmdline/langdetect/LanguageDetectorFineGrainedReportListener.java
@@ -48,7 +48,7 @@ public class LanguageDetectorFineGrainedReportListener
// methods inherited from EvaluationMonitor
- public void missclassified(LanguageSample reference, LanguageSample prediction) {
+ public void misclassified(LanguageSample reference, LanguageSample prediction) {
statsAdd(reference, prediction);
}
diff --git a/opennlp-tools/src/main/java/opennlp/tools/cmdline/lemmatizer/LemmaEvaluationErrorListener.java b/opennlp-tools/src/main/java/opennlp/tools/cmdline/lemmatizer/LemmaEvaluationErrorListener.java
index 0edf327a..fa5d959d 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/cmdline/lemmatizer/LemmaEvaluationErrorListener.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/cmdline/lemmatizer/LemmaEvaluationErrorListener.java
@@ -47,7 +47,7 @@ public class LemmaEvaluationErrorListener extends
}
@Override
- public void missclassified(LemmaSample reference, LemmaSample prediction) {
+ public void misclassified(LemmaSample reference, LemmaSample prediction) {
printError(reference.getLemmas(), prediction.getLemmas(), reference,
prediction, reference.getTokens());
}
diff --git a/opennlp-tools/src/main/java/opennlp/tools/cmdline/lemmatizer/LemmatizerFineGrainedReportListener.java b/opennlp-tools/src/main/java/opennlp/tools/cmdline/lemmatizer/LemmatizerFineGrainedReportListener.java
index a20936fe..a4f73477 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/cmdline/lemmatizer/LemmatizerFineGrainedReportListener.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/cmdline/lemmatizer/LemmatizerFineGrainedReportListener.java
@@ -49,7 +49,7 @@ public class LemmatizerFineGrainedReportListener
// methods inherited from EvaluationMonitor
- public void missclassified(LemmaSample reference, LemmaSample prediction) {
+ public void misclassified(LemmaSample reference, LemmaSample prediction) {
statsAdd(reference, prediction);
}
diff --git a/opennlp-tools/src/main/java/opennlp/tools/cmdline/namefind/NameEvaluationErrorListener.java b/opennlp-tools/src/main/java/opennlp/tools/cmdline/namefind/NameEvaluationErrorListener.java
index f5d9d586..a79afdc4 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/cmdline/namefind/NameEvaluationErrorListener.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/cmdline/namefind/NameEvaluationErrorListener.java
@@ -47,7 +47,7 @@ public class NameEvaluationErrorListener extends
}
@Override
- public void missclassified(NameSample reference, NameSample prediction) {
+ public void misclassified(NameSample reference, NameSample prediction) {
printError(reference.getId(), reference.getNames(), prediction.getNames(), reference,
prediction, reference.getSentence());
}
diff --git a/opennlp-tools/src/main/java/opennlp/tools/cmdline/namefind/TokenNameFinderFineGrainedReportListener.java b/opennlp-tools/src/main/java/opennlp/tools/cmdline/namefind/TokenNameFinderFineGrainedReportListener.java
index 99f3aa34..d8ca7bc2 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/cmdline/namefind/TokenNameFinderFineGrainedReportListener.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/cmdline/namefind/TokenNameFinderFineGrainedReportListener.java
@@ -54,7 +54,7 @@ public class TokenNameFinderFineGrainedReportListener
// methods inherited from EvaluationMonitor
- public void missclassified(NameSample reference, NameSample prediction) {
+ public void misclassified(NameSample reference, NameSample prediction) {
statsAdd(reference, prediction);
}
diff --git a/opennlp-tools/src/main/java/opennlp/tools/cmdline/postag/POSEvaluationErrorListener.java b/opennlp-tools/src/main/java/opennlp/tools/cmdline/postag/POSEvaluationErrorListener.java
index bd445cda..a5d60299 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/cmdline/postag/POSEvaluationErrorListener.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/cmdline/postag/POSEvaluationErrorListener.java
@@ -47,7 +47,7 @@ public class POSEvaluationErrorListener extends
}
@Override
- public void missclassified(POSSample reference, POSSample prediction) {
+ public void misclassified(POSSample reference, POSSample prediction) {
printError(reference.getTags(), prediction.getTags(), reference,
prediction, reference.getSentence());
}
diff --git a/opennlp-tools/src/main/java/opennlp/tools/cmdline/postag/POSTaggerFineGrainedReportListener.java b/opennlp-tools/src/main/java/opennlp/tools/cmdline/postag/POSTaggerFineGrainedReportListener.java
index 64fbcb4f..fa0a3655 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/cmdline/postag/POSTaggerFineGrainedReportListener.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/cmdline/postag/POSTaggerFineGrainedReportListener.java
@@ -50,7 +50,7 @@ public class POSTaggerFineGrainedReportListener
// methods inherited from EvaluationMonitor
- public void missclassified(POSSample reference, POSSample prediction) {
+ public void misclassified(POSSample reference, POSSample prediction) {
statsAdd(reference, prediction);
}
diff --git a/opennlp-tools/src/main/java/opennlp/tools/cmdline/sentdetect/SentenceEvaluationErrorListener.java b/opennlp-tools/src/main/java/opennlp/tools/cmdline/sentdetect/SentenceEvaluationErrorListener.java
index ee064a6b..b93d9955 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/cmdline/sentdetect/SentenceEvaluationErrorListener.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/cmdline/sentdetect/SentenceEvaluationErrorListener.java
@@ -48,7 +48,7 @@ public class SentenceEvaluationErrorListener extends
}
@Override
- public void missclassified(SentenceSample reference, SentenceSample prediction) {
+ public void misclassified(SentenceSample reference, SentenceSample prediction) {
printError(reference.getSentences(), prediction.getSentences(), reference,
prediction, reference.getDocument());
}
diff --git a/opennlp-tools/src/main/java/opennlp/tools/cmdline/tokenizer/DetokenEvaluationErrorListener.java b/opennlp-tools/src/main/java/opennlp/tools/cmdline/tokenizer/DetokenEvaluationErrorListener.java
index 4e313328..475b3c38 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/cmdline/tokenizer/DetokenEvaluationErrorListener.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/cmdline/tokenizer/DetokenEvaluationErrorListener.java
@@ -46,7 +46,7 @@ public class DetokenEvaluationErrorListener extends
}
@Override
- public void missclassified(TokenSample reference, TokenSample prediction) {
+ public void misclassified(TokenSample reference, TokenSample prediction) {
printError(reference, prediction);
}
diff --git a/opennlp-tools/src/main/java/opennlp/tools/cmdline/tokenizer/TokenEvaluationErrorListener.java b/opennlp-tools/src/main/java/opennlp/tools/cmdline/tokenizer/TokenEvaluationErrorListener.java
index 1fdcc9ca..1465eb88 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/cmdline/tokenizer/TokenEvaluationErrorListener.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/cmdline/tokenizer/TokenEvaluationErrorListener.java
@@ -47,7 +47,7 @@ public class TokenEvaluationErrorListener extends
}
@Override
- public void missclassified(TokenSample reference, TokenSample prediction) {
+ public void misclassified(TokenSample reference, TokenSample prediction) {
printError(reference.getTokenSpans(), prediction.getTokenSpans(),
reference, prediction, reference.getText());
}
diff --git a/opennlp-tools/src/main/java/opennlp/tools/util/eval/EvaluationMonitor.java b/opennlp-tools/src/main/java/opennlp/tools/util/eval/EvaluationMonitor.java
index aa971c28..9771fbf1 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/util/eval/EvaluationMonitor.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/util/eval/EvaluationMonitor.java
@@ -21,6 +21,6 @@ public interface EvaluationMonitor<T> {
void correctlyClassified(T reference, T prediction);
- void missclassified(T reference, T prediction);
+ void misclassified(T reference, T prediction);
}
diff --git a/opennlp-tools/src/main/java/opennlp/tools/util/eval/Evaluator.java b/opennlp-tools/src/main/java/opennlp/tools/util/eval/Evaluator.java
index cbf6ec3a..ee8d49ab 100644
--- a/opennlp-tools/src/main/java/opennlp/tools/util/eval/Evaluator.java
+++ b/opennlp-tools/src/main/java/opennlp/tools/util/eval/Evaluator.java
@@ -84,7 +84,7 @@ public abstract class Evaluator<T> {
}
} else {
for (EvaluationMonitor<T> listener : listeners) {
- listener.missclassified(sample, predicted);
+ listener.misclassified(sample, predicted);
}
}
}
diff --git a/opennlp-tools/src/test/java/opennlp/tools/langdetect/LanguageDetectorCrossValidatorTest.java b/opennlp-tools/src/test/java/opennlp/tools/langdetect/LanguageDetectorCrossValidatorTest.java
index 8b004dd4..6e85e65a 100644
--- a/opennlp-tools/src/test/java/opennlp/tools/langdetect/LanguageDetectorCrossValidatorTest.java
+++ b/opennlp-tools/src/test/java/opennlp/tools/langdetect/LanguageDetectorCrossValidatorTest.java
@@ -48,8 +48,8 @@ public class LanguageDetectorCrossValidatorTest {
}
@Override
- public void missclassified(LanguageSample reference,
- LanguageSample prediction) {
+ public void misclassified(LanguageSample reference,
+ LanguageSample prediction) {
incorrectCount.incrementAndGet();
}
});
diff --git a/opennlp-tools/src/test/java/opennlp/tools/langdetect/LanguageDetectorEvaluatorTest.java b/opennlp-tools/src/test/java/opennlp/tools/langdetect/LanguageDetectorEvaluatorTest.java
index e0a02524..6a2ca7cf 100644
--- a/opennlp-tools/src/test/java/opennlp/tools/langdetect/LanguageDetectorEvaluatorTest.java
+++ b/opennlp-tools/src/test/java/opennlp/tools/langdetect/LanguageDetectorEvaluatorTest.java
@@ -48,8 +48,8 @@ public class LanguageDetectorEvaluatorTest {
}
@Override
- public void missclassified(LanguageSample reference,
- LanguageSample prediction) {
+ public void misclassified(LanguageSample reference,
+ LanguageSample prediction) {
incorrectCount.incrementAndGet();
}
}, new LanguageDetectorEvaluationErrorListener(outputStream));