[GitHub] [flink] twalthr commented on a change in pull request #18439: [hotfix][table-planner][test] Self union watermark propagation

[GitBox <gi...@apache.org>]

twalthr commented on a change in pull request #18439:
URL: https://github.com/apache/flink/pull/18439#discussion_r790615977



##########
File path: flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/common/CommonExecSinkITCase.java
##########
@@ -426,6 +429,26 @@ public void testNullEnforcer() throws ExecutionException, InterruptedException {
         }
     }
 
+    @Test
+    public void testSelfUnionWatermarkPropagation() throws Exception {
+        DataStream<Integer> dataStream = env.fromElements(1, 2, 3);
+
+        WatermarkOperator operator = new WatermarkOperator(env.getParallelism());
+        dataStream
+                .union(dataStream)
+                .transform("Watermark Operator", BasicTypeInfo.INT_TYPE_INFO, operator)
+                .addSink(new DiscardingSink<>());

Review comment:
       This might have been a misunderstanding: What I meant with a test on the table side is an actual table sink, to test the story end to end. Using the original example from the JIRA issue with `fromValues` and our mock table sink.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org