You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "LadyForest (via GitHub)" <gi...@apache.org> on 2023/06/19 02:51:53 UTC

[GitHub] [flink] LadyForest opened a new pull request, #22820: [FLINK-32374][table-planner] Fix the issue that ExecNodeGraphInternalPlan#writeToFile should support TRUNCATE_EXISTING for overwriting

LadyForest opened a new pull request, #22820:
URL: https://github.com/apache/flink/pull/22820

   ## What is the purpose of the change
   
   This PR fixes the issue that `COMPILED PLAN` statement may generate invalid JSON when overwriting the existing JSON with a shorter version.
   
   
   ## Brief change log
   
   -  Add `TRUNCATE_EXISTING` to `ExecNodeGraphInternalPlan#writeToFile`
   
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as `CompilePlanITCase#testCompilePlanOverwrite`.
   
   - Roll back the changes made on src and run this case will reproduce the error. Apply the changes made on src and re-run the case to verify the fix.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): No
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: No
     - The serializers: No
     - The runtime per-record code paths (performance sensitive): No
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: No
     - The S3 file system connector: No
   
   ## Documentation
   
     - Does this pull request introduce a new feature? No
     - If yes, how is the feature documented? N.A.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #22820: [FLINK-32374][table-planner] Fix the issue that ExecNodeGraphInternalPlan#writeToFile should support TRUNCATE_EXISTING for overwriting

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #22820:
URL: https://github.com/apache/flink/pull/22820#issuecomment-1596418228

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "f44931f66bdfc9ec6e141f4185982980038b445c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "f44931f66bdfc9ec6e141f4185982980038b445c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * f44931f66bdfc9ec6e141f4185982980038b445c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] luoyuxia commented on pull request #22820: [FLINK-32374][table-planner] Fix the issue that ExecNodeGraphInternalPlan#writeToFile should support TRUNCATE_EXISTING for overwriting

Posted by "luoyuxia (via GitHub)" <gi...@apache.org>.
luoyuxia commented on PR #22820:
URL: https://github.com/apache/flink/pull/22820#issuecomment-1596827971

   @LadyForest Could you please backport to 1.17 & 1.16. Thx.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] LadyForest commented on pull request #22820: [FLINK-32374][table-planner] Fix the issue that ExecNodeGraphInternalPlan#writeToFile should support TRUNCATE_EXISTING for overwriting

Posted by "LadyForest (via GitHub)" <gi...@apache.org>.
LadyForest commented on PR #22820:
URL: https://github.com/apache/flink/pull/22820#issuecomment-1596832437

   > @LadyForest Could you please backport to 1.17 & 1.16. Thx.
   
   Sure :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] luoyuxia merged pull request #22820: [FLINK-32374][table-planner] Fix the issue that ExecNodeGraphInternalPlan#writeToFile should support TRUNCATE_EXISTING for overwriting

Posted by "luoyuxia (via GitHub)" <gi...@apache.org>.
luoyuxia merged PR #22820:
URL: https://github.com/apache/flink/pull/22820


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org