You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "thurka (via GitHub)" <gi...@apache.org> on 2023/06/15 12:23:55 UTC
[GitHub] [netbeans] thurka opened a new pull request, #6080: Apache LS does not add DB connection
thurka opened a new pull request, #6080:
URL: https://github.com/apache/netbeans/pull/6080
VSCode only: Sometimes new DB connection is not displayed even if URL and username, password are correctly entered. This probem is caused by unconditionally removing database commection in finally block in `validate()` method. The rest of the code expects that such connection is reused if there are no schemas. The fix is to change the finally block to remove connection only in case of connection failure or non-empty list of schemas is retrieved from database.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] thurka merged pull request #6080: Apache LS does not add DB connection
Posted by "thurka (via GitHub)" <gi...@apache.org>.
thurka merged PR #6080:
URL: https://github.com/apache/netbeans/pull/6080
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists