[GitHub] [spark] xinrong-databricks commented on a diff in pull request #36547: Implement `skipna` parameter of `Groupby.all`

[GitBox <gi...@apache.org>]

xinrong-databricks commented on code in PR #36547:
URL: https://github.com/apache/spark/pull/36547#discussion_r873967446


##########
python/pyspark/pandas/groupby.py:
##########
@@ -2879,7 +2898,43 @@ def _reduce_for_stat_function(
                 psdf = psdf.reset_index(level=should_drop_index, drop=True)
             if len(should_drop_index) < len(self._groupkeys):
                 psdf = psdf.reset_index()
-        return self._cleanup_and_return(psdf)
+        psdf = self._cleanup_and_return(psdf)
+        return psdf
+
+    def _prepare_reduce(

Review Comment:
   Code of `_prepare_reduce` is extracted from `_reduce_for_stat_function`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org