You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/08/02 23:35:22 UTC

[GitHub] [superset] betodealmeida commented on a change in pull request #16038: fix: handle schemas_allowed_for_csv_upload serde

betodealmeida commented on a change in pull request #16038:
URL: https://github.com/apache/superset/pull/16038#discussion_r681331894



##########
File path: superset-frontend/src/views/CRUD/data/database/types.ts
##########
@@ -83,7 +83,7 @@ export type DatabaseObject = {
       table_cache_timeout?: number; // in Performance
     }; // No field, holds schema and table timeout
     allows_virtual_table_explore?: boolean; // in SQL Lab
-    schemas_allowed_for_csv_upload?: [] | string; // in Security
+    schemas_allowed_for_csv_upload?: string[]; // in Security

Review comment:
       We should do the same for `query` and `catalog` in this object.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org