You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@arrow.apache.org by "Eduardo Ponce (Jira)" <ji...@apache.org> on 2021/10/14 21:57:00 UTC
[jira] [Commented] (ARROW-14134) [C++] Standardize generator
dispatchers for scalar arithmetic to codegen_internal.h
[ https://issues.apache.org/jira/browse/ARROW-14134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17429024#comment-17429024 ]
Eduardo Ponce commented on ARROW-14134:
---------------------------------------
[Here is the initial conversation|https://github.com/apache/arrow/pull/11233#discussion_r717247336] on renaming GD for Binary/StringTypes.
> [C++] Standardize generator dispatchers for scalar arithmetic to codegen_internal.h
> -----------------------------------------------------------------------------------
>
> Key: ARROW-14134
> URL: https://issues.apache.org/jira/browse/ARROW-14134
> Project: Apache Arrow
> Issue Type: Improvement
> Reporter: Eduardo Ponce
> Assignee: Eduardo Ponce
> Priority: Trivial
> Labels: kernel
> Fix For: 7.0.0
>
>
> codegen_internal.h formally defines generator dispatchers but there are a few GDs defined in scalar_arithmetic.cc. These should be moved, organized, commented, and renamed appropriately.
> Also, the documentation for GD should be updated since more capable GDs have been added.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)