[GitHub] [incubator-kyuubi] cxzl25 commented on a diff in pull request #3697: [KYUUBI #3695] Add new policy that support dynamic expand or decrease engin according to engin load

[GitBox <gi...@apache.org>]

cxzl25 commented on code in PR #3697:
URL: https://github.com/apache/incubator-kyuubi/pull/3697#discussion_r1009068368


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/EngineRef.scala:
##########
@@ -96,32 +125,6 @@ private[kyuubi] class EngineRef(
     case _ => user
   }
 
-  @VisibleForTesting
-  private[kyuubi] val subdomain: String = conf.get(ENGINE_SHARE_LEVEL_SUBDOMAIN) match {
-    case Some(_subdomain) => _subdomain
-    case None if clientPoolSize > 0 =>
-      val poolSize = math.min(clientPoolSize, poolThreshold)
-      if (poolSize < clientPoolSize) {
-        warn(s"Request engine pool size($clientPoolSize) exceeds, fallback to " +
-          s"system threshold $poolThreshold")
-      }
-      val seqNum = enginePoolBalancePolicy match {
-        case "POLLING" =>

Review Comment:
   Why remove the `POLLING` policy?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org