You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Blair Zajac <bl...@orcaware.com> on 2002/06/06 22:18:59 UTC
Re: svn commit: rev 2106 - trunk/subversion/libsvn_fs
trunk/subversion/libsvn_ra_local trunk/subversion/svnlook
trunk/subversion/clients/cmdline trunk/subversion/tests/libsvn_fs
gstein@tigris.org wrote:
>
> Author: gstein
> Date: 2002-06-06 20:30 GMT
> New Revision: 2106
>
> Modified: trunk/subversion/tests/libsvn_fs/fs-test.c
> ==============================================================================
> --- trunk/subversion/tests/libsvn_fs/fs-test.c (original)
> +++ trunk/subversion/tests/libsvn_fs/fs-test.c Thu Jun 6 15:30:36 2002
> @@ -4292,7 +4292,7 @@
> crappy. We need to keep this buffer fairly large so we don't run
> out of memory doing undeltification of large files into tiny
> buffers. Issue #465. */
> - char buf[100000];
> + char *buf = apr_palloc (pool, 100000);
I think this change causes make check's run-fs-tests.sh to use an
inordinate amount of memory when it didn't use to, over 80% on my
256 MByte Linux box on and takes forever to run.
Best,
Blair
--
Blair Zajac <bl...@orcaware.com>
Web and OS performance plots - http://www.orcaware.com/orca/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: rev 2106 - trunk/subversion/libsvn_fs trunk/subversion/libsvn_ra_local trunk/subversion/svnlook trunk/subversion/clients/cmdline trunk/subversion/tests/libsvn_fs
Posted by Philip Martin <ph...@codematters.co.uk>.
Blair Zajac <bl...@orcaware.com> writes:
> > - char buf[100000];
> > + char *buf = apr_palloc (pool, 100000);
>
> I think this change causes make check's run-fs-tests.sh to use an
> inordinate amount of memory when it didn't use to, over 80% on my
> 256 MByte Linux box on and takes forever to run.
Yes it did. Fixed in rev 2109.
--
Philip
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: rev 2106 - trunk/subversion/libsvn_fs trunk/subversion/libsvn_ra_local trunk/subversion/svnlook trunk/subversion/clients/cmdline trunk/subversion/tests/libsvn_fs
Posted by Greg Stein <gs...@lyra.org>.
On Thu, Jun 06, 2002 at 03:18:59PM -0700, Blair Zajac wrote:
> gstein@tigris.org wrote:
> >
> > Author: gstein
> > Date: 2002-06-06 20:30 GMT
> > New Revision: 2106
> >
> > Modified: trunk/subversion/tests/libsvn_fs/fs-test.c
> > ==============================================================================
> > --- trunk/subversion/tests/libsvn_fs/fs-test.c (original)
> > +++ trunk/subversion/tests/libsvn_fs/fs-test.c Thu Jun 6 15:30:36 2002
> > @@ -4292,7 +4292,7 @@
> > crappy. We need to keep this buffer fairly large so we don't run
> > out of memory doing undeltification of large files into tiny
> > buffers. Issue #465. */
> > - char buf[100000];
> > + char *buf = apr_palloc (pool, 100000);
Dang. And I even forgot to include that one in the log message!
I've corrected the log message to include:
* tests/libsvn_fs/fs-test.c (get_file_digest): allocate the buffer on the
heap, not the stack (it is too big for the stack).
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: rev 2106 - trunk/subversion/libsvn_fs trunk/subversion/libsvn_ra_local trunk/subversion/svnlook trunk/subversion/clients/cmdline trunk/subversion/tests/libsvn_fs
Posted by Greg Stein <gs...@lyra.org>.
On Thu, Jun 06, 2002 at 03:18:59PM -0700, Blair Zajac wrote:
> gstein@tigris.org wrote:
>...
> > +++ trunk/subversion/tests/libsvn_fs/fs-test.c Thu Jun 6 15:30:36 2002
> > @@ -4292,7 +4292,7 @@
> > crappy. We need to keep this buffer fairly large so we don't run
> > out of memory doing undeltification of large files into tiny
> > buffers. Issue #465. */
> > - char buf[100000];
> > + char *buf = apr_palloc (pool, 100000);
>
> I think this change causes make check's run-fs-tests.sh to use an
> inordinate amount of memory when it didn't use to, over 80% on my
> 256 MByte Linux box on and takes forever to run.
It shouldn't. There is one caller to get_file_digest(), and it clears the
pool on each iteration.
That said, it is hard to argue with empirical evidence :-). But that just
means there is *another* problem to fix. Not to restore the old code.
Allocating 100k on the stack is just plain wrong. Big Badness(tm).
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org