You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "pitrou (via GitHub)" <gi...@apache.org> on 2023/07/06 12:51:10 UTC

[GitHub] [arrow] pitrou commented on a diff in pull request #36486: GH-34509: [C++][Parquet][Docs] Fix comment for ArrowReaderProperties::batch_size

pitrou commented on code in PR #36486:
URL: https://github.com/apache/arrow/pull/36486#discussion_r1254392514


##########
cpp/src/parquet/properties.h:
##########
@@ -817,11 +817,11 @@ class PARQUET_EXPORT ArrowReaderProperties {
     }
   }
 
-  /// \brief Set the maximum number of rows to read into a chunk or record batch.
+  /// \brief Set the maximum number of rows to read into a record batch.
   ///
   /// Will only be fewer rows when there are no more rows in the file.

Review Comment:
   ```suggestion
     /// Will only be fewer rows when there are no more rows in the file.
     /// Note that some APIs such as ReadTable may ignore this setting.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org