You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/02/16 09:29:18 UTC
[GitHub] [cloudstack] rhtyd opened a new issue #4695: Build UI without minifying
rhtyd opened a new issue #4695:
URL: https://github.com/apache/cloudstack/issues/4695
Investigate if there's a way to build the UI without minifying the source code so users can customise/edit the UI without building UI from code similar to the legacy UI (i.e. keep the source in the same folder/path structure). This may require removing webpack configs that minify/compile the UI codebase.
##### ISSUE TYPE
* Enhancement Request
##### COMPONENT NAME
<!--
Categorize the issue, e.g. API, VR, VPN, UI, etc.
-->
~~~
UI
~~~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang edited a comment on issue #4695: Build UI without minifying
Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on issue #4695:
URL: https://github.com/apache/cloudstack/issues/4695#issuecomment-781217596
On the new UI, the Admin Cloud can directly edit and save the UI. My problem is to save the changes on the client to the server as a file or database. I have 2 suggestion:
(1) Need table for save all data config UI from client
(2) Or a API for override `config.json` file on directory
@shwstppr cc @rhtyd
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on issue #4695: Build UI without minifying
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #4695:
URL: https://github.com/apache/cloudstack/issues/4695#issuecomment-781217596
On the new UI, the Admin cloud can directly edit and save the UI. My problem is to save the changes on the client to the server as a file or database. I have 2 suggestion:
(1) Need table for save all data config UI from client
(2) Or a API for override `config.json` file on directory
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on issue #4695: Build UI without minifying
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #4695:
URL: https://github.com/apache/cloudstack/issues/4695#issuecomment-786521298
In my opinion to solve this problem, it is necessary to change the src according to the input parameters from the `config.json` file (similar to customizing the UI theme before).
User will change the parameters on `config.json` and it will be applied to the UI without rebuilding.
The problem is that we need to list which objects and components to customize (for example: button, language, ...)
What do you think? @rhtyd cc @svenvogel
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang edited a comment on issue #4695: Build UI without minifying
Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on issue #4695:
URL: https://github.com/apache/cloudstack/issues/4695#issuecomment-786521298
In my opinion to solve this problem, it is necessary to change the `src` according to the input parameters from the `config.json` file (similar to customizing the UI theme before).
User will change the parameters on `config.json` and it will be applied to the UI without rebuilding.
The problem is that we need to list which objects and components to customize (for example: button, language, ...)
What do you think? @rhtyd cc @svenvogel
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on issue #4695: Build UI without minifying
Posted by GitBox <gi...@apache.org>.
shwstppr commented on issue #4695:
URL: https://github.com/apache/cloudstack/issues/4695#issuecomment-781194613
@utchoang with users Rohit probably means cloud admins. Use-case is to make it possible for cloud admin change source files directly in their installations just like old UI. cc @rhtyd
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on issue #4695: Build UI without minifying
Posted by GitBox <gi...@apache.org>.
shwstppr commented on issue #4695:
URL: https://github.com/apache/cloudstack/issues/4695#issuecomment-781213136
In new UI this is much harder or probably impossible to do this right now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on issue #4695: Build UI without minifying
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #4695:
URL: https://github.com/apache/cloudstack/issues/4695#issuecomment-780355818
@rhytd Is it to my understanding that the user does not want to edit/customize the UI using `config.json` but want to do it directly on the Interface right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #4695: Build UI without minifying
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #4695:
URL: https://github.com/apache/cloudstack/issues/4695#issuecomment-780461781
Hi @utchoang you're right, some users are expecting that the new UI would be editable like the legacy UI (making changes that are not supported via config.json, for example hiding some parts of the UI or adding new translations etc). Since the UI is minified/bundled now, this is not possible. What I'm asking is if we can investigate that (build UI without bundling/minification, if possible keep the same directory/files structure as the source).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd closed issue #4695: Build UI without minifying
Posted by GitBox <gi...@apache.org>.
rhtyd closed issue #4695:
URL: https://github.com/apache/cloudstack/issues/4695
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #4695: Build UI without minifying
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #4695:
URL: https://github.com/apache/cloudstack/issues/4695#issuecomment-786641904
Makes sense @utchoang I'll close this issue. Instead let's see if we can work on #4732, and #4731.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #4695: Build UI without minifying
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #4695:
URL: https://github.com/apache/cloudstack/issues/4695#issuecomment-786506857
Any update on this @hoangnm92 cc @svenvogel ? Is it even possible, or should we add documentation on advanced customisation describing how users should make such changes via code and then UI?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #4695: Build UI without minifying
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #4695:
URL: https://github.com/apache/cloudstack/issues/4695#issuecomment-779758600
cc @Pearl1594 @davidjumani @shwstppr @weizhouapache @wido @GabrielBrascher @ravening
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on issue #4695: Build UI without minifying
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #4695:
URL: https://github.com/apache/cloudstack/issues/4695#issuecomment-781192098
Hi @rhtyd
Regarding this correction, in my opinion there should be a few problems:
1. Need a table containing config UI to get and store config information from client to server.
2. Need 2 API get and save config UI
3. Regarding images (logo, banner image, 404 error, 403 error, 500 error), do users need to edit it directly on the UI? Because if any, then need the API for the upload.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #4695: Build UI without minifying
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #4695:
URL: https://github.com/apache/cloudstack/issues/4695#issuecomment-779744872
Hi @utchoang cc @svenvogel - since you've experience with the UI build system (npm/webpack), can you explore if this is possible as an investigation exercise (feel free to raise PoC PRs). Some users have complained they would prefer the UI be to editable like the legacy UI without requiring them to build from source.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on issue #4695: Build UI without minifying
Posted by GitBox <gi...@apache.org>.
shwstppr commented on issue #4695:
URL: https://github.com/apache/cloudstack/issues/4695#issuecomment-781212585
@utchoang With changing source files directly in installations I mean when we install cloudstack-management package all UI source files are installed at /usr/share/cloudstack-management/webapp. So, as admin and having access to the server I can directly change these files and changes will reflect for user.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang edited a comment on issue #4695: Build UI without minifying
Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on issue #4695:
URL: https://github.com/apache/cloudstack/issues/4695#issuecomment-780355818
@rhtyd Is it to my understanding that the user does not want to edit/customize the UI using `config.json` but want to do it directly on the Interface right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang edited a comment on issue #4695: Build UI without minifying
Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on issue #4695:
URL: https://github.com/apache/cloudstack/issues/4695#issuecomment-781217596
On the new UI, the Admin cloud can directly edit and save the UI. My problem is to save the changes on the client to the server as a file or database. I have 2 suggestion:
(1) Need table for save all data config UI from client
(2) Or a API for override `config.json` file on directory
@shwstppr cc @rhtyd
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang edited a comment on issue #4695: Build UI without minifying
Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on issue #4695:
URL: https://github.com/apache/cloudstack/issues/4695#issuecomment-780355818
@rhtyd Is it to my understanding that the user does not want to edit/customize the UI using `config.json` but want to do it directly on the Interface right?
cc @svenvogel
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang edited a comment on issue #4695: Build UI without minifying
Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on issue #4695:
URL: https://github.com/apache/cloudstack/issues/4695#issuecomment-781192098
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on issue #4695: Build UI without minifying
Posted by GitBox <gi...@apache.org>.
rhtyd commented on issue #4695:
URL: https://github.com/apache/cloudstack/issues/4695#issuecomment-783180789
@utchoang this is good but not what I'm asking for - we want the UI code to be customisable so not just css (limited to colours or text). For example, I want to hide the logout button and say fix the docHelp links - currently this is only possible by changing source code and building it - not by directly editing the installed UI at /usr/share/cloudstack-management/webapps on the management server. The question is will webpack/vue build allow a non-minified or bundle output that could allow users to edit the src, as some as used to this approach with the legacy UI. (note: as I said this is more of an investigation we want to explore at this point, thanks).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang edited a comment on issue #4695: Build UI without minifying
Posted by GitBox <gi...@apache.org>.
utchoang edited a comment on issue #4695:
URL: https://github.com/apache/cloudstack/issues/4695#issuecomment-786521298
In my opinion, to solve this problem, it is necessary to change the src according to the input parameters from the `config.json` file (similar to customizing the UI theme before).
The user will change the parameters on `config.json` and it will be applied to the UI without rebuilding.
The problem is that we need to list which objects and components to customize (for example button, language, ...)
What do you think? @rhtyd cc @svenvogel
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] utchoang commented on issue #4695: Build UI without minifying
Posted by GitBox <gi...@apache.org>.
utchoang commented on issue #4695:
URL: https://github.com/apache/cloudstack/issues/4695#issuecomment-781206262
@shwstppr cc @rhtyd At old UI, I can't find the UI settings area. Can you show me?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org