[GitHub] [druid] gianm commented on pull request #10550: Add zero period support to TIMESTAMPADD

[GitBox <gi...@apache.org>]

gianm commented on pull request #10550:
URL: https://github.com/apache/druid/pull/10550#issuecomment-722037855


   > And CI reports lower branch coverage of `TimestampShiftExprMacro` in processing module, while this class has been fully covered by `ExprMacroTest` which is in server module. What should I do to the CI ?
   
   You could add a test similar to TimestampExtractExprMacroTest; it's in the same module, and it's a bit more unit-test-like than ExprMacroTest, so probably a good idea anyway.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org