You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2022/04/25 16:20:38 UTC

[GitHub] [geode] kirklund commented on a diff in pull request #7554: GEM-3124: Guarding membership addition code paths to omit membership …

kirklund commented on code in PR #7554:
URL: https://github.com/apache/geode/pull/7554#discussion_r857808320


##########
geode-core/src/main/java/org/apache/geode/distributed/internal/ClusterDistributionManager.java:
##########
@@ -2373,7 +2398,7 @@ public void memberDeparted(InternalDistributedMember theId, boolean crashed, Str
           message.setCrashed(crashed);
           message.setAlertListenerExpected(true);
           message.setIgnoreAlertListenerRemovalFailure(true); // we don't know if it was a listener
-                                                              // so
+          // so

Review Comment:
   I usually take those trailing comments and move them above the line they are commenting, so that's what I recommend doing here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org