You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/02/19 14:56:27 UTC

[GitHub] [incubator-nuttx] yunkya2 opened a new pull request #2877: Support for Raspberry Pi Pico

yunkya2 opened a new pull request #2877:
URL: https://github.com/apache/incubator-nuttx/pull/2877


   ## Summary
   Basic support for Raspberry Pi Pico.
   Currently only UART console is supported. See boards/arm/rp2040/raspberrypi-pico/README.txt.
   
   #2876 is required for this board support.
   
   ## Impact
   New architecture arm/rp2040/raspberrypi-pico is added.
   
   ## Testing
   New configuration `raspberrypi-pico:nsh` passes ostest.
   
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull request #2877: Support for Raspberry Pi Pico

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on a change in pull request #2877:
URL: https://github.com/apache/incubator-nuttx/pull/2877#discussion_r579487676



##########
File path: arch/arm/src/rp2040/Kconfig
##########
@@ -0,0 +1,74 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+comment "RP2040 Configuration Options"
+
+config RP2040_UART0
+	bool "UART0"
+	default y
+	select UART0_SERIALDRIVER
+	select ARCH_HAVE_SERIAL_TERMIOS
+
+if RP2040_UART0
+
+config RP2040_UART0_BAUD
+	int "RP2040 UART0 BAUD"
+	default 115200
+
+config RP2040_UART0_PARITY
+	int "CXd56 UART0 parity"
+	default 0
+	range 0 2
+	---help---
+		RP2040 UART0 parity.  0=None, 1=Odd, 2=Even.  Default: None
+
+config RP2040_UART0_BITS
+	int "RP2040 UART0 number of bits"
+	default 8
+	range 5 8
+	---help---
+		RP2040 UART0 number of bits.  Default: 8
+
+config RP2040_UART0_2STOP
+	int "RP2040 UART0 two stop bits"
+	default 0
+	---help---
+		0=1 stop bit, 1=Two stop bits.  Default: 1 stop bit
+
+endif
+
+config RP2040_UART1
+	bool "UART1"
+	default n
+	select UART1_SERIALDRIVER
+	select ARCH_HAVE_SERIAL_TERMIOS
+
+if RP2040_UART1
+
+config RP2040_UART1_BAUD
+	int "RP2040 UART0 BAUD"
+	default 115200
+
+config RP2040_UART1_PARITY
+	int "CXd56 UART0 parity"
+	default 0

Review comment:
       CXd56 UART0 -> PR2040 UART1 ?
   

##########
File path: arch/arm/src/rp2040/Kconfig
##########
@@ -0,0 +1,74 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+comment "RP2040 Configuration Options"
+
+config RP2040_UART0
+	bool "UART0"
+	default y
+	select UART0_SERIALDRIVER
+	select ARCH_HAVE_SERIAL_TERMIOS
+
+if RP2040_UART0
+
+config RP2040_UART0_BAUD
+	int "RP2040 UART0 BAUD"
+	default 115200
+
+config RP2040_UART0_PARITY
+	int "CXd56 UART0 parity"
+	default 0
+	range 0 2
+	---help---
+		RP2040 UART0 parity.  0=None, 1=Odd, 2=Even.  Default: None
+
+config RP2040_UART0_BITS
+	int "RP2040 UART0 number of bits"
+	default 8
+	range 5 8
+	---help---
+		RP2040 UART0 number of bits.  Default: 8
+
+config RP2040_UART0_2STOP
+	int "RP2040 UART0 two stop bits"
+	default 0
+	---help---
+		0=1 stop bit, 1=Two stop bits.  Default: 1 stop bit
+
+endif
+
+config RP2040_UART1
+	bool "UART1"
+	default n
+	select UART1_SERIALDRIVER
+	select ARCH_HAVE_SERIAL_TERMIOS
+
+if RP2040_UART1
+
+config RP2040_UART1_BAUD
+	int "RP2040 UART0 BAUD"
+	default 115200
+
+config RP2040_UART1_PARITY
+	int "CXd56 UART0 parity"
+	default 0
+	range 0 2
+	---help---
+		RP2040 UART0 parity.  0=None, 1=Odd, 2=Even.  Default: None
+
+config RP2040_UART1_BITS
+	int "RP2040 UART0 number of bits"

Review comment:
       UART0 -> UART1 ?
   

##########
File path: arch/arm/src/rp2040/Kconfig
##########
@@ -0,0 +1,74 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+comment "RP2040 Configuration Options"
+
+config RP2040_UART0
+	bool "UART0"
+	default y
+	select UART0_SERIALDRIVER
+	select ARCH_HAVE_SERIAL_TERMIOS
+
+if RP2040_UART0
+
+config RP2040_UART0_BAUD
+	int "RP2040 UART0 BAUD"
+	default 115200
+
+config RP2040_UART0_PARITY
+	int "CXd56 UART0 parity"
+	default 0
+	range 0 2
+	---help---
+		RP2040 UART0 parity.  0=None, 1=Odd, 2=Even.  Default: None
+
+config RP2040_UART0_BITS
+	int "RP2040 UART0 number of bits"
+	default 8
+	range 5 8
+	---help---
+		RP2040 UART0 number of bits.  Default: 8
+
+config RP2040_UART0_2STOP
+	int "RP2040 UART0 two stop bits"
+	default 0
+	---help---
+		0=1 stop bit, 1=Two stop bits.  Default: 1 stop bit
+
+endif
+
+config RP2040_UART1
+	bool "UART1"
+	default n
+	select UART1_SERIALDRIVER
+	select ARCH_HAVE_SERIAL_TERMIOS
+
+if RP2040_UART1
+
+config RP2040_UART1_BAUD
+	int "RP2040 UART0 BAUD"

Review comment:
       UART0 -> UART1 ?
   

##########
File path: arch/arm/src/rp2040/Kconfig
##########
@@ -0,0 +1,74 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+comment "RP2040 Configuration Options"
+
+config RP2040_UART0
+	bool "UART0"
+	default y
+	select UART0_SERIALDRIVER
+	select ARCH_HAVE_SERIAL_TERMIOS
+
+if RP2040_UART0
+
+config RP2040_UART0_BAUD
+	int "RP2040 UART0 BAUD"
+	default 115200
+
+config RP2040_UART0_PARITY
+	int "CXd56 UART0 parity"
+	default 0
+	range 0 2
+	---help---
+		RP2040 UART0 parity.  0=None, 1=Odd, 2=Even.  Default: None
+
+config RP2040_UART0_BITS
+	int "RP2040 UART0 number of bits"
+	default 8
+	range 5 8
+	---help---
+		RP2040 UART0 number of bits.  Default: 8
+
+config RP2040_UART0_2STOP
+	int "RP2040 UART0 two stop bits"
+	default 0
+	---help---
+		0=1 stop bit, 1=Two stop bits.  Default: 1 stop bit
+
+endif
+
+config RP2040_UART1
+	bool "UART1"
+	default n
+	select UART1_SERIALDRIVER
+	select ARCH_HAVE_SERIAL_TERMIOS
+
+if RP2040_UART1
+
+config RP2040_UART1_BAUD
+	int "RP2040 UART0 BAUD"
+	default 115200
+
+config RP2040_UART1_PARITY
+	int "CXd56 UART0 parity"
+	default 0
+	range 0 2
+	---help---
+		RP2040 UART0 parity.  0=None, 1=Odd, 2=Even.  Default: None
+
+config RP2040_UART1_BITS
+	int "RP2040 UART0 number of bits"
+	default 8
+	range 5 8
+	---help---
+		RP2040 UART0 number of bits.  Default: 8

Review comment:
       UART0 -> UART1 ?
   

##########
File path: arch/arm/src/rp2040/Kconfig
##########
@@ -0,0 +1,74 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+comment "RP2040 Configuration Options"
+
+config RP2040_UART0
+	bool "UART0"
+	default y
+	select UART0_SERIALDRIVER
+	select ARCH_HAVE_SERIAL_TERMIOS
+
+if RP2040_UART0
+
+config RP2040_UART0_BAUD
+	int "RP2040 UART0 BAUD"
+	default 115200
+
+config RP2040_UART0_PARITY
+	int "CXd56 UART0 parity"
+	default 0
+	range 0 2
+	---help---
+		RP2040 UART0 parity.  0=None, 1=Odd, 2=Even.  Default: None
+
+config RP2040_UART0_BITS
+	int "RP2040 UART0 number of bits"
+	default 8
+	range 5 8
+	---help---
+		RP2040 UART0 number of bits.  Default: 8
+
+config RP2040_UART0_2STOP
+	int "RP2040 UART0 two stop bits"
+	default 0
+	---help---
+		0=1 stop bit, 1=Two stop bits.  Default: 1 stop bit
+
+endif
+
+config RP2040_UART1
+	bool "UART1"
+	default n
+	select UART1_SERIALDRIVER
+	select ARCH_HAVE_SERIAL_TERMIOS
+
+if RP2040_UART1
+
+config RP2040_UART1_BAUD
+	int "RP2040 UART0 BAUD"
+	default 115200
+
+config RP2040_UART1_PARITY
+	int "CXd56 UART0 parity"
+	default 0
+	range 0 2
+	---help---
+		RP2040 UART0 parity.  0=None, 1=Odd, 2=Even.  Default: None

Review comment:
       UART0 -> UART1 ?
   

##########
File path: arch/arm/src/rp2040/Kconfig
##########
@@ -0,0 +1,74 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+comment "RP2040 Configuration Options"
+
+config RP2040_UART0
+	bool "UART0"
+	default y
+	select UART0_SERIALDRIVER
+	select ARCH_HAVE_SERIAL_TERMIOS
+
+if RP2040_UART0
+
+config RP2040_UART0_BAUD
+	int "RP2040 UART0 BAUD"
+	default 115200
+
+config RP2040_UART0_PARITY
+	int "CXd56 UART0 parity"
+	default 0
+	range 0 2
+	---help---
+		RP2040 UART0 parity.  0=None, 1=Odd, 2=Even.  Default: None
+
+config RP2040_UART0_BITS
+	int "RP2040 UART0 number of bits"
+	default 8
+	range 5 8
+	---help---
+		RP2040 UART0 number of bits.  Default: 8
+
+config RP2040_UART0_2STOP
+	int "RP2040 UART0 two stop bits"
+	default 0
+	---help---
+		0=1 stop bit, 1=Two stop bits.  Default: 1 stop bit
+
+endif
+
+config RP2040_UART1
+	bool "UART1"
+	default n
+	select UART1_SERIALDRIVER
+	select ARCH_HAVE_SERIAL_TERMIOS
+
+if RP2040_UART1
+
+config RP2040_UART1_BAUD
+	int "RP2040 UART0 BAUD"
+	default 115200
+
+config RP2040_UART1_PARITY
+	int "CXd56 UART0 parity"
+	default 0
+	range 0 2
+	---help---
+		RP2040 UART0 parity.  0=None, 1=Odd, 2=Even.  Default: None
+
+config RP2040_UART1_BITS
+	int "RP2040 UART0 number of bits"
+	default 8
+	range 5 8
+	---help---
+		RP2040 UART0 number of bits.  Default: 8
+
+config RP2040_UART1_2STOP
+	int "RP2040 UART0 two stop bits"

Review comment:
       UART0 -> UART1 ?
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull request #2877: Support for Raspberry Pi Pico

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on a change in pull request #2877:
URL: https://github.com/apache/incubator-nuttx/pull/2877#discussion_r579487030



##########
File path: arch/arm/src/rp2040/Kconfig
##########
@@ -0,0 +1,74 @@
+#
+# For a description of the syntax of this configuration file,
+# see the file kconfig-language.txt in the NuttX tools repository.
+#
+
+comment "RP2040 Configuration Options"
+
+config RP2040_UART0
+	bool "UART0"
+	default y
+	select UART0_SERIALDRIVER
+	select ARCH_HAVE_SERIAL_TERMIOS
+
+if RP2040_UART0
+
+config RP2040_UART0_BAUD
+	int "RP2040 UART0 BAUD"
+	default 115200
+
+config RP2040_UART0_PARITY
+	int "CXd56 UART0 parity"

Review comment:
       CXd56 -> PR2040 ?
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2877: Support for Raspberry Pi Pico

Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2877:
URL: https://github.com/apache/incubator-nuttx/pull/2877


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull request #2877: Support for Raspberry Pi Pico

Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on a change in pull request #2877:
URL: https://github.com/apache/incubator-nuttx/pull/2877#discussion_r579486026



##########
File path: arch/arm/Kconfig
##########
@@ -225,6 +225,13 @@ config ARCH_CHIP_NUC1XX
 	---help---
 		Nuvoton NUC100/120 architectures (ARM Cortex-M0).
 
+config ARCH_CHIP_RP2040
+	bool "Raspberry Pi RP2040"
+	select ARCH_CORTEXM0
+	select ARCH_HAVE_RAMVECTORS
+	---help---
+		Raspberry Pi RP2040 architectures (ARM Cortex-M0).

Review comment:
       M0 -> M0+ ?
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org