Re: svn commit: r439872 - in /spamassassin/trunk/lib/Mail: ./ SpamAssassin/ SpamAssassin/Message/

[Justin Mason <jm...@jmason.org>]

felicity@apache.org writes:
> --- spamassassin/trunk/lib/Mail/SpamAssassin/Message/Node.pm (original)
> +++ spamassassin/trunk/lib/Mail/SpamAssassin/Message/Node.pm Sun Sep  3 16:07:59 2006
> @@ -641,36 +641,5 @@
>  
>  # ---------------------------------------------------------------------------
>  
> -=item finish()
> -
> -Clean up the object so that it can be destroyed.
> -
> -=cut
> -
> -sub finish {
> -  my ($self) = @_;
> -
> -  foreach my $part ( $self->find_parts(qr/./) ) {
> -    foreach (
> -      'headers',
> -      'raw_headers',
> -      'header_order',
> -      'raw',
> -      'decoded',
> -      'rendered',
> -      'visible_rendered',
> -      'invisible_rendered',
> -      'type',
> -      'rendered_type',
> -      'body_parts',
> -    ) {
> -      undef $part->{$_};
> -      delete $part->{$_};
> -    }
> -  }
> -}

Hey -- I'm generally +1 on this patch, but this has me worried. in my
opinion, if a method has POD documentation, that's equivalent in our terms
to it being a public API, suitable for calling by users -- in which case
its removal is not trivial.

Any chance you could leave a 

  sub finish { } 

in there on Node.pm, just to avoid possible die() calls if there are
people calling it?

--j.