(superset) branch master updated: fix: Enable explore button on SQL Lab view when connected to Apache Pinot as a database (#28364)

[sf...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

sfirke pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git


The following commit(s) were added to refs/heads/master by this push:
     new 6d2b3b8698 fix: Enable explore button on SQL Lab view when connected to Apache Pinot as a database (#28364)
6d2b3b8698 is described below

commit 6d2b3b86988b7fbc38399ad6ef5df83e798ac8a3
Author: soumitra-st <12...@users.noreply.github.com>
AuthorDate: Fri Jul 5 06:32:42 2024 -0700

    fix: Enable explore button on SQL Lab view when connected to Apache Pinot as a database (#28364)
---
 docs/docs/configuration/databases.mdx | 5 +++++
 pyproject.toml                        | 2 +-
 superset/db_engine_specs/pinot.py     | 4 ----
 3 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/docs/docs/configuration/databases.mdx b/docs/docs/configuration/databases.mdx
index 911cd11da7..2b23c464dd 100644
--- a/docs/docs/configuration/databases.mdx
+++ b/docs/docs/configuration/databases.mdx
@@ -1035,6 +1035,11 @@ The expected connection string using username and password is formatted as follo
 pinot://<username>:<password>@<pinot-broker-host>:<pinot-broker-port>/query/sql?controller=http://<pinot-controller-host>:<pinot-controller-port>/verify_ssl=true``
 ```
 
+If you want to use explore view or joins, window functions, etc. then enable [multi-stage query engine](https://docs.pinot.apache.org/reference/multi-stage-engine).
+Add below argument while creating database connection in Advanced -> Other -> ENGINE PARAMETERS
+```
+{"connect_args":{"use_multistage_engine":"true"}}
+```
 
 #### Postgres
 
diff --git a/pyproject.toml b/pyproject.toml
index efb211c0d3..26b020f98c 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -151,7 +151,7 @@ ocient = [
     "geojson",
 ]
 oracle = ["cx-Oracle>8.0.0, <8.1"]
-pinot = ["pinotdb>=0.3.3, <0.4"]
+pinot = ["pinotdb>=5.0.0, <6.0.0"]
 playwright = ["playwright>=1.37.0, <2"]
 postgres = ["psycopg2-binary==2.9.6"]
 presto = ["pyhive[presto]>=0.6.5"]
diff --git a/superset/db_engine_specs/pinot.py b/superset/db_engine_specs/pinot.py
index 0f53cfa77b..faf919f103 100644
--- a/superset/db_engine_specs/pinot.py
+++ b/superset/db_engine_specs/pinot.py
@@ -25,10 +25,6 @@ from superset.db_engine_specs.base import BaseEngineSpec
 class PinotEngineSpec(BaseEngineSpec):
     engine = "pinot"
     engine_name = "Apache Pinot"
-    allows_subqueries = False
-    allows_joins = False
-    allows_alias_in_select = False
-    allows_alias_in_orderby = False
 
     # https://docs.pinot.apache.org/users/user-guide-query/supported-transformations#datetime-functions
     _time_grain_expressions = {