You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2019/01/17 20:15:38 UTC

[GitHub] davebfid opened a new pull request #44: Performance fix for lookup up windows username

davebfid opened a new pull request #44: Performance fix for lookup up windows username
URL: https://github.com/apache/logging-log4net/pull/44
 
 
   This should fix LOG4NET-429 and I think it is a better approach than everything else which has been suggested.
   
   The approach is when the user name is requested, to cache the username and the sid of the current user, the next time user name is requested if the sid hasn't changed then returned the cached user name
   
   Internally in .NET when you call WindowsIdentity.GetCurrent().Name it takes the sid and translates it into the account name, so this approach should work fine.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services