[GitHub] [skywalking] peng-yongsheng edited a comment on issue #2808: Good news of an important feature: time series implementation in Elasticsearch storage.

[GitBox <gi...@apache.org>]

peng-yongsheng edited a comment on issue #2808: Good news of an important feature: time series implementation in Elasticsearch storage.
URL: https://github.com/apache/skywalking/pull/2808#issuecomment-498119741
 
 
   > * Recommend rename `timeSeriesAble` to `capableOfTimeSeries`.
   I agree and I will rename it in this PR.
   > * We should consider to bind `deleteHistory` and `timeSeriesAble` with **processor**. Also we could remove `@ Storage` and create `builder` for `@Storage`.
   I have also thought about this. The streaming scenes of SkyWalking are sperate by the processors and the `deleteHistory` and `timeSeriesAble` is the ability of the processors. We can set them in processors, didn't need to define in the storage.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services