[GitHub] [maven-shared-incremental] michael-o commented on a diff in pull request #18: store last compilation time

[GitBox <gi...@apache.org>]

michael-o commented on code in PR #18:
URL: https://github.com/apache/maven-shared-incremental/pull/18#discussion_r1050467545


##########
src/main/java/org/apache/maven/shared/incremental/IncrementalBuildHelper.java:
##########
@@ -48,6 +52,13 @@
     public static final String CREATED_FILES_LST_FILENAME = "createdFiles.lst";
     private static final String INPUT_FILES_LST_FILENAME = "inputFiles.lst";
 
+    private static final String INFO_FILENAME = "info.properties";
+
+    private static final String LAST_COMPILE_SUCCESS_TIMESTAMP = "lastCompile.success.timestamp";
+
+    private static final String LAST_TEST_COMPILE_SUCCESS_TIMESTAMP = "lastTestCompile.success.timestamp";

Review Comment:
   Unless you are going to have other keys under `success` one should rather use underscores or camelCase since dots denote a hierarchy. Similar: https://issues.apache.org/jira/browse/VELOCITY-909



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org