Change in asterixdb[master]: [ASTERIXDB-2488][COMP] Support aggregate window functions

["Ali Alsuliman (Code Review)" <do...@asterixdb.incubator.apache.org>]

Ali Alsuliman has posted comments on this change.

Change subject: [ASTERIXDB-2488][COMP] Support aggregate window functions
......................................................................


Patch Set 5: Code-Review+2

(2 comments)

https://asterix-gerrit.ics.uci.edu/#/c/3049/5/asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/window/pg_win/pg_win.100.query.sqlpp
File asterixdb/asterix-app/src/test/resources/runtimets/queries_sqlpp/window/pg_win/pg_win.100.query.sqlpp:

PS5, Line 30: salary
missing ";"


https://asterix-gerrit.ics.uci.edu/#/c/3049/5/asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/VariableCheckAndRewriteVisitor.java
File asterixdb/asterix-lang-sqlpp/src/main/java/org/apache/asterix/lang/sqlpp/rewrites/visitor/VariableCheckAndRewriteVisitor.java:

PS5, Line 207: public Expression visit
@Override got removed by mistake?


-- 
To view, visit https://asterix-gerrit.ics.uci.edu/3049
To unsubscribe, visit https://asterix-gerrit.ics.uci.edu/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If0f71118a04c2dbd3462070673d52e67f076b7e1
Gerrit-PatchSet: 5
Gerrit-Project: asterixdb
Gerrit-Branch: master
Gerrit-Owner: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: Ali Alsuliman <al...@gmail.com>
Gerrit-Reviewer: Anon. E. Moose #1000171
Gerrit-Reviewer: Dmitry Lychagin <dm...@couchbase.com>
Gerrit-Reviewer: James Fang <jf...@ucr.edu>
Gerrit-Reviewer: Jenkins <je...@fulliautomatix.ics.uci.edu>
Gerrit-Reviewer: Taewoo Kim <wa...@gmail.com>
Gerrit-Reviewer: Till Westmann <ti...@apache.org>
Gerrit-HasComments: Yes