You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@cloudstack.apache.org by Gaurav Aradhye <ga...@clogeny.com> on 2014/12/23 13:13:00 UTC

Review Request 29363: CLOUDSTACK-8116: Moved ldap data to configurableData section in test_data.py and made related changes in the test case

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29363/
-----------------------------------------------------------

Review request for cloudstack and SrikanteswaraRao Talluri.


Bugs: CLOUDSTACK-8116
    https://issues.apache.org/jira/browse/CLOUDSTACK-8116


Repository: cloudstack-git


Description
-------

Moved ldap data to configurableData section in test_data.py and made related changes in the test case.
Also fixed pep8 issues and imports.


Diffs
-----

  test/integration/component/test_ldap.py 5a78957 
  tools/marvin/marvin/config/test_data.py ba2fb24 

Diff: https://reviews.apache.org/r/29363/diff/


Testing
-------

Not tested. Requires ldap server to be setup. The test case will be run successfully when correct information is filled in test_data.py file.


Thanks,

Gaurav Aradhye

Re: Review Request 29363: CLOUDSTACK-8116: Moved ldap data to configurableData section in test_data.py and made related changes in the test case

Posted by SrikanteswaraRao Talluri <sr...@citrix.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29363/#review66021
-----------------------------------------------------------

Ship it!


Ship It!

- SrikanteswaraRao Talluri


On Dec. 23, 2014, 12:13 p.m., Gaurav Aradhye wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29363/
> -----------------------------------------------------------
> 
> (Updated Dec. 23, 2014, 12:13 p.m.)
> 
> 
> Review request for cloudstack and SrikanteswaraRao Talluri.
> 
> 
> Bugs: CLOUDSTACK-8116
>     https://issues.apache.org/jira/browse/CLOUDSTACK-8116
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> Moved ldap data to configurableData section in test_data.py and made related changes in the test case.
> Also fixed pep8 issues and imports.
> 
> 
> Diffs
> -----
> 
>   test/integration/component/test_ldap.py 5a78957 
>   tools/marvin/marvin/config/test_data.py ba2fb24 
> 
> Diff: https://reviews.apache.org/r/29363/diff/
> 
> 
> Testing
> -------
> 
> Not tested. Requires ldap server to be setup. The test case will be run successfully when correct information is filled in test_data.py file.
> 
> 
> Thanks,
> 
> Gaurav Aradhye
> 
>