You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by markflyhigh <gi...@git.apache.org> on 2017/01/10 07:58:34 UTC

[GitHub] beam pull request #1756: [BEAM-1188] Python File Verifer For E2E Tests

GitHub user markflyhigh opened a pull request:

    https://github.com/apache/beam/pull/1756

    [BEAM-1188] Python File Verifer For E2E Tests

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [x] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    Add FileChecksumVerifier to verify E2E test output file(s) locally or on GCS:
     - Refactor TestPipeline to be clean and able to get option value by name
     - Create FileChecksumVerifier with retry when IO failed.
     - Add FileChecksumVerifier to wordcount e2e test
     - Create test_utils to hold utility method for testing.
    
    Test is done by running wordcount_it against Dataflow service.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/markflyhigh/incubator-beam file-checksum-verifier

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/1756.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1756
    
----
commit 16109f1651dd9537464687129d8d0c0f3a6a4a91
Author: Mark Liu <ma...@google.com>
Date:   2017-01-10T07:48:42Z

    [BEAM-1188] Python File Verifer For E2E Tests

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] beam pull request #1756: [BEAM-1188] Python File Verifier For E2E Tests

Posted by markflyhigh <gi...@git.apache.org>.
Github user markflyhigh closed the pull request at:

    https://github.com/apache/beam/pull/1756


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---