You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "Akshat-Jain (via GitHub)" <gi...@apache.org> on 2024/12/16 06:21:58 UTC
[PR] Add back `UnnecessaryFullyQualifiedName` rule in pmd ruleset (druid)
Akshat-Jain opened a new pull request, #17570:
URL: https://github.com/apache/druid/pull/17570
### Description
In #17466, we had added exclusion for `UnnecessaryFullyQualifiedName` rule to avoid any the large number of irrelevant changes to the PR on upgrading `maven-pmd-plugin` version.
This PR re-visits that and adds back the `UnnecessaryFullyQualifiedName` rule, fixing all violations of the rule across the project.
<hr>
This PR has:
- [x] been self-reviewed.
- [ ] using the [concurrency checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in [licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Add back `UnnecessaryFullyQualifiedName` rule in pmd ruleset (druid)
Posted by "cryptoe (via GitHub)" <gi...@apache.org>.
cryptoe merged PR #17570:
URL: https://github.com/apache/druid/pull/17570
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Add back `UnnecessaryFullyQualifiedName` rule in pmd ruleset (druid)
Posted by "github-advanced-security[bot] (via GitHub)" <gi...@apache.org>.
github-advanced-security[bot] commented on code in PR #17570:
URL: https://github.com/apache/druid/pull/17570#discussion_r1886265896
##########
integration-tests/src/main/java/org/apache/druid/testing/utils/AvroSchemaRegistryEventSerializer.java:
##########
@@ -73,7 +73,7 @@
try {
RetryUtils.retry(
() -> {
- schemaId = client.register(topic, AvroEventSerializer.SCHEMA);
+ schemaId = client.register(topic, SCHEMA);
Review Comment:
## Deprecated method or constructor invocation
Invoking [SchemaRegistryClient.register](1) should be avoided because it has been deprecated.
[Show more details](https://github.com/apache/druid/security/code-scanning/8567)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Add back `UnnecessaryFullyQualifiedName` rule in pmd ruleset (druid)
Posted by "gianm (via GitHub)" <gi...@apache.org>.
gianm commented on PR #17570:
URL: https://github.com/apache/druid/pull/17570#issuecomment-2550264237
IMO the old style was better. Reading through the diff the new code often feels less clear. So I think we should revert this, and consider requiring that static methods be qualified. TBH I thought they were already required to be qualified outside tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] Add back `UnnecessaryFullyQualifiedName` rule in pmd ruleset (druid)
Posted by "Akshat-Jain (via GitHub)" <gi...@apache.org>.
Akshat-Jain commented on code in PR #17570:
URL: https://github.com/apache/druid/pull/17570#discussion_r1886362392
##########
integration-tests/src/main/java/org/apache/druid/testing/utils/AvroSchemaRegistryEventSerializer.java:
##########
@@ -73,7 +73,7 @@
try {
RetryUtils.retry(
() -> {
- schemaId = client.register(topic, AvroEventSerializer.SCHEMA);
+ schemaId = client.register(topic, SCHEMA);
Review Comment:
Unrelated to this PR's code changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org