You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "ahmedabu98 (via GitHub)" <gi...@apache.org> on 2023/06/21 15:01:02 UTC
[GitHub] [beam] ahmedabu98 opened a new pull request, #27202: Simplify SchemaTransforms
ahmedabu98 opened a new pull request, #27202:
URL: https://github.com/apache/beam/pull/27202
Context in this thread: https://lists.apache.org/thread/69cv98s9fr8qqvvg67wy9ydfmm8v12wd
These changes start by making SchemaTransform an empty abstract class extending `PTransform<PCollectionRowTuple, PCollectionRowTuple>`. This decision was made in part to keep `SchemaTransform` in the codebase instead of reducing the word to just a concept. Another reason of keeping it is for better readability (SchemaTransformProvider provides a SchemaTransform; a SchemaTransform is a transform that works with Rows and therefore is Schema-aware)
The rest of the changes are for updating the SchemaTransformProviders in our codebase to reflect this change. The way we go from SchemaTransformProvider to PTransform is simplified, but this should not affect the way it's used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ahmedabu98 commented on pull request #27202: Simplify SchemaTransform API
Posted by "ahmedabu98 (via GitHub)" <gi...@apache.org>.
ahmedabu98 commented on PR #27202:
URL: https://github.com/apache/beam/pull/27202#issuecomment-1602984931
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj merged pull request #27202: Simplify SchemaTransform API
Posted by "chamikaramj (via GitHub)" <gi...@apache.org>.
chamikaramj merged PR #27202:
URL: https://github.com/apache/beam/pull/27202
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ahmedabu98 commented on pull request #27202: Simplify SchemaTransform API
Posted by "ahmedabu98 (via GitHub)" <gi...@apache.org>.
ahmedabu98 commented on PR #27202:
URL: https://github.com/apache/beam/pull/27202#issuecomment-1603050045
Run SQL PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johnjcasey commented on pull request #27202: Simplify SchemaTransform API
Posted by "johnjcasey (via GitHub)" <gi...@apache.org>.
johnjcasey commented on PR #27202:
URL: https://github.com/apache/beam/pull/27202#issuecomment-1612144198
run java precommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] chamikaramj commented on pull request #27202: Simplify SchemaTransform API
Posted by "chamikaramj (via GitHub)" <gi...@apache.org>.
chamikaramj commented on PR #27202:
URL: https://github.com/apache/beam/pull/27202#issuecomment-1613320079
LGTM. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ahmedabu98 commented on pull request #27202: Simplify SchemaTransform API
Posted by "ahmedabu98 (via GitHub)" <gi...@apache.org>.
ahmedabu98 commented on PR #27202:
URL: https://github.com/apache/beam/pull/27202#issuecomment-1602963791
Run Java_Debezium_IO_Direct PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ahmedabu98 commented on pull request #27202: Simplify SchemaTransform API
Posted by "ahmedabu98 (via GitHub)" <gi...@apache.org>.
ahmedabu98 commented on PR #27202:
URL: https://github.com/apache/beam/pull/27202#issuecomment-1602984611
Run Java_Debezium_IO_Direct PreCommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #27202: Simplify SchemaTransform API
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27202:
URL: https://github.com/apache/beam/pull/27202#issuecomment-1611336831
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @kennknowles for label java.
R: @johnjcasey for label io.
R: @nielm for label spanner.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] ahmedabu98 commented on pull request #27202: Simplify SchemaTransform API
Posted by "ahmedabu98 (via GitHub)" <gi...@apache.org>.
ahmedabu98 commented on PR #27202:
URL: https://github.com/apache/beam/pull/27202#issuecomment-1612150214
Bigtable write schematransform was merged yesterday, will need to sync with head and change that one too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #27202: Simplify SchemaTransform API
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #27202:
URL: https://github.com/apache/beam/pull/27202#issuecomment-1603281800
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] johnjcasey commented on pull request #27202: Simplify SchemaTransform API
Posted by "johnjcasey (via GitHub)" <gi...@apache.org>.
johnjcasey commented on PR #27202:
URL: https://github.com/apache/beam/pull/27202#issuecomment-1611291206
run java precommit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org