[GitHub] [daffodil-vscode] stevedlawrence commented on a change in pull request #1: Add LICENSE/NOTICE/asf.yml files

[GitBox <gi...@apache.org>]

stevedlawrence commented on a change in pull request #1:
URL: https://github.com/apache/daffodil-vscode/pull/1#discussion_r626548492



##########
File path: .asf.yaml
##########
@@ -0,0 +1,30 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+# 
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+github:
+  description: "Apache Daffodil VSCode"
+  homepage: https://daffodil.apache.org/
+  features:
+    wiki:     false
+    issues:   false
+    projects: false
+  enabled_merge_buttons:
+    squash:   false
+    merge:    false
+    rebase:   true

Review comment:
       The main reason I don't like the squash merge is because last I checked, it creates a merge commit if the PR isn't directly on top master. I try to avoid merge commits as much as possible.
   
   My other issue with squash is that whoever created the PR probably has a better idea what a good squashed commit message should be, rather than whoever happens to be merging the PR. I'd rather the author fixup the message first, and the the merger doesn't have to do anything.
   
   So it's not so much about forcing others to learn the workflow, but more I like to avoid merge commits, and the author of the commit knows best what a squash commit should be, rather than the merger.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org