[jira] Assigned: (WICKET-1172) FormComponentFeedbackIndicator and FormComponentFeedbackBorder is broken

["Johan Compagner (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Johan Compagner reassigned WICKET-1172:
---------------------------------------

    Assignee: Johan Compagner

this is weird, because the FormComponentFeedbackBorder it self is still visible..
Its the indicator that will be set to none visible which is a child of the FormComponentFeedbackBorder
so onBeforeRender should be called on it because isVisible of the border itself should still return true.

You are right about the FormComponentFeedbackIndicator that one sets itself none visible so then it goes wrong. But can you be sure/test that it also really goes wrong for FormComponentFeedbackBorder ?
Do you have a simple test (junit if possible)

> FormComponentFeedbackIndicator and FormComponentFeedbackBorder is broken
> ------------------------------------------------------------------------
>
>                 Key: WICKET-1172
>                 URL: https://issues.apache.org/jira/browse/WICKET-1172
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.3.0-rc1
>            Reporter: Dmitry Rzhevskiy
>            Assignee: Johan Compagner
>            Priority: Critical
>
> FormComponentFeedbackIndicator is not work. FormComponentFeedbackIndicator  always invisible because:
> first render forms contain no errors, 
> method FormComponentFeedbackIndicator.onBeforeRender  (line 78)  sets component invisible.
> onBeforeRender() not call for invisible components.
> workaround: override isVisible method :
>  @Override
>       public boolean isVisible() {
>         return Session.get().getFeedbackMessages().hasMessage(this.getFeedbackMessageFilter());
>       }
> method onBeforeRender don't need override in org.apache.wicket.markup.html.form.validation.FormComponentFeedbackIndicator
> same situation with FormComponentFeedbackBorder .

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.