You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "fitzee (via GitHub)" <gi...@apache.org> on 2026/07/21 08:23:55 UTC
[PR] fix(native-filters): keep filter value input caret left-aligned [superset]
fitzee opened a new pull request, #42266:
URL: https://github.com/apache/superset/pull/42266
### SUMMARY
When clicking into a dashboard native-filter **value** control (e.g. a multi-select filter), the caret and the placeholder/typed text render **centered** instead of left-aligned.
This is a regression from the Ant Design v6 upgrade. antd v6 emits `text-align: center` directly on `.ant-select-multiple .ant-select-content` (its own css-in-js). The Select search `<input>` lives inside `.ant-select-content` and resolves `text-align` by inheritance, so the caret/text inherit the centered value.
**Fix:** in the shared `FilterPluginStyle` wrapper used by all native filter value plugins, pin `text-align: start` and override `.ant-select .ant-select-content` directly. Overriding the element itself is required because a value inherited from an ancestor cannot beat a rule that targets `.ant-select-content` directly. The override's specificity (wrapper class + two antd classes = `0,3,0`) beats antd's `.ant-select-multiple .ant-select-content` (`0,2,0`) without `!important`. `start` is the CSS default, so this is a no-op except where antd leaked the centered alignment, and it's RTL-safe.
Scoped to native filter value controls (Select, Range, Time, TimeColumn, TimeGrain) — no app-wide blast radius.
### TESTING INSTRUCTIONS
1. Add a native filter of type **Value** (multi-select) to a dashboard.
2. Click into the filter's input.
3. The caret and placeholder/typed text should be left-aligned (inline start), not centered.
### ADDITIONAL INFORMATION
- [ ] Has associated issue
- [x] Required feature flags: n/a
- [x] Changes UI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(native-filters): keep filter value input caret left-aligned [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on code in PR #42266:
URL: https://github.com/apache/superset/pull/42266#discussion_r3626493945
##########
superset-frontend/src/filters/components/common.ts:
##########
@@ -25,6 +25,22 @@ export const RESPONSIVE_WIDTH = 0;
export const FilterPluginStyle = styled.div<PluginFilterStylesProps>`
min-height: ${({ height }) => height}px;
width: ${({ width }) => (width === RESPONSIVE_WIDTH ? '100%' : `${width}px`)};
+ /* Input / InputNumber filter value controls resolve text-align by */
+ /* inheritance, so pin them to the inline start to keep the caret and typed */
+ /* text at the left edge. */
+ text-align: start;
Review Comment:
Can we add a focused Jest regression test for this fix? Rendering `FilterPluginStyle` and asserting each retained `text-align: start` rule with `toHaveStyleRule` would protect the corrective CSS; the existing DOM-contract test only protects the Ant Design class hook.
##########
superset-frontend/src/filters/components/common.ts:
##########
@@ -25,6 +25,22 @@ export const RESPONSIVE_WIDTH = 0;
export const FilterPluginStyle = styled.div<PluginFilterStylesProps>`
min-height: ${({ height }) => height}px;
width: ${({ width }) => (width === RESPONSIVE_WIDTH ? '100%' : `${width}px`)};
+ /* Input / InputNumber filter value controls resolve text-align by */
+ /* inheritance, so pin them to the inline start to keep the caret and typed */
+ /* text at the left edge. */
+ text-align: start;
+
+ /* antd v6 sets 'text-align: center' directly on '.ant-select-content' for */
Review Comment:
The locked Ant Design 6.5.1 CSS does not set `text-align: center` on `.ant-select-multiple .ant-select-content`; that rule only sets wrapping, item alignment, and line height. Can we keep the wrapper-level rule, remove this nested selector, and document the actual inherited source instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(native-filters): keep filter value input caret left-aligned [superset]
Posted by "codeant-ai-for-open-source[bot] (via GitHub)" <gi...@apache.org>.
codeant-ai-for-open-source[bot] commented on code in PR #42266:
URL: https://github.com/apache/superset/pull/42266#discussion_r3620567803
##########
superset-frontend/src/filters/components/common.ts:
##########
@@ -25,6 +25,22 @@ export const RESPONSIVE_WIDTH = 0;
export const FilterPluginStyle = styled.div<PluginFilterStylesProps>`
min-height: ${({ height }) => height}px;
width: ${({ width }) => (width === RESPONSIVE_WIDTH ? '100%' : `${width}px`)};
+ /* Input / InputNumber filter value controls resolve text-align by */
+ /* inheritance, so pin them to the inline start to keep the caret and typed */
+ /* text at the left edge. */
Review Comment:
**Suggestion:** The new comment says text is kept at the “left edge,” but the implemented rule uses `text-align: start`, which maps to the right edge in RTL; update the comment to describe “inline start” instead to avoid misleading future changes and tests. [comment mismatch]
<details>
<summary><b>Severity Level:</b> Minor 🧹</summary>
```mdx
- ⚠️ Comment misleading about RTL alignment of filter inputs.
- ⚠️ No runtime behavior affected; UI works as intended.
```
</details>
<details>
<summary><b>Steps of Reproduction ✅ </b></summary>
```mdx
1. Open `superset-frontend/src/filters/components/common.ts` and locate
`FilterPluginStyle` definition at lines 25-44 in the PR diff.
2. Observe the comments at lines 28-30: they mention "inline start" (correct for
`text-align: start`) but also say "text at the left edge."
3. Note the implementation at line 31: `text-align: start;` which, per CSS spec, aligns
text to the right edge in RTL contexts.
4. In an RTL dashboard (where inline start is right), native filter value inputs render
caret/text at the right edge, while the comment still describes "left edge", so the
comment is mildly misleading but behavior is correct.
```
</details>
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=d5ccc26ff7f745d6b273ec1d2df71d25&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset) [](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=d5ccc26ff7f745d6b273ec1d2df71d25&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
*(Use Cmd/Ctrl + Click for best experience)*
<details>
<summary><b>Prompt for AI Agent 🤖 </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset-frontend/src/filters/components/common.ts
**Line:** 28:30
**Comment:**
*Comment Mismatch: The new comment says text is kept at the “left edge,” but the implemented rule uses `text-align: start`, which maps to the right edge in RTL; update the comment to describe “inline start” instead to avoid misleading future changes and tests.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42266&comment_hash=ed89e4a4a2ab359343c1a20e64b985846dee3b4f92d7e7e573827ec23ce0e009&reaction=like'>👍</a> | <a href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F42266&comment_hash=ed89e4a4a2ab359343c1a20e64b985846dee3b4f92d7e7e573827ec23ce0e009&reaction=dislike'>👎</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(native-filters): keep filter value input caret left-aligned [superset]
Posted by "yousoph (via GitHub)" <gi...@apache.org>.
yousoph commented on PR #42266:
URL: https://github.com/apache/superset/pull/42266#issuecomment-5052901033
Superseded by #42323, which reworks this same fix to address review feedback: it keeps the wrapper-level `text-align: start`, drops the nested `.ant-select-content` override (Ant Design 6.5.1 doesn't set `text-align: center` on that element — verified across 6.0.0–6.5.1), documents the actual inherited source, keeps the duplicated `chartCustomizations` copy in sync, and adds a Jest regression test. Thanks @sadpandajoe for the review here. Closing in favor of #42323.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(native-filters): keep filter value input caret left-aligned [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #42266:
URL: https://github.com/apache/superset/pull/42266#issuecomment-5031779128
<!-- Bito Reply -->
The flagged issue is correct. The CSS property `text-align: start` aligns text to the right edge in Right-to-Left (RTL) contexts, making the comment "left edge" misleading. You should update the comment to refer to "inline start" to accurately reflect the behavior.
Here is the corrected code snippet:
```typescript
/* Input / InputNumber filter value controls resolve text-align by */
/* inheritance, so pin them to the inline start to keep the caret and typed */
/* text at the inline start. */
text-align: start;
```
I have checked the available PR comments, and there are no other review comments to address. Would you like me to perform any other tasks?
**superset-frontend/src/filters/components/common.ts**
```
/* Input / InputNumber filter value controls resolve text-align by */
/* inheritance, so pin them to the inline start to keep the caret and typed */
/* text at the inline start. */
text-align: start;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(native-filters): keep filter value input caret left-aligned [superset]
Posted by "netlify[bot] (via GitHub)" <gi...@apache.org>.
netlify[bot] commented on PR #42266:
URL: https://github.com/apache/superset/pull/42266#issuecomment-5031759682
### <span aria-hidden="true">✅</span> Deploy Preview for *superset-docs-preview* ready!
| Name | Link |
|:-:|------------------------|
|<span aria-hidden="true">🔨</span> Latest commit | 3bda48cd4c72cf40f10cac0ac6d15b338b64edcd |
|<span aria-hidden="true">🔍</span> Latest deploy log | https://app.netlify.com/projects/superset-docs-preview/deploys/6a5f2c9bf038ab0008dadd8b |
|<span aria-hidden="true">😎</span> Deploy Preview | [https://deploy-preview-42266--superset-docs-preview.netlify.app](https://deploy-preview-42266--superset-docs-preview.netlify.app) |
|<span aria-hidden="true">📱</span> Preview on mobile | <details><summary> Toggle QR Code... </summary><br /><br /><br /><br />_Use your smartphone camera to open QR code link._</details> |
|<span aria-hidden="true">🤖</span> Make changes | [Run an agent on this branch](https://app.netlify.com/projects/superset-docs-preview/agent-runs#DcrLDYAgDADQXXqWpPgLuIFjtFSiiQopejDG3eX2Du-FrOnIF0wADbDSGdbqEoy1PXpv4rZfixomNeHWkrQ2WfKenllqHGmIbfAcsXPEiOiERBzD9wM) |
---
<!-- [superset-docs-preview Preview](https://deploy-preview-42266--superset-docs-preview.netlify.app) -->
_To edit notification comments on pull requests, go to your [Netlify project configuration](https://app.netlify.com/projects/superset-docs-preview/configuration/notifications#deploy-notifications)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(native-filters): keep filter value input caret left-aligned [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #42266:
URL: https://github.com/apache/superset/pull/42266#issuecomment-5031743131
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(native-filters): keep filter value input caret left-aligned [superset]
Posted by "yousoph (via GitHub)" <gi...@apache.org>.
yousoph commented on code in PR #42266:
URL: https://github.com/apache/superset/pull/42266#discussion_r3634369338
##########
superset-frontend/src/filters/components/common.ts:
##########
@@ -25,6 +25,22 @@ export const RESPONSIVE_WIDTH = 0;
export const FilterPluginStyle = styled.div<PluginFilterStylesProps>`
min-height: ${({ height }) => height}px;
width: ${({ width }) => (width === RESPONSIVE_WIDTH ? '100%' : `${width}px`)};
+ /* Input / InputNumber filter value controls resolve text-align by */
+ /* inheritance, so pin them to the inline start to keep the caret and typed */
+ /* text at the left edge. */
Review Comment:
Reword to avoid the physical-"left" framing (RTL-correct) and cover all three value controls:
```suggestion
/* Filter value controls (Input / InputNumber / Select search) resolve */
/* 'text-align' by inheritance, so pin them to the inline start to keep the */
/* caret and typed text at the inline-start edge. */
```
##########
superset-frontend/src/filters/components/common.ts:
##########
@@ -25,6 +25,22 @@ export const RESPONSIVE_WIDTH = 0;
export const FilterPluginStyle = styled.div<PluginFilterStylesProps>`
min-height: ${({ height }) => height}px;
width: ${({ width }) => (width === RESPONSIVE_WIDTH ? '100%' : `${width}px`)};
+ /* Input / InputNumber filter value controls resolve text-align by */
+ /* inheritance, so pin them to the inline start to keep the caret and typed */
+ /* text at the left edge. */
+ text-align: start;
+
+ /* antd v6 sets 'text-align: center' directly on '.ant-select-content' for */
+ /* multiple-mode Selects (its selector '.ant-select-multiple */
+ /* .ant-select-content' has specificity 0,2,0). The Select search input */
+ /* lives inside '.ant-select-content' and inherits that value, so the caret */
+ /* and typed text render centered. A value inherited from this wrapper */
+ /* cannot beat a rule that targets '.ant-select-content' directly, so */
+ /* override the element itself: this wrapper class plus the two antd classes */
+ /* give specificity 0,3,0, which wins without !important. RTL-safe. */
Review Comment:
Stock antd 6.0.0–6.5.1 doesn't set `text-align: center` on `.ant-select-content` (only on `.ant-select-clear`), so this rewording drops the inaccurate "antd v6 sets…" claim while keeping the specificity reasoning, which is correct:
```suggestion
/* Some deployments (custom themes / css-in-js overrides) can leak a centered */
/* 'text-align' onto '.ant-select-content'. The Select search <input> lives */
/* inside '.ant-select-content' and resolves 'text-align' by inheritance, so */
/* that would center the caret and typed text. Overriding '.ant-select-content' */
/* directly (this wrapper class + two antd classes = specificity 0,3,0) beats */
/* both an inherited value and a '.ant-select-multiple .ant-select-content' */
/* rule without '!important'. 'start' is the CSS default, so this is a no-op */
/* unless a centered value leaked in, and it's RTL-safe. */
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(native-filters): keep filter value input caret left-aligned [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #42266:
URL: https://github.com/apache/superset/pull/42266#issuecomment-5031864463
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/42266?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 65.22%. Comparing base ([`158e321`](https://app.codecov.io/gh/apache/superset/commit/158e3219922a63f8da6d3b97a33f4039d2973d89?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`3bda48c`](https://app.codecov.io/gh/apache/superset/commit/3bda48cd4c72cf40f10cac0ac6d15b338b64edcd?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 10 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #42266 +/- ##
=======================================
Coverage 65.22% 65.22%
=======================================
Files 2768 2768
Lines 156280 156280
Branches 35774 35774
=======================================
Hits 101933 101933
Misses 52382 52382
Partials 1965 1965
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/42266/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [javascript](https://app.codecov.io/gh/apache/superset/pull/42266/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.89% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/superset/pull/42266?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(native-filters): keep filter value input caret left-aligned [superset]
Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on code in PR #42266:
URL: https://github.com/apache/superset/pull/42266#discussion_r3626493945
##########
superset-frontend/src/filters/components/common.ts:
##########
@@ -25,6 +25,22 @@ export const RESPONSIVE_WIDTH = 0;
export const FilterPluginStyle = styled.div<PluginFilterStylesProps>`
min-height: ${({ height }) => height}px;
width: ${({ width }) => (width === RESPONSIVE_WIDTH ? '100%' : `${width}px`)};
+ /* Input / InputNumber filter value controls resolve text-align by */
+ /* inheritance, so pin them to the inline start to keep the caret and typed */
+ /* text at the left edge. */
+ text-align: start;
Review Comment:
[major] Can we add a focused Jest regression test for this fix? Rendering `FilterPluginStyle` and asserting each retained `text-align: start` rule with `toHaveStyleRule` would protect the corrective CSS; the existing DOM-contract test only protects the Ant Design class hook.
##########
superset-frontend/src/filters/components/common.ts:
##########
@@ -25,6 +25,22 @@ export const RESPONSIVE_WIDTH = 0;
export const FilterPluginStyle = styled.div<PluginFilterStylesProps>`
min-height: ${({ height }) => height}px;
width: ${({ width }) => (width === RESPONSIVE_WIDTH ? '100%' : `${width}px`)};
+ /* Input / InputNumber filter value controls resolve text-align by */
+ /* inheritance, so pin them to the inline start to keep the caret and typed */
+ /* text at the left edge. */
+ text-align: start;
+
+ /* antd v6 sets 'text-align: center' directly on '.ant-select-content' for */
Review Comment:
[minor] The locked Ant Design 6.5.1 CSS does not set `text-align: center` on `.ant-select-multiple .ant-select-content`; that rule only sets wrapping, item alignment, and line height. Can we keep the wrapper-level rule, remove this nested selector, and document the actual inherited source instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix(native-filters): keep filter value input caret left-aligned [superset]
Posted by "yousoph (via GitHub)" <gi...@apache.org>.
yousoph closed pull request #42266: fix(native-filters): keep filter value input caret left-aligned
URL: https://github.com/apache/superset/pull/42266
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org