You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by Bolke de Bruin <bd...@gmail.com> on 2019/04/09 18:20:06 UTC

Re: The state of releases

Hi Max et al.,

Finally it is happening! Awesome! Let me know if I can help in anyway. 

I think it is fine push the tag to github if you haven’t done so yet. That has never been the issue. I also think your suggestion of doing a ‘Superset compile’ will work. In the end it is always about the artifacts that the ASF is distributing. 

Go go go it is long overdue ;-)

B.

Verstuurd vanaf mijn iPad

> Op 27 mrt. 2019 om 20:16 heeft Maxime Beauchemin <ma...@gmail.com> het volgende geschreven:
> 
> About licenses for this source release, we have to look and make sure the
> copy/pasted code [if any] is gathered in LICENSE.txt I believe. Now that
> we've move superset-ui out, that leaves very little behind in terms of
> copied code. `superset-ui` has things copied from `blocks.org` . Maybe the
> one file left in assets/vendor/pygment.css ? Maybe some utils functions
> somewhere has been copied from a snippet?
> 
> For the eventual convenience release, we'd have to do that for the whole
> javascript dep tree presumably if we want to ship the JS bundles. Let's
> talk another thread about that specifically.
> 
> Max
> 
>> On Wed, Mar 27, 2019 at 8:37 AM David Smith <da...@gmail.com> wrote:
>> 
>> Has anyone done a first pass on the licenses, checking to see if there are
>> any obvious problems before going to lawyers with edge cases? If not, I can
>> have a look at that.
>> 
>> Dave
>> 
>> On Tue, Mar 26, 2019 at 11:08 PM Ville Brofeldt <
>> ville.v.brofeldt@gmail.com>
>> wrote:
>> 
>>> If it helps I can walk through the the releasing steps and give feedback
>>> (PR?), although I assume the critical steps require committer credentials
>>> and have to be left out during a dry run.
>>> 
>>> Ville
>>> 
>>> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>>> On Wednesday, 27 March 2019 07:22, Maxime Beauchemin <
>>> maximebeauchemin@gmail.com> wrote:
>>> 
>>>> I'm still wondering what to do with my Apache release attempt, we're
>> now
>>> a
>>>> few RCs behind as `0.31.0.rc20` is on top of branch `release--0.31`
>>>> 
>>>> I'd love if someone can follow the steps I described in
>>>> https://github.com/apache/incubator-superset/blob/master/RELEASING.md
>> (I
>>>> need a volunteer please!) to validate them and release push the latest
>>> RC.
>>>> Some of these steps are one-offs and were already setup ahead of time
>> in
>>> my
>>>> case. This second attempt would make sure a committer that has never
>> done
>>>> an Apache release can make it through.
>>>> 
>>>> Also let's make the suffix RC an Apache release specific thing, so that
>>> RCs
>>>> become an Apache release concept that follows a sequence that matches
>>>> what's in Apache's SVN. If you need different version strings, maybe
>>> suffix
>>>> with another scheme? 0.31.0devN maybe? Though this may be a
>>> python-specific
>>>> / not semver string, I'm not sure and personally don't care about
>> version
>>>> strings as long as they make sense and are consistent.
>>>> 
>>>> I'm also assuming it's ok to Github-tag RCs that go onto Apache's SVN.
>> A
>>>> few months back I was told to not push RC tags to Github, but now that
>>>> we're actually trying to do Apache releases it should be ok.
>>>> 
>>>> Max
>>> 
>> 

Re: The state of releases

Posted by Maxime Beauchemin <ma...@gmail.com>.
Started a [VOTE] thread!

On Thu, Apr 11, 2019 at 12:20 PM Bolke de Bruin <bd...@gmail.com> wrote:

> Im eager to vote ;-)
>
> Verstuurd vanaf mijn iPad
>
> > Op 9 apr. 2019 om 20:28 heeft Maxime Beauchemin <
> maximebeauchemin@gmail.com> het volgende geschreven:
> >
> > Agreed, let me start a vote on the release I had put together.
> >
> >> On Tue, Apr 9, 2019 at 11:20 AM Bolke de Bruin <bd...@gmail.com>
> wrote:
> >>
> >> Hi Max et al.,
> >>
> >> Finally it is happening! Awesome! Let me know if I can help in anyway.
> >>
> >> I think it is fine push the tag to github if you haven’t done so yet.
> That
> >> has never been the issue. I also think your suggestion of doing a
> ‘Superset
> >> compile’ will work. In the end it is always about the artifacts that the
> >> ASF is distributing.
> >>
> >> Go go go it is long overdue ;-)
> >>
> >> B.
> >>
> >> Verstuurd vanaf mijn iPad
> >>
> >>> Op 27 mrt. 2019 om 20:16 heeft Maxime Beauchemin <
> >> maximebeauchemin@gmail.com> het volgende geschreven:
> >>>
> >>> About licenses for this source release, we have to look and make sure
> the
> >>> copy/pasted code [if any] is gathered in LICENSE.txt I believe. Now
> that
> >>> we've move superset-ui out, that leaves very little behind in terms of
> >>> copied code. `superset-ui` has things copied from `blocks.org` . Maybe
> >> the
> >>> one file left in assets/vendor/pygment.css ? Maybe some utils functions
> >>> somewhere has been copied from a snippet?
> >>>
> >>> For the eventual convenience release, we'd have to do that for the
> whole
> >>> javascript dep tree presumably if we want to ship the JS bundles. Let's
> >>> talk another thread about that specifically.
> >>>
> >>> Max
> >>>
> >>>> On Wed, Mar 27, 2019 at 8:37 AM David Smith <da...@gmail.com>
> >> wrote:
> >>>>
> >>>> Has anyone done a first pass on the licenses, checking to see if there
> >> are
> >>>> any obvious problems before going to lawyers with edge cases? If not,
> I
> >> can
> >>>> have a look at that.
> >>>>
> >>>> Dave
> >>>>
> >>>> On Tue, Mar 26, 2019 at 11:08 PM Ville Brofeldt <
> >>>> ville.v.brofeldt@gmail.com>
> >>>> wrote:
> >>>>
> >>>>> If it helps I can walk through the the releasing steps and give
> >> feedback
> >>>>> (PR?), although I assume the critical steps require committer
> >> credentials
> >>>>> and have to be left out during a dry run.
> >>>>>
> >>>>> Ville
> >>>>>
> >>>>> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> >>>>> On Wednesday, 27 March 2019 07:22, Maxime Beauchemin <
> >>>>> maximebeauchemin@gmail.com> wrote:
> >>>>>
> >>>>>> I'm still wondering what to do with my Apache release attempt, we're
> >>>> now
> >>>>> a
> >>>>>> few RCs behind as `0.31.0.rc20` is on top of branch `release--0.31`
> >>>>>>
> >>>>>> I'd love if someone can follow the steps I described in
> >>>>>>
> https://github.com/apache/incubator-superset/blob/master/RELEASING.md
> >>>> (I
> >>>>>> need a volunteer please!) to validate them and release push the
> latest
> >>>>> RC.
> >>>>>> Some of these steps are one-offs and were already setup ahead of
> time
> >>>> in
> >>>>> my
> >>>>>> case. This second attempt would make sure a committer that has never
> >>>> done
> >>>>>> an Apache release can make it through.
> >>>>>>
> >>>>>> Also let's make the suffix RC an Apache release specific thing, so
> >> that
> >>>>> RCs
> >>>>>> become an Apache release concept that follows a sequence that
> matches
> >>>>>> what's in Apache's SVN. If you need different version strings, maybe
> >>>>> suffix
> >>>>>> with another scheme? 0.31.0devN maybe? Though this may be a
> >>>>> python-specific
> >>>>>> / not semver string, I'm not sure and personally don't care about
> >>>> version
> >>>>>> strings as long as they make sense and are consistent.
> >>>>>>
> >>>>>> I'm also assuming it's ok to Github-tag RCs that go onto Apache's
> SVN.
> >>>> A
> >>>>>> few months back I was told to not push RC tags to Github, but now
> that
> >>>>>> we're actually trying to do Apache releases it should be ok.
> >>>>>>
> >>>>>> Max
> >>>>>
> >>>>
> >>
>

Re: The state of releases

Posted by Bolke de Bruin <bd...@gmail.com>.
Im eager to vote ;-)

Verstuurd vanaf mijn iPad

> Op 9 apr. 2019 om 20:28 heeft Maxime Beauchemin <ma...@gmail.com> het volgende geschreven:
> 
> Agreed, let me start a vote on the release I had put together.
> 
>> On Tue, Apr 9, 2019 at 11:20 AM Bolke de Bruin <bd...@gmail.com> wrote:
>> 
>> Hi Max et al.,
>> 
>> Finally it is happening! Awesome! Let me know if I can help in anyway.
>> 
>> I think it is fine push the tag to github if you haven’t done so yet. That
>> has never been the issue. I also think your suggestion of doing a ‘Superset
>> compile’ will work. In the end it is always about the artifacts that the
>> ASF is distributing.
>> 
>> Go go go it is long overdue ;-)
>> 
>> B.
>> 
>> Verstuurd vanaf mijn iPad
>> 
>>> Op 27 mrt. 2019 om 20:16 heeft Maxime Beauchemin <
>> maximebeauchemin@gmail.com> het volgende geschreven:
>>> 
>>> About licenses for this source release, we have to look and make sure the
>>> copy/pasted code [if any] is gathered in LICENSE.txt I believe. Now that
>>> we've move superset-ui out, that leaves very little behind in terms of
>>> copied code. `superset-ui` has things copied from `blocks.org` . Maybe
>> the
>>> one file left in assets/vendor/pygment.css ? Maybe some utils functions
>>> somewhere has been copied from a snippet?
>>> 
>>> For the eventual convenience release, we'd have to do that for the whole
>>> javascript dep tree presumably if we want to ship the JS bundles. Let's
>>> talk another thread about that specifically.
>>> 
>>> Max
>>> 
>>>> On Wed, Mar 27, 2019 at 8:37 AM David Smith <da...@gmail.com>
>> wrote:
>>>> 
>>>> Has anyone done a first pass on the licenses, checking to see if there
>> are
>>>> any obvious problems before going to lawyers with edge cases? If not, I
>> can
>>>> have a look at that.
>>>> 
>>>> Dave
>>>> 
>>>> On Tue, Mar 26, 2019 at 11:08 PM Ville Brofeldt <
>>>> ville.v.brofeldt@gmail.com>
>>>> wrote:
>>>> 
>>>>> If it helps I can walk through the the releasing steps and give
>> feedback
>>>>> (PR?), although I assume the critical steps require committer
>> credentials
>>>>> and have to be left out during a dry run.
>>>>> 
>>>>> Ville
>>>>> 
>>>>> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
>>>>> On Wednesday, 27 March 2019 07:22, Maxime Beauchemin <
>>>>> maximebeauchemin@gmail.com> wrote:
>>>>> 
>>>>>> I'm still wondering what to do with my Apache release attempt, we're
>>>> now
>>>>> a
>>>>>> few RCs behind as `0.31.0.rc20` is on top of branch `release--0.31`
>>>>>> 
>>>>>> I'd love if someone can follow the steps I described in
>>>>>> https://github.com/apache/incubator-superset/blob/master/RELEASING.md
>>>> (I
>>>>>> need a volunteer please!) to validate them and release push the latest
>>>>> RC.
>>>>>> Some of these steps are one-offs and were already setup ahead of time
>>>> in
>>>>> my
>>>>>> case. This second attempt would make sure a committer that has never
>>>> done
>>>>>> an Apache release can make it through.
>>>>>> 
>>>>>> Also let's make the suffix RC an Apache release specific thing, so
>> that
>>>>> RCs
>>>>>> become an Apache release concept that follows a sequence that matches
>>>>>> what's in Apache's SVN. If you need different version strings, maybe
>>>>> suffix
>>>>>> with another scheme? 0.31.0devN maybe? Though this may be a
>>>>> python-specific
>>>>>> / not semver string, I'm not sure and personally don't care about
>>>> version
>>>>>> strings as long as they make sense and are consistent.
>>>>>> 
>>>>>> I'm also assuming it's ok to Github-tag RCs that go onto Apache's SVN.
>>>> A
>>>>>> few months back I was told to not push RC tags to Github, but now that
>>>>>> we're actually trying to do Apache releases it should be ok.
>>>>>> 
>>>>>> Max
>>>>> 
>>>> 
>> 

Re: The state of releases

Posted by Maxime Beauchemin <ma...@gmail.com>.
Agreed, let me start a vote on the release I had put together.

On Tue, Apr 9, 2019 at 11:20 AM Bolke de Bruin <bd...@gmail.com> wrote:

> Hi Max et al.,
>
> Finally it is happening! Awesome! Let me know if I can help in anyway.
>
> I think it is fine push the tag to github if you haven’t done so yet. That
> has never been the issue. I also think your suggestion of doing a ‘Superset
> compile’ will work. In the end it is always about the artifacts that the
> ASF is distributing.
>
> Go go go it is long overdue ;-)
>
> B.
>
> Verstuurd vanaf mijn iPad
>
> > Op 27 mrt. 2019 om 20:16 heeft Maxime Beauchemin <
> maximebeauchemin@gmail.com> het volgende geschreven:
> >
> > About licenses for this source release, we have to look and make sure the
> > copy/pasted code [if any] is gathered in LICENSE.txt I believe. Now that
> > we've move superset-ui out, that leaves very little behind in terms of
> > copied code. `superset-ui` has things copied from `blocks.org` . Maybe
> the
> > one file left in assets/vendor/pygment.css ? Maybe some utils functions
> > somewhere has been copied from a snippet?
> >
> > For the eventual convenience release, we'd have to do that for the whole
> > javascript dep tree presumably if we want to ship the JS bundles. Let's
> > talk another thread about that specifically.
> >
> > Max
> >
> >> On Wed, Mar 27, 2019 at 8:37 AM David Smith <da...@gmail.com>
> wrote:
> >>
> >> Has anyone done a first pass on the licenses, checking to see if there
> are
> >> any obvious problems before going to lawyers with edge cases? If not, I
> can
> >> have a look at that.
> >>
> >> Dave
> >>
> >> On Tue, Mar 26, 2019 at 11:08 PM Ville Brofeldt <
> >> ville.v.brofeldt@gmail.com>
> >> wrote:
> >>
> >>> If it helps I can walk through the the releasing steps and give
> feedback
> >>> (PR?), although I assume the critical steps require committer
> credentials
> >>> and have to be left out during a dry run.
> >>>
> >>> Ville
> >>>
> >>> ‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
> >>> On Wednesday, 27 March 2019 07:22, Maxime Beauchemin <
> >>> maximebeauchemin@gmail.com> wrote:
> >>>
> >>>> I'm still wondering what to do with my Apache release attempt, we're
> >> now
> >>> a
> >>>> few RCs behind as `0.31.0.rc20` is on top of branch `release--0.31`
> >>>>
> >>>> I'd love if someone can follow the steps I described in
> >>>> https://github.com/apache/incubator-superset/blob/master/RELEASING.md
> >> (I
> >>>> need a volunteer please!) to validate them and release push the latest
> >>> RC.
> >>>> Some of these steps are one-offs and were already setup ahead of time
> >> in
> >>> my
> >>>> case. This second attempt would make sure a committer that has never
> >> done
> >>>> an Apache release can make it through.
> >>>>
> >>>> Also let's make the suffix RC an Apache release specific thing, so
> that
> >>> RCs
> >>>> become an Apache release concept that follows a sequence that matches
> >>>> what's in Apache's SVN. If you need different version strings, maybe
> >>> suffix
> >>>> with another scheme? 0.31.0devN maybe? Though this may be a
> >>> python-specific
> >>>> / not semver string, I'm not sure and personally don't care about
> >> version
> >>>> strings as long as they make sense and are consistent.
> >>>>
> >>>> I'm also assuming it's ok to Github-tag RCs that go onto Apache's SVN.
> >> A
> >>>> few months back I was told to not push RC tags to Github, but now that
> >>>> we're actually trying to do Apache releases it should be ok.
> >>>>
> >>>> Max
> >>>
> >>
>