You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2015/08/21 15:52:09 UTC
svn commit: r1696993 -
/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LocalVariableInstruction.java
Author: sebb
Date: Fri Aug 21 13:52:08 2015
New Revision: 1696993
URL: http://svn.apache.org/r1696993
Log:
FindBugs: Unnecessary check
Modified:
commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LocalVariableInstruction.java
Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LocalVariableInstruction.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LocalVariableInstruction.java?rev=1696993&r1=1696992&r2=1696993&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LocalVariableInstruction.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/generic/LocalVariableInstruction.java Fri Aug 21 13:52:08 2015
@@ -156,7 +156,8 @@ public abstract class LocalVariableInstr
throw new ClassGenException("Illegal value: " + n);
}
this.n = n;
- if (n >= 0 && n <= 3) { // Use more compact instruction xLOAD_n
+ // Cannot be < 0 as this is checked above
+ if (n <= 3) { // Use more compact instruction xLOAD_n
opcode = (short) (c_tag + n);
length = 1;
} else {