You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/12/03 09:59:19 UTC
[GitHub] [shardingsphere-elasticjob] codecov-io commented on pull request #1758: Add support for filter chain in Restful module
codecov-io commented on pull request #1758:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1758#issuecomment-737812825
# [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1758?src=pr&el=h1) Report
> Merging [#1758](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1758?src=pr&el=desc) (0fc6a6b) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/eb757b92f2fd57626cb5a0411e6cb4704cebb8a1?el=desc) (eb757b9) will **decrease** coverage by `0.02%`.
> The diff coverage is `91.17%`.
[](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1758?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1758 +/- ##
============================================
- Coverage 86.02% 86.00% -0.03%
Complexity 108 108
============================================
Files 255 258 +3
Lines 5740 5774 +34
Branches 885 889 +4
============================================
+ Hits 4938 4966 +28
- Misses 483 487 +4
- Partials 319 321 +2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1758?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ache/shardingsphere/elasticjob/restful/Filter.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1758/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLXJlc3RmdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvcmVzdGZ1bC9GaWx0ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...cjob/restful/NettyRestfulServiceConfiguration.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1758/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLXJlc3RmdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvcmVzdGZ1bC9OZXR0eVJlc3RmdWxTZXJ2aWNlQ29uZmlndXJhdGlvbi5qYXZh) | `57.14% <0.00%> (-22.86%)` | `0.00 <0.00> (ø)` | |
| [.../elasticjob/restful/filter/DefaultFilterChain.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1758/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLXJlc3RmdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvcmVzdGZ1bC9maWx0ZXIvRGVmYXVsdEZpbHRlckNoYWluLmphdmE=) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ob/restful/pipeline/FilterChainInboundHandler.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1758/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLXJlc3RmdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvcmVzdGZ1bC9waXBlbGluZS9GaWx0ZXJDaGFpbkluYm91bmRIYW5kbGVyLmphdmE=) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (?)` | |
| [...ful/pipeline/RestfulServiceChannelInitializer.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1758/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLXJlc3RmdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvcmVzdGZ1bC9waXBlbGluZS9SZXN0ZnVsU2VydmljZUNoYW5uZWxJbml0aWFsaXplci5qYXZh) | `100.00% <100.00%> (ø)` | `0.00 <0.00> (ø)` | |
| [...e/shardingsphere/elasticjob/infra/env/IpUtils.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1758/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLWluZnJhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9pbmZyYS9lbnYvSXBVdGlscy5qYXZh) | `60.00% <0.00%> (-4.62%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1758?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1758?src=pr&el=footer). Last update [eb757b9...235a11e](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1758?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org