[GitHub] [beam] robertwb commented on a change in pull request #13434: [BEAM-11357] Add annotations to PTransforms and enable them in Go SDK

[GitBox <gi...@apache.org>]

robertwb commented on a change in pull request #13434:
URL: https://github.com/apache/beam/pull/13434#discussion_r535645100



##########
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##########
@@ -188,6 +188,13 @@ message PTransform {
   // Transforms that are required to be implemented by a runner must omit this.
   // All other transforms are required to specify this.
   string environment_id = 7;
+
+  // (Optional) A map from URNs designating a type of annotation, to the
+  // annotation in binary format. For example, an annotation could indicate
+  // that this PTransform has specific resource preferences.

Review comment:
       As discussed on the list, we specifically don't want to use these for resource preferences. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org