You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2022/09/23 20:27:13 UTC
[GitHub] [accumulo] DomGarguilo opened a new pull request, #2957: Update jquery and flot versions
DomGarguilo opened a new pull request, #2957:
URL: https://github.com/apache/accumulo/pull/2957
This PR updates
* jquery from 3.2.1 to 3.6.1
* flot from 4.2.1 to 4.2.3
For jquery, I used the "Download the uncompressed, development jQuery 3.6.1" link from https://jquery.com/download/
For flot, I downloaded the files from https://github.com/flot/flot/releases/tag/v4.2.3
I updated the LICENSE files in our repo but noticed the following:
https://github.com/apache/accumulo/blob/d51e2f1c4455012b66d38600a3579b5d233fc4e3/LICENSE#L298-L300
but don't really know what that is referring to (maybe a previous version of [this](https://github.com/flot/flot/blob/efb67df19a4cf70316d4fca7ed2a86e73e6b4181/source/jquery.flot.pie.js)?). And also found this in flot so im not too sure if it should be remove from our licensing or not as it might be left over from an old version of flot that we were using:
> <li>The pie plug-in is now part of the Flot repository! This should make it a lot easier to deal with.</li>
https://github.com/flot/flot/blob/d0f569a47566c61ef7a43e94e5daaacd1a18bf4e/examples/series-pie/index.html#L768
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] DomGarguilo commented on pull request #2957: Update jquery and flot versions
Posted by GitBox <gi...@apache.org>.
DomGarguilo commented on PR #2957:
URL: https://github.com/apache/accumulo/pull/2957#issuecomment-1265619285
Thanks for the input @ctubbsii and @cshannon. I updated the flot license. Take a look and see what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #2957: Update jquery and flot versions
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on PR #2957:
URL: https://github.com/apache/accumulo/pull/2957#issuecomment-1264092662
@DomGarguilo Regarding the license issue, flot used to bundle some jQuery plugins, with their own license specifics. If those are no longer bundled in the version of flot we're using (and therefore, we are no longer redistributing them), we can get rid of those mentions in the license.
@cshannon We've discussed this before, but I'm too lazy to dig it up in the archives at the moment. It boils down to: obfuscated/minimized code is not free and open source. It does not meet the definition of open source software according to the the open source initiative (not ASF's official definition, but a useful one), nor does it meet the definition of free software according to the free software foundation (again, not ASF's official definition, but a useful one). We should not bundle the minimized versions in our source tarball. We could include them in our distribution tarball, but there's really no reason to do that, because we're probably not getting much benefit from it anyway. Many browsers cache and optimize and do other various magical things with javascript... and that's assuming downstream users haven't modified the monitor to use a CDN instead of the javascript we're giving them anyway. So, using the obfuscated/minimized versions are generally not worth it for us.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on pull request #2957: Update jquery and flot versions
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on PR #2957:
URL: https://github.com/apache/accumulo/pull/2957#issuecomment-1264533436
> Should we just update the LICENSE file with the updated wording from the current version?
Yes, exactly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] cshannon commented on pull request #2957: Update jquery and flot versions
Posted by GitBox <gi...@apache.org>.
cshannon commented on PR #2957:
URL: https://github.com/apache/accumulo/pull/2957#issuecomment-1264354593
I did some digging with the licensing and it looks jquery.pie.js is under https://github.com/flot/flot/blob/master/source/jquery.flot.pie.js. The licensing in the headers has been renamed/reworked slightly but it is still used.
The section that we currently show in our license file referring to June 2009 creation was dropped long ago:
https://github.com/flot/flot/commit/9e21074d82376c519ca586b1fdcfca0eafdc97ad#diff-46d28d77e2699e7634fe9138e185409139794584ffa0c7cfb842c79efcaa8741
Current version shows:
https://github.com/flot/flot/blob/de34ce947d8ebfb2cac0b682a130ba079d8d654b/source/jquery.flot.pie.js#L1-L14
@ctubbsii - Should we just update the LICENSE file with the updated wording from the current version?
As a side note, I also checked the licensing section on jquery.flot.resize.js and it is still accurate with the inline dependency. I think only the jquery.pie.js part should be removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [accumulo] DomGarguilo merged pull request #2957: Update jquery and flot versions
Posted by GitBox <gi...@apache.org>.
DomGarguilo merged PR #2957:
URL: https://github.com/apache/accumulo/pull/2957
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org