You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2013/05/14 03:25:20 UTC
Review Request: Added a default constructor for Seconds for Clock::now() to
return Seconds. (libstout)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11136/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
Description
-------
See summary.
Diffs
-----
third_party/libprocess/third_party/stout/include/stout/duration.hpp c943ab196871cf4c55f2a2dce5ef85ffe3a22577
Diff: https://reviews.apache.org/r/11136/diff/
Testing
-------
make check.
Thanks,
Jiang Yan Xu
Re: Review Request: Added a default constructor for Seconds for Clock::now()
to return Seconds. (libstout)
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11136/
-----------------------------------------------------------
(Updated May 16, 2013, 7:49 a.m.)
Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
Changes
-------
Addressed comments.
Description
-------
[Part 2 of Duration-Time Refactoring Chain]
It necessary because the index operator "(*clock::currents)[process]" in Clock::now() adds a default Duration element to the map.
Diffs (updated)
-----
third_party/libprocess/third_party/stout/include/stout/duration.hpp c943ab196871cf4c55f2a2dce5ef85ffe3a22577
Diff: https://reviews.apache.org/r/11136/diff/
Testing
-------
make check.
Thanks,
Jiang Yan Xu
Re: Review Request: Added a default constructor for Seconds for Clock::now()
to return Seconds. (libstout)
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11136/#review20610
-----------------------------------------------------------
Ship it!
third_party/libprocess/third_party/stout/include/stout/duration.hpp
<https://reviews.apache.org/r/11136/#comment42482>
Add a newline between constructors.
- Benjamin Hindman
On May 14, 2013, 8:12 a.m., Jiang Yan Xu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11136/
> -----------------------------------------------------------
>
> (Updated May 14, 2013, 8:12 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
>
>
> Description
> -------
>
> [Part 2 of Duration-Time Refactoring Chain]
> It necessary because the index operator "(*clock::currents)[process]" in Clock::now() adds a default Duration element to the map.
>
>
> Diffs
> -----
>
> third_party/libprocess/third_party/stout/include/stout/duration.hpp c943ab196871cf4c55f2a2dce5ef85ffe3a22577
>
> Diff: https://reviews.apache.org/r/11136/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Jiang Yan Xu
>
>
Re: Review Request: Added a default constructor for Seconds for Clock::now()
to return Seconds. (libstout)
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11136/
-----------------------------------------------------------
(Updated May 14, 2013, 8:12 a.m.)
Review request for mesos, Benjamin Hindman, Vinod Kone, and Ben Mahler.
Description (updated)
-------
[Part 2 of Duration-Time Refactoring Chain]
It necessary because the index operator "(*clock::currents)[process]" in Clock::now() adds a default Duration element to the map.
Diffs
-----
third_party/libprocess/third_party/stout/include/stout/duration.hpp c943ab196871cf4c55f2a2dce5ef85ffe3a22577
Diff: https://reviews.apache.org/r/11136/diff/
Testing
-------
make check.
Thanks,
Jiang Yan Xu