You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by gpoulin <gi...@git.apache.org> on 2015/10/02 20:53:15 UTC
[GitHub] spark pull request: FIX: rememberDuration reassignment error messa...
GitHub user gpoulin opened a pull request:
https://github.com/apache/spark/pull/8966
FIX: rememberDuration reassignment error message
I was reading throught the scheduler and found this small mistake.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gpoulin/spark remember_duration_typo
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/8966.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #8966
----
commit 3fef81e1fff98ae7a5b3e606631542d2ebefb5fa
Author: Guillaume Poulin <gu...@hopper.com>
Date: 2015-10-02T18:50:00Z
FIX: rememberDuration reassignment error message
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: FIX: rememberDuration reassignment error messa...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8966#issuecomment-145140190
Hm, I don't know if we have a strong style guide beyond what you've done already, though I think i'd more usually see this in the code base:
```
require(...,
s"...")
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: FIX: rememberDuration reassignment error messa...
Posted by gpoulin <gi...@git.apache.org>.
Github user gpoulin commented on the pull request:
https://github.com/apache/spark/pull/8966#issuecomment-145139938
I fixed the lines with more than 100 columns. I wasn't sure of the guideline there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: FIX: rememberDuration reassignment error messa...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8966#issuecomment-145138971
[Test build #1839 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1839/console) for PR 8966 at commit [`3fef81e`](https://github.com/apache/spark/commit/3fef81e1fff98ae7a5b3e606631542d2ebefb5fa).
* This patch **fails Scala style tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `abstract class UnaryMathExpression(val f: Double => Double, name: String)`
* `case class Ceil(child: Expression) extends UnaryMathExpression(math.ceil, "CEIL") `
* `case class Floor(child: Expression) extends UnaryMathExpression(math.floor, "FLOOR") `
* `public final class ByteArray `
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: FIX: rememberDuration reassignment error messa...
Posted by gpoulin <gi...@git.apache.org>.
Github user gpoulin commented on the pull request:
https://github.com/apache/spark/pull/8966#issuecomment-145138145
@srowen done. I took the liberty to do the same for `batchDuration`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: FIX: rememberDuration reassignment error messa...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8966#issuecomment-145138625
[Test build #1839 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1839/consoleFull) for PR 8966 at commit [`3fef81e`](https://github.com/apache/spark/commit/3fef81e1fff98ae7a5b3e606631542d2ebefb5fa).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: FIX: rememberDuration reassignment error messa...
Posted by gpoulin <gi...@git.apache.org>.
Github user gpoulin commented on the pull request:
https://github.com/apache/spark/pull/8966#issuecomment-145159436
@srowen I apply this style and also put a `require` for the `start` method to be more consistent. I don't know if you want me to squash those commits?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: FIX: rememberDuration reassignment error messa...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/8966#discussion_r41057272
--- Diff: streaming/src/main/scala/org/apache/spark/streaming/DStreamGraph.scala ---
@@ -79,7 +79,7 @@ final private[streaming] class DStreamGraph extends Serializable with Logging {
def remember(duration: Duration) {
this.synchronized {
if (rememberDuration != null) {
- throw new Exception("Remember duration already set as " + batchDuration +
+ throw new Exception("Remember duration already set as " + rememberDuration +
--- End diff --
Sounds good. While you're here though, can you make this use string interpolation, and use `require` (so as to avoid generic `Exception`)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: FIX: rememberDuration reassignment error messa...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/8966#issuecomment-145126110
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: FIX: rememberDuration reassignment error messa...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/8966#issuecomment-145160124
LGTM pending tests. No our merge script does the squashing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: FIX: rememberDuration reassignment error messa...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/8966
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: FIX: rememberDuration reassignment error messa...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8966#issuecomment-145169988
[Test build #1840 has finished](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1840/console) for PR 8966 at commit [`d09aca3`](https://github.com/apache/spark/commit/d09aca3a98d8aac7e2452e43751c4d55ba3d7f83).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds the following public classes _(experimental)_:
* `case class HyperLogLogPlusPlus(child: Expression, relativeSD: Double = 0.05)`
* `case class JsonTuple(children: Seq[Expression])`
* `abstract class UnaryMathExpression(val f: Double => Double, name: String)`
* `case class Ceil(child: Expression) extends UnaryMathExpression(math.ceil, "CEIL") `
* `case class Floor(child: Expression) extends UnaryMathExpression(math.floor, "FLOOR") `
* `public final class ByteArray `
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: FIX: rememberDuration reassignment error messa...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/8966#issuecomment-145160468
[Test build #1840 has started](https://amplab.cs.berkeley.edu/jenkins/job/NewSparkPullRequestBuilder/1840/consoleFull) for PR 8966 at commit [`d09aca3`](https://github.com/apache/spark/commit/d09aca3a98d8aac7e2452e43751c4d55ba3d7f83).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org