You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/03/07 19:46:34 UTC

[GitHub] [commons-bcel] arturobernalg commented on a change in pull request #76: Minor Improvements:

arturobernalg commented on a change in pull request #76:
URL: https://github.com/apache/commons-bcel/pull/76#discussion_r571075894



##########
File path: src/main/java/org/apache/bcel/classfile/Utility.java
##########
@@ -831,7 +831,7 @@ public static String signatureToString( final String signature, final boolean ch
         // Could be Class or Type...
         type = typeSignatureToString(signature.substring(index), chopit);
         index += unwrap(CONSUMER_CHARS); // update position
-        if ((typeParams.isEmpty()) && (index == signature.length())) {
+        if ((typeParams.length() == 0) && (index == signature.length())) {

Review comment:
       :-( sorry, don't know what happen here. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org