[jira] Commented: (THRIFT-926) Miscellaneous C++ improvements

["Roger Meier (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12919299#action_12919299 ] 

Roger Meier commented on THRIFT-926:
------------------------------------

The timings within TFileTransportTest Test are still to heavy for my build server and dev machine...they are very busy.

The 90% rule introduced with commit  [#1005155 | http://svn.apache.org/viewvc?view=revision&revision=1005155 ] does not help on that...

using 1000 us or 750 us instead of 500 us makes my machines happy, see
|| single destructor call time limit || failures ||
| 500us    |  ~ 99.8-99.9 % |
| 750us    |  ~ 3.5 - 4.5 %|
| 1000us  | ~     2 - 4 |

what about that?



> Miscellaneous C++ improvements
> ------------------------------
>
>                 Key: THRIFT-926
>                 URL: https://issues.apache.org/jira/browse/THRIFT-926
>             Project: Thrift
>          Issue Type: Improvement
>          Components: C++ - Compiler, C++ - Library
>            Reporter: David Reiss
>         Attachments: v1-0001-THRIFT-926.-cpp-Fully-qualify-std-exception.patch, v1-0018-THRIFT-926.-cpp-Fix-an-errant-argument-to-a-debug-st.patch, v1-0021-THRIFT-926.-cpp-Fix-test-client-and-server-under-tes.patch, v1-0022-THRIFT-926.-cpp-Remove-TServerSocket-as-a-friend-cla.patch, v1-0029-THRIFT-926.-cpp-Make-TZlibTransport-flush-behave-lik.patch, v1-0030-THRIFT-926.-cpp-remove-standalone-distinction-in-TZl.patch, v1-0031-THRIFT-926.-cpp-Don-t-sleep-in-TFileTransport-if-we-.patch, v1-0032-THRIFT-926.-cpp-Fix-destructor-behavior-of-TFileTran.patch, v1-0033-THRIFT-926.-cpp-TFileTransportTest-timing-slightly-m.patch, v1-0034-THRIFT-926.-cpp-Fix-bugs-in-TFileTransport-flush.patch, v1-0039-THRIFT-926.-cpp-Fix-inconsistencies-in-transport-rea.patch, v1-0041-THRIFT-926.-cpp-Revert-r750153-to-make-way-for-more-.patch, v1-0042-THRIFT-926.-cpp-Add-configurable-buffer-recycling-fo.patch, v1-0043-THRIFT-926.-cpp-TMemoryBuffer-Uphold-the-strong-exce.patch, v1-0044-THRIFT-926.-cpp-TFramedTransport-Uphold-the-strong-e.patch, v1-0045-THRIFT-926.-cpp-Thrift-throw-bad_alloc-when-malloc-f.patch, v1-0046-THRIFT-926.-cpp-Let-TMemoryBuffer-resetBuffer-set-si.patch, v1-0047-THRIFT-926.-cpp-Better-buffer-management-for-TNonblo.patch, v1-0048-THRIFT-926.-cpp-remove-auto-stringification-in-TLogg.patch, v1-0049-THRIFT-926.-cpp-Better-exception-handling-in-TSimple.patch
>
>
> This is just a grab bag of smallish C++ patches that would be a pain to put in their own issues.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.