[GitHub] [netbeans] junichi11 commented on a diff in pull request #5823: basic auto completion for maven version properties.

["junichi11 (via GitHub)" <gi...@apache.org>]

junichi11 commented on code in PR #5823:
URL: https://github.com/apache/netbeans/pull/5823#discussion_r1166160666


##########
java/maven.grammar/src/org/netbeans/modules/maven/grammar/MavenProjectGrammar.java:
##########
@@ -464,6 +468,70 @@ protected Enumeration<GrammarResult> getDynamicValueCompletion(String path, Hint
                 return Collections.enumeration(elems);
             }
         }
+        // version property completion
+        if (path.startsWith("/project/properties/") && path.indexOf("/", 20) == -1) {

Review Comment:
   Nitpick: I would store the string to variable/constant, then would use `length()` or leave a comment for `20`. I would add `// NOI18N` if possible.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists