[GitHub] [incubator-iceberg] rdsr opened a new pull request #265: Exclude transitive artifacts already part of orc-core fat jar

[GitBox <gi...@apache.org>]

rdsr opened a new pull request #265: Exclude transitive artifacts already part of orc-core fat jar
URL: https://github.com/apache/incubator-iceberg/pull/265
 
 
   We were relocating hive classes in spark-runtime artifact. This relocated classes which were not part our dependency graph. [Shadow plugin has this issue]. These Hive classes were coming from hive-storage-api artifact which is a transitive dependency of orc-core. orc-core, being a fat jar, already includes hive-storage-api and protobuf-java jars, which are already shaded.  A simple fix in this case is to exclude storage-api  from orc-core as this is already part of orc-core
   
   Fixes #260
   
   Note: protobuf is also excluded just because it is already part of orc-core. It is not related to the issue reported in #260

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org