[GitHub] [spark] HyukjinKwon commented on a change in pull request #34846: [SPARK-37593][CORE] Optimize HeapMemoryAllocator to avoid memory waste when using G1GC

[GitBox <gi...@apache.org>]

HyukjinKwon commented on a change in pull request #34846:
URL: https://github.com/apache/spark/pull/34846#discussion_r806420798



##########
File path: core/src/main/scala/org/apache/spark/memory/MemoryManager.scala
##########
@@ -267,4 +281,22 @@ private[spark] abstract class MemoryManager(
       case MemoryMode.OFF_HEAP => MemoryAllocator.UNSAFE
     }
   }
+
+  /**
+   * Return whether we are using G1GC or not
+   */
+  private[memory] final val isG1GC: Boolean = {

Review comment:
       ```suggestion
     private final val isG1GC: Boolean = {
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org