[jira] [Commented] (AIRFLOW-6250) on_failure_callback does not know the task_id when handle_failure() is called without passing context

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-6250?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16995457#comment-16995457 ] 

ASF GitHub Bot commented on AIRFLOW-6250:
-----------------------------------------

yuqian90 commented on pull request #6812: [AIRFLOW-6250] handle_failure needs better default for context and test_mode
URL: https://github.com/apache/airflow/pull/6812
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-6250
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   
   on_failure_callback almost always want to know the dag_id and taskinstance that failed. These info are in the context passed to on_failure_callback, which is passed in from handle_failure(). However, in some rare scenarios, if handle_failure is called in scheduler_job.py and backfill_job.py, the only argument passed is the error message. context is left as None. 
   
   So in these cases, on_failure_callback will not even know what's the dag_id of the dag that just failed. 
   
   This PR fixes this by setting context to get_template_context() if it's not given. 
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   Added test in test_taskinstance.py
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> on_failure_callback does not know the task_id when handle_failure() is called without passing context
> -----------------------------------------------------------------------------------------------------
>
>                 Key: AIRFLOW-6250
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-6250
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: scheduler
>    Affects Versions: 1.10.6
>            Reporter: Qian Yu
>            Assignee: Qian Yu
>            Priority: Major
>
> The following code in scheduler_job.py can be hit e.g when {{send_task_to_executor()}} in celery_executor.py is too slow and times out after 2 seconds. But this call to {{handle_failure}}() is not passing a {{context}} object.
> So the {{on_failure_callback}} and on_retry_callback of tasks don't have an idea about what task failed.
>   
>  This can be fixed by making handle_failure() derive some reasonable default value for the context argument.
>   
> {code:python}
>     simple_dag = simple_dag_bag.get_dag(dag_id)
>     dagbag = models.DagBag(simple_dag.full_filepath)
>     dag = dagbag.get_dag(dag_id)
>     ti.task = dag.get_task(task_id)
>     ti.handle_failure(msg)
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)