You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/10/19 03:21:10 UTC

[GitHub] [dubbo-go] ChangedenCZD opened a new pull request #1527: Fix: 1526

ChangedenCZD opened a new pull request #1527:
URL: https://github.com/apache/dubbo-go/pull/1527


   <!--  Thanks for sending a pull request!
   Read https://github.com/apache/dubbo-go/blob/master/CONTRIBUTING.md before commit pull request.
   -->
   
   **What this PR does**:
   Fixed #1526
   
   config.yml support custom protocol.payload ,like java Spring Boot style.
   
   ![image](https://user-images.githubusercontent.com/9605663/137838450-e768fdc6-039e-4acf-835b-c2b8376da69c.png)
   
   
   **Which issue(s) this PR fixes**:
   <!--
   *Automatically closes linked issue when PR is merged.
   Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
   _If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
   -->
   Fixes #1526 
   
   **Special notes for your reviewer**:
   
   **Does this PR introduce a user-facing change?**:
   <!--
   If no, just write "NONE" in the release-note block below.
   If yes, a release note is required:
   Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
   -->
   ```release-note
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] justxuewei commented on a change in pull request #1527: Fix: 1526

Posted by GitBox <gi...@apache.org>.
justxuewei commented on a change in pull request #1527:
URL: https://github.com/apache/dubbo-go/pull/1527#discussion_r732422356



##########
File path: config/protocol_config.go
##########
@@ -27,9 +27,10 @@ import (
 
 // ProtocolConfig is protocol configuration
 type ProtocolConfig struct {
-	Name string `required:"true" yaml:"name"  json:"name,omitempty" property:"name"`
-	Ip   string `required:"true" yaml:"ip"  json:"ip,omitempty" property:"ip"`
-	Port string `required:"true" yaml:"port"  json:"port,omitempty" property:"port"`
+	Name    string `required:"true" yaml:"name"  json:"name,omitempty" property:"name"`
+	Ip      string `required:"true" yaml:"ip"  json:"ip,omitempty" property:"ip"`

Review comment:
       IMO, `Ip` should be renamed to `IP`, cc @AlexStocks.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1527: Fix: 1526

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1527:
URL: https://github.com/apache/dubbo-go/pull/1527#issuecomment-946346736


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1527](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ecdc411) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/a4b4f50aa23b06e59c7945054b5bf9c56718a76d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a4b4f50) will **increase** coverage by `0.12%`.
   > The diff coverage is `53.19%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1527/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              1.5    #1527      +/-   ##
   ==========================================
   + Coverage   55.72%   55.84%   +0.12%     
   ==========================================
     Files         279      279              
     Lines       16024    16079      +55     
   ==========================================
   + Hits         8930     8980      +50     
   - Misses       6153     6155       +2     
   - Partials      941      944       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [common/logger/logger.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2xvZ2dlci9sb2dnZXIuZ28=) | `92.75% <ø> (ø)` | |
   | [common/logger/logging.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2xvZ2dlci9sb2dnaW5nLmdv) | `80.00% <0.00%> (-20.00%)` | :arrow_down: |
   | [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `58.69% <ø> (ø)` | |
   | [config/protocol\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Byb3RvY29sX2NvbmZpZy5nbw==) | `100.00% <ø> (ø)` | |
   | [protocol/dubbo/impl/package.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9wYWNrYWdlLmdv) | `62.06% <ø> (ø)` | |
   | [protocol/invocation/rpcinvocation.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvaW52b2NhdGlvbi9ycGNpbnZvY2F0aW9uLmdv) | `16.66% <0.00%> (-0.61%)` | :arrow_down: |
   | [registry/service\_instance.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvc2VydmljZV9pbnN0YW5jZS5nbw==) | `0.00% <ø> (ø)` | |
   | [protocol/dubbo/impl/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9jb2RlYy5nbw==) | `41.50% <20.00%> (-0.16%)` | :arrow_down: |
   | [registry/nacos/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvbmFjb3MvcmVnaXN0cnkuZ28=) | `43.84% <40.00%> (-0.51%)` | :arrow_down: |
   | [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `79.61% <50.00%> (-1.18%)` | :arrow_down: |
   | ... and [10 more](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fbe3ed4...ecdc411](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1527: Fix: 1526

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1527:
URL: https://github.com/apache/dubbo-go/pull/1527#issuecomment-946346736


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1527](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ecdc411) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/a4b4f50aa23b06e59c7945054b5bf9c56718a76d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a4b4f50) will **increase** coverage by `0.12%`.
   > The diff coverage is `53.19%`.
   
   > :exclamation: Current head ecdc411 differs from pull request most recent head 46d6ff1. Consider uploading reports for the commit 46d6ff1 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1527/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              1.5    #1527      +/-   ##
   ==========================================
   + Coverage   55.72%   55.84%   +0.12%     
   ==========================================
     Files         279      279              
     Lines       16024    16079      +55     
   ==========================================
   + Hits         8930     8980      +50     
   - Misses       6153     6155       +2     
   - Partials      941      944       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [common/logger/logger.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2xvZ2dlci9sb2dnZXIuZ28=) | `92.75% <ø> (ø)` | |
   | [common/logger/logging.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2xvZ2dlci9sb2dnaW5nLmdv) | `80.00% <0.00%> (-20.00%)` | :arrow_down: |
   | [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `58.69% <ø> (ø)` | |
   | [config/protocol\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Byb3RvY29sX2NvbmZpZy5nbw==) | `100.00% <ø> (ø)` | |
   | [protocol/dubbo/impl/package.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9wYWNrYWdlLmdv) | `62.06% <ø> (ø)` | |
   | [protocol/invocation/rpcinvocation.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvaW52b2NhdGlvbi9ycGNpbnZvY2F0aW9uLmdv) | `16.66% <0.00%> (-0.61%)` | :arrow_down: |
   | [registry/service\_instance.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvc2VydmljZV9pbnN0YW5jZS5nbw==) | `0.00% <ø> (ø)` | |
   | [protocol/dubbo/impl/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9jb2RlYy5nbw==) | `41.50% <20.00%> (-0.16%)` | :arrow_down: |
   | [registry/nacos/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvbmFjb3MvcmVnaXN0cnkuZ28=) | `43.84% <40.00%> (-0.51%)` | :arrow_down: |
   | [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `79.61% <50.00%> (-1.18%)` | :arrow_down: |
   | ... and [10 more](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fbe3ed4...46d6ff1](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter commented on pull request #1527: Fix: 1526

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1527:
URL: https://github.com/apache/dubbo-go/pull/1527#issuecomment-946346736


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1527](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e6558c6) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/a4b4f50aa23b06e59c7945054b5bf9c56718a76d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a4b4f50) will **increase** coverage by `0.00%`.
   > The diff coverage is `53.19%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1527/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@           Coverage Diff           @@
   ##              1.5    #1527   +/-   ##
   =======================================
     Coverage   55.72%   55.73%           
   =======================================
     Files         279      279           
     Lines       16024    16079   +55     
   =======================================
   + Hits         8930     8961   +31     
   - Misses       6153     6171   +18     
   - Partials      941      947    +6     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [common/logger/logger.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2xvZ2dlci9sb2dnZXIuZ28=) | `92.75% <ø> (ø)` | |
   | [common/logger/logging.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2xvZ2dlci9sb2dnaW5nLmdv) | `80.00% <0.00%> (-20.00%)` | :arrow_down: |
   | [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `58.69% <ø> (ø)` | |
   | [config/protocol\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Byb3RvY29sX2NvbmZpZy5nbw==) | `100.00% <ø> (ø)` | |
   | [protocol/dubbo/impl/package.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9wYWNrYWdlLmdv) | `62.06% <ø> (ø)` | |
   | [protocol/invocation/rpcinvocation.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvaW52b2NhdGlvbi9ycGNpbnZvY2F0aW9uLmdv) | `16.66% <0.00%> (-0.61%)` | :arrow_down: |
   | [registry/service\_instance.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvc2VydmljZV9pbnN0YW5jZS5nbw==) | `0.00% <ø> (ø)` | |
   | [protocol/dubbo/impl/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9jb2RlYy5nbw==) | `41.50% <20.00%> (-0.16%)` | :arrow_down: |
   | [registry/nacos/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvbmFjb3MvcmVnaXN0cnkuZ28=) | `43.84% <40.00%> (-0.51%)` | :arrow_down: |
   | [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `79.61% <50.00%> (-1.18%)` | :arrow_down: |
   | ... and [11 more](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fbe3ed4...e6558c6](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1527: Fix: 1526

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1527:
URL: https://github.com/apache/dubbo-go/pull/1527#issuecomment-946346736


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1527](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e6558c6) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/a4b4f50aa23b06e59c7945054b5bf9c56718a76d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a4b4f50) will **increase** coverage by `0.00%`.
   > The diff coverage is `53.19%`.
   
   > :exclamation: Current head e6558c6 differs from pull request most recent head ecdc411. Consider uploading reports for the commit ecdc411 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1527/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@           Coverage Diff           @@
   ##              1.5    #1527   +/-   ##
   =======================================
     Coverage   55.72%   55.73%           
   =======================================
     Files         279      279           
     Lines       16024    16079   +55     
   =======================================
   + Hits         8930     8961   +31     
   - Misses       6153     6171   +18     
   - Partials      941      947    +6     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [common/logger/logger.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2xvZ2dlci9sb2dnZXIuZ28=) | `92.75% <ø> (ø)` | |
   | [common/logger/logging.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2xvZ2dlci9sb2dnaW5nLmdv) | `80.00% <0.00%> (-20.00%)` | :arrow_down: |
   | [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `58.69% <ø> (ø)` | |
   | [config/protocol\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Byb3RvY29sX2NvbmZpZy5nbw==) | `100.00% <ø> (ø)` | |
   | [protocol/dubbo/impl/package.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9wYWNrYWdlLmdv) | `62.06% <ø> (ø)` | |
   | [protocol/invocation/rpcinvocation.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvaW52b2NhdGlvbi9ycGNpbnZvY2F0aW9uLmdv) | `16.66% <0.00%> (-0.61%)` | :arrow_down: |
   | [registry/service\_instance.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvc2VydmljZV9pbnN0YW5jZS5nbw==) | `0.00% <ø> (ø)` | |
   | [protocol/dubbo/impl/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9jb2RlYy5nbw==) | `41.50% <20.00%> (-0.16%)` | :arrow_down: |
   | [registry/nacos/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvbmFjb3MvcmVnaXN0cnkuZ28=) | `43.84% <40.00%> (-0.51%)` | :arrow_down: |
   | [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `79.61% <50.00%> (-1.18%)` | :arrow_down: |
   | ... and [11 more](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fbe3ed4...ecdc411](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1527: Fix: 1526

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1527:
URL: https://github.com/apache/dubbo-go/pull/1527#issuecomment-946346736


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1527](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ecdc411) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/a4b4f50aa23b06e59c7945054b5bf9c56718a76d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a4b4f50) will **increase** coverage by `0.12%`.
   > The diff coverage is `53.19%`.
   
   > :exclamation: Current head ecdc411 differs from pull request most recent head 3af3a16. Consider uploading reports for the commit 3af3a16 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1527/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              1.5    #1527      +/-   ##
   ==========================================
   + Coverage   55.72%   55.84%   +0.12%     
   ==========================================
     Files         279      279              
     Lines       16024    16079      +55     
   ==========================================
   + Hits         8930     8980      +50     
   - Misses       6153     6155       +2     
   - Partials      941      944       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [common/logger/logger.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2xvZ2dlci9sb2dnZXIuZ28=) | `92.75% <ø> (ø)` | |
   | [common/logger/logging.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2xvZ2dlci9sb2dnaW5nLmdv) | `80.00% <0.00%> (-20.00%)` | :arrow_down: |
   | [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `58.69% <ø> (ø)` | |
   | [config/protocol\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Byb3RvY29sX2NvbmZpZy5nbw==) | `100.00% <ø> (ø)` | |
   | [protocol/dubbo/impl/package.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9wYWNrYWdlLmdv) | `62.06% <ø> (ø)` | |
   | [protocol/invocation/rpcinvocation.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvaW52b2NhdGlvbi9ycGNpbnZvY2F0aW9uLmdv) | `16.66% <0.00%> (-0.61%)` | :arrow_down: |
   | [registry/service\_instance.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvc2VydmljZV9pbnN0YW5jZS5nbw==) | `0.00% <ø> (ø)` | |
   | [protocol/dubbo/impl/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9jb2RlYy5nbw==) | `41.50% <20.00%> (-0.16%)` | :arrow_down: |
   | [registry/nacos/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvbmFjb3MvcmVnaXN0cnkuZ28=) | `43.84% <40.00%> (-0.51%)` | :arrow_down: |
   | [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `79.61% <50.00%> (-1.18%)` | :arrow_down: |
   | ... and [10 more](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fbe3ed4...3af3a16](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1527: Fix: 1526

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1527:
URL: https://github.com/apache/dubbo-go/pull/1527#issuecomment-946346736


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1527](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3af3a16) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/a4b4f50aa23b06e59c7945054b5bf9c56718a76d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a4b4f50) will **increase** coverage by `0.03%`.
   > The diff coverage is `53.19%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1527/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              1.5    #1527      +/-   ##
   ==========================================
   + Coverage   55.72%   55.76%   +0.03%     
   ==========================================
     Files         279      279              
     Lines       16024    16079      +55     
   ==========================================
   + Hits         8930     8967      +37     
   - Misses       6153     6168      +15     
   - Partials      941      944       +3     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [common/logger/logger.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2xvZ2dlci9sb2dnZXIuZ28=) | `92.75% <ø> (ø)` | |
   | [common/logger/logging.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2xvZ2dlci9sb2dnaW5nLmdv) | `80.00% <0.00%> (-20.00%)` | :arrow_down: |
   | [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `58.69% <ø> (ø)` | |
   | [config/protocol\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Byb3RvY29sX2NvbmZpZy5nbw==) | `100.00% <ø> (ø)` | |
   | [protocol/dubbo/impl/package.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9wYWNrYWdlLmdv) | `62.06% <ø> (ø)` | |
   | [protocol/invocation/rpcinvocation.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvaW52b2NhdGlvbi9ycGNpbnZvY2F0aW9uLmdv) | `16.66% <0.00%> (-0.61%)` | :arrow_down: |
   | [registry/service\_instance.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvc2VydmljZV9pbnN0YW5jZS5nbw==) | `0.00% <ø> (ø)` | |
   | [protocol/dubbo/impl/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9jb2RlYy5nbw==) | `41.50% <20.00%> (-0.16%)` | :arrow_down: |
   | [registry/nacos/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvbmFjb3MvcmVnaXN0cnkuZ28=) | `43.84% <40.00%> (-0.51%)` | :arrow_down: |
   | [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `79.61% <50.00%> (-1.18%)` | :arrow_down: |
   | ... and [9 more](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fbe3ed4...3af3a16](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] justxuewei commented on a change in pull request #1527: Fix: 1526

Posted by GitBox <gi...@apache.org>.
justxuewei commented on a change in pull request #1527:
URL: https://github.com/apache/dubbo-go/pull/1527#discussion_r731491637



##########
File path: common/constant/default.go
##########
@@ -90,3 +90,8 @@ const (
 const (
 	SERVICE_DISCOVERY_DEFAULT_GROUP = "DEFAULT_GROUP"
 )
+
+const (
+	DefaultProtocolPayload    = 8388608
+	DefaultProtocolPayloadStr = "8388608"

Review comment:
       DefaultProtocolPayloadStr == fmt.Sprintf("%s", DefaultProtocolPayload), or use `strconv.Itoa`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks commented on a change in pull request #1527: Fix: 1526

Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #1527:
URL: https://github.com/apache/dubbo-go/pull/1527#discussion_r732424719



##########
File path: config/protocol_config.go
##########
@@ -27,9 +27,10 @@ import (
 
 // ProtocolConfig is protocol configuration
 type ProtocolConfig struct {
-	Name string `required:"true" yaml:"name"  json:"name,omitempty" property:"name"`
-	Ip   string `required:"true" yaml:"ip"  json:"ip,omitempty" property:"ip"`
-	Port string `required:"true" yaml:"port"  json:"port,omitempty" property:"port"`
+	Name    string `required:"true" yaml:"name"  json:"name,omitempty" property:"name"`
+	Ip      string `required:"true" yaml:"ip"  json:"ip,omitempty" property:"ip"`

Review comment:
       agree with u
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks merged pull request #1527: Fix: 1526

Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #1527:
URL: https://github.com/apache/dubbo-go/pull/1527


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] justxuewei commented on a change in pull request #1527: Fix: 1526

Posted by GitBox <gi...@apache.org>.
justxuewei commented on a change in pull request #1527:
URL: https://github.com/apache/dubbo-go/pull/1527#discussion_r731491637



##########
File path: common/constant/default.go
##########
@@ -90,3 +90,8 @@ const (
 const (
 	SERVICE_DISCOVERY_DEFAULT_GROUP = "DEFAULT_GROUP"
 )
+
+const (
+	DefaultProtocolPayload    = 8388608
+	DefaultProtocolPayloadStr = "8388608"

Review comment:
       DefaultProtocolPayloadStr == fmt.Sprintf("%s", DefaultProtocolPayload)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1527: Fix: 1526

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1527:
URL: https://github.com/apache/dubbo-go/pull/1527#issuecomment-946346736


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1527](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (46d6ff1) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/a4b4f50aa23b06e59c7945054b5bf9c56718a76d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a4b4f50) will **increase** coverage by `0.12%`.
   > The diff coverage is `55.10%`.
   
   > :exclamation: Current head 46d6ff1 differs from pull request most recent head 3af3a16. Consider uploading reports for the commit 3af3a16 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1527/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              1.5    #1527      +/-   ##
   ==========================================
   + Coverage   55.72%   55.85%   +0.12%     
   ==========================================
     Files         279      279              
     Lines       16024    16079      +55     
   ==========================================
   + Hits         8930     8981      +51     
     Misses       6153     6153              
   - Partials      941      945       +4     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [common/logger/logger.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2xvZ2dlci9sb2dnZXIuZ28=) | `92.75% <ø> (ø)` | |
   | [common/logger/logging.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2xvZ2dlci9sb2dnaW5nLmdv) | `80.00% <0.00%> (-20.00%)` | :arrow_down: |
   | [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `58.69% <ø> (ø)` | |
   | [config/protocol\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Byb3RvY29sX2NvbmZpZy5nbw==) | `100.00% <ø> (ø)` | |
   | [protocol/dubbo/impl/package.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9wYWNrYWdlLmdv) | `62.06% <ø> (ø)` | |
   | [protocol/invocation/rpcinvocation.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvaW52b2NhdGlvbi9ycGNpbnZvY2F0aW9uLmdv) | `16.66% <0.00%> (-0.61%)` | :arrow_down: |
   | [registry/service\_instance.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvc2VydmljZV9pbnN0YW5jZS5nbw==) | `0.00% <ø> (ø)` | |
   | [protocol/dubbo/impl/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9jb2RlYy5nbw==) | `41.50% <20.00%> (-0.16%)` | :arrow_down: |
   | [registry/nacos/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvbmFjb3MvcmVnaXN0cnkuZ28=) | `43.84% <40.00%> (-0.51%)` | :arrow_down: |
   | [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `79.61% <50.00%> (-1.18%)` | :arrow_down: |
   | ... and [11 more](https://codecov.io/gh/apache/dubbo-go/pull/1527/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fbe3ed4...3af3a16](https://codecov.io/gh/apache/dubbo-go/pull/1527?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org