[GitHub] [geode] upthewaterspout opened pull request #4843: GEODE-7900: Only set the SNI hostname if it is not present

["upthewaterspout (GitHub)" <gi...@apache.org>]

It turns out the JDK sometimes automatically sets the SNI hostname and
sometimes does not.  With openjdk 8, it only sets SNI hostname if there is a
dot in the hostname. See sun.security.ssl.Utilities#addToSNIServerNameList

For this reason, we need to only set the SNI hostname if the JDK did not.
Otherwise it will complain that there is a `Duplicated server name of type 0`

Note, this fixes the Windows distributed tests failures we are seeing - for example this run https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/WindowsGfshDistributedTestOpenJDK8/builds/1391. Those failures aren't really because of windows, its because our windows CI instances have fully qualified hostnames as opposed to the linux docker containers.


[ Full content available at: https://github.com/apache/geode/pull/4843 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] Bill commented on pull request #4843: GEODE-7900: Only set the SNI hostname if it is not present

["Bill (GitHub)" <gi...@apache.org>]

Having looked at the path into this method, it's clear that this framework owns this socket and the only way it can set set will cause it to have the value we expect so I'm ok w/ this code as-is. Thanks for playing!

[ Full content available at: https://github.com/apache/geode/pull/4843 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] Bill commented on pull request #4843: GEODE-7900: Only set the SNI hostname if it is not present

["Bill (GitHub)" <gi...@apache.org>]

Two things:

1. a nit: the allocation can be moved after the conditional :)
2. is the type check sufficient or is a content check necessary?

on (2) I wonder if there is a scenario where SNI might be set already, but maybe it _disagrees_ with `addr.getHostName()`

[ Full content available at: https://github.com/apache/geode/pull/4843 ]
This message was relayed via gitbox.apache.org for notifications@geode.apache.org