You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "David Rorke (Code Review)" <ge...@cloudera.org> on 2021/02/25 00:58:24 UTC

[Impala-ASF-CR] IMPALA-10547: Restore TPC-DS "reason" table missing from Kudu schema 

David Rorke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17117


Change subject: IMPALA-10547: Restore TPC-DS "reason" table missing from Kudu schema
......................................................................

IMPALA-10547: Restore TPC-DS "reason" table missing from Kudu schema

Restore the missing "reason" table that was inadvertantly removed from the
Kudu TPC-DS schema by a previous commit.

Testing:
- Manually run load-tpc-kudu.py and verify that it correctly creates the reason
  table.  Manually run TPC-DS query 9 which references the reason table.

Change-Id: Ic9c83ecbb8ca07c082f6407842ca67ef81194751
---
M testdata/datasets/tpcds/tpcds_kudu_template.sql
1 file changed, 12 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/17/17117/1
-- 
To view, visit http://gerrit.cloudera.org:8080/17117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic9c83ecbb8ca07c082f6407842ca67ef81194751
Gerrit-Change-Number: 17117
Gerrit-PatchSet: 1
Gerrit-Owner: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>

[Impala-ASF-CR] IMPALA-10547: Restore TPC-DS "reason" table missing from Kudu schema

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17117 )

Change subject: IMPALA-10547: Restore TPC-DS "reason" table missing from Kudu schema
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/8233/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9c83ecbb8ca07c082f6407842ca67ef81194751
Gerrit-Change-Number: 17117
Gerrit-PatchSet: 1
Gerrit-Owner: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Feb 2021 01:17:37 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10547: Restore TPC-DS "reason" table missing from Kudu schema

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17117 )

Change subject: IMPALA-10547: Restore TPC-DS "reason" table missing from Kudu schema
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/17117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9c83ecbb8ca07c082f6407842ca67ef81194751
Gerrit-Change-Number: 17117
Gerrit-PatchSet: 2
Gerrit-Owner: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Feb 2021 23:44:31 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10547: Restore TPC-DS "reason" table missing from Kudu schema

Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/17117 )

Change subject: IMPALA-10547: Restore TPC-DS "reason" table missing from Kudu schema
......................................................................


Patch Set 2: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/17117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9c83ecbb8ca07c082f6407842ca67ef81194751
Gerrit-Change-Number: 17117
Gerrit-PatchSet: 2
Gerrit-Owner: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Feb 2021 20:10:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10547: Restore TPC-DS "reason" table missing from Kudu schema

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17117 )

Change subject: IMPALA-10547: Restore TPC-DS "reason" table missing from Kudu schema
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6924/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/17117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9c83ecbb8ca07c082f6407842ca67ef81194751
Gerrit-Change-Number: 17117
Gerrit-PatchSet: 2
Gerrit-Owner: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Feb 2021 18:05:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10547: Restore TPC-DS "reason" table missing from Kudu schema

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17117 )

Change subject: IMPALA-10547: Restore TPC-DS "reason" table missing from Kudu schema
......................................................................

IMPALA-10547: Restore TPC-DS "reason" table missing from Kudu schema

Restore the missing "reason" table that was inadvertantly removed from the
Kudu TPC-DS schema by a previous commit.

Testing:
- Manually run load-tpc-kudu.py and verify that it correctly creates the reason
  table.  Manually run TPC-DS query 9 which references the reason table.

Change-Id: Ic9c83ecbb8ca07c082f6407842ca67ef81194751
Reviewed-on: http://gerrit.cloudera.org:8080/17117
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/datasets/tpcds/tpcds_kudu_template.sql
1 file changed, 12 insertions(+), 0 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified
  Grant Henke: Looks good to me, but someone else must approve

-- 
To view, visit http://gerrit.cloudera.org:8080/17117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9c83ecbb8ca07c082f6407842ca67ef81194751
Gerrit-Change-Number: 17117
Gerrit-PatchSet: 3
Gerrit-Owner: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>

[Impala-ASF-CR] IMPALA-10547: Restore TPC-DS "reason" table missing from Kudu schema

Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/17117 )

Change subject: IMPALA-10547: Restore TPC-DS "reason" table missing from Kudu schema
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/17117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9c83ecbb8ca07c082f6407842ca67ef81194751
Gerrit-Change-Number: 17117
Gerrit-PatchSet: 1
Gerrit-Owner: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Thu, 25 Feb 2021 21:03:56 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10547: Restore TPC-DS "reason" table missing from Kudu schema

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17117 )

Change subject: IMPALA-10547: Restore TPC-DS "reason" table missing from Kudu schema
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/17117
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9c83ecbb8ca07c082f6407842ca67ef81194751
Gerrit-Change-Number: 17117
Gerrit-PatchSet: 2
Gerrit-Owner: David Rorke <dr...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Comment-Date: Fri, 26 Feb 2021 18:05:51 +0000
Gerrit-HasComments: No