You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by icexelloss <gi...@git.apache.org> on 2018/05/01 21:30:58 UTC

[GitHub] spark pull request #21082: [SPARK-22239][SQL][Python] Enable grouped aggrega...

Github user icexelloss commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21082#discussion_r185339976
  
    --- Diff: python/pyspark/sql/functions.py ---
    @@ -2301,10 +2301,12 @@ def pandas_udf(f=None, returnType=None, functionType=None):
            The returned scalar can be either a python primitive type, e.g., `int` or `float`
            or a numpy data type, e.g., `numpy.int64` or `numpy.float64`.
     
    -       :class:`ArrayType`, :class:`MapType` and :class:`StructType` are currently not supported as
    -       output types.
    +       :class:`MapType` and :class:`StructType` are currently not supported as output types.
    --- End diff --
    
    I am leaning towards keeping this in the API doc and maybe make sql-programming-guide link to this.
    
    I think most user would look for API docs first rather than sql-programming-guide, so it's probably a bit more convenient to have it here?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org