You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "TaiJuWu (via GitHub)" <gi...@apache.org> on 2024/12/18 05:26:12 UTC
[PR] KAFKA-18277: fix e2e network_degrade_test [kafka]
TaiJuWu opened a new pull request, #18247:
URL: https://github.com/apache/kafka/pull/18247
network_degrade_test did not migrate to KRAFT, migrate it to resolve this issue.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18277: fix e2e network_degrade_test [kafka]
Posted by "TaiJuWu (via GitHub)" <gi...@apache.org>.
TaiJuWu commented on PR #18247:
URL: https://github.com/apache/kafka/pull/18247#issuecomment-2551047023
This test still fail but the reason is performance.
The log shows
```
Measured rates: [16461.0, 1564.0, 1043.0, 1043.0, 1043.0, 1564.0, 1564.0, 2085.0, 1564.0, 2085.0, 1564.0, 2085.0, 2085.0, 2085.0, 2085.0, 1043.0, 1564.0, 1564.0, 1564.0, 1564.0, 2315.0]
```
But our requirement is `100000 ~ 10000000`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18277: fix e2e network_degrade_test [kafka]
Posted by "TaiJuWu (via GitHub)" <gi...@apache.org>.
TaiJuWu commented on PR #18247:
URL: https://github.com/apache/kafka/pull/18247#issuecomment-2563814584
> @TaiJuWu have you fixed another failure?
Not yet. I am not sure this is a real issue or it needs to be improved by production code.
In this PR, can we address this migration issue and open another jira to trace the failure issue?
By the way, I will start analyzing this case recently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18277: Convert network_degrade_test to Kraft mode [kafka]
Posted by "TaiJuWu (via GitHub)" <gi...@apache.org>.
TaiJuWu commented on PR #18247:
URL: https://github.com/apache/kafka/pull/18247#issuecomment-2580852386
> @TaiJuWu Thank you for this patch. Could you please revise the title to accurately reflect the changes made in this PR? You converted the test from zk to kraft to resolve the failure, correct?
Done. Thanks for review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18277: fix e2e network_degrade_test [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18247:
URL: https://github.com/apache/kafka/pull/18247#issuecomment-2564600944
A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the `triage` label
should be removed to prevent this automation from happening again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18277: Convert network_degrade_test to Kraft mode [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #18247:
URL: https://github.com/apache/kafka/pull/18247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18277: fix e2e network_degrade_test [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18247:
URL: https://github.com/apache/kafka/pull/18247#issuecomment-2562118833
A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the `triage` label
should be removed to prevent this automation from happening again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18277: fix e2e network_degrade_test [kafka]
Posted by "TaiJuWu (via GitHub)" <gi...@apache.org>.
TaiJuWu commented on PR #18247:
URL: https://github.com/apache/kafka/pull/18247#issuecomment-2564298635
After check, this failure is related to linux version but there are some issue about vagrant and I just workaround it please refer https://github.com/apache/kafka/pull/18247/commits/ef5716b0b1adce95df6d91196fe55a0ea21bbe7f.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18277: fix e2e network_degrade_test [kafka]
Posted by "TaiJuWu (via GitHub)" <gi...@apache.org>.
TaiJuWu commented on PR #18247:
URL: https://github.com/apache/kafka/pull/18247#issuecomment-2563834441
> @TaiJuWu have you fixed another failure?
Hi @chia7712 , thanks for review.
Here is some update for this failure.
This case also fail in 3.9 on my environment and it depends on some linux tools. Maybe this is the reason make it fail?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18277: fix e2e network_degrade_test [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on PR #18247:
URL: https://github.com/apache/kafka/pull/18247#issuecomment-2563778493
@TaiJuWu have you fixed another failure?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18277: fix e2e network_degrade_test [kafka]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18247:
URL: https://github.com/apache/kafka/pull/18247#issuecomment-2566104309
A label of 'needs-attention' was automatically added to this PR in order to raise the
attention of the committers. Once this issue has been triaged, the `triage` label
should be removed to prevent this automation from happening again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-18277: fix e2e network_degrade_test [kafka]
Posted by "TaiJuWu (via GitHub)" <gi...@apache.org>.
TaiJuWu commented on PR #18247:
URL: https://github.com/apache/kafka/pull/18247#issuecomment-2550372486
This is draft since there is a failure locally and the others are pass.
```
================================================================================
SESSION REPORT (ALL TESTS)
ducktape version: 0.12.0
session_id: 2024-12-17--001
run time: 1 minute 34.279 seconds
tests run: 1
passed: 0
flaky: 0
failed: 1
ignored: 0
================================================================================
test_id: kafkatest.tests.core.network_degrade_test.NetworkDegradeTest.test_rate.task_name=rate-1000-latency-50.device_name=eth0.latency_ms=50.rate_limit_kbit=1000000.metadata_quorum=ISOLATED_KRAFT
status: FAIL
run time: 1 minute 34.084 seconds
AssertionError('Expected most of the measured rates to be within an order of magnitude of target 1000000. This means `tc` did not limit the bandwidth as expected.')
Traceback (most recent call last):
File "/usr/local/lib/python3.7/dist-packages/ducktape/tests/runner_client.py", line 351, in _do_run
data = self.run_test()
File "/usr/local/lib/python3.7/dist-packages/ducktape/tests/runner_client.py", line 411, in run_test
return self.test_context.function(self.test)
File "/usr/local/lib/python3.7/dist-packages/ducktape/mark/_mark.py", line 438, in wrapper
return functools.partial(f, *args, **kwargs)(*w_args, **w_kwargs)
File "/opt/kafka-dev/tests/kafkatest/tests/core/network_degrade_test.py", line 145, in test_rate
assert len(acceptable_rates) > 5, msg
AssertionError: Expected most of the measured rates to be within an order of magnitude of target 1000000. This means `tc` did not limit the bandwidth as expected.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org