You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "NihalJain (via GitHub)" <gi...@apache.org> on 2024/10/15 06:02:10 UTC

[PR] WIP: HBASE-28883 Consume hbase-thirdparty-bom and cleanup impacted depende… [hbase]

NihalJain opened a new pull request, #6366:
URL: https://github.com/apache/hbase/pull/6366

   …ncies


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] WIP: HBASE-28883 Consume hbase-thirdparty-bom and cleanup impacted depende… [hbase]

Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #6366:
URL: https://github.com/apache/hbase/pull/6366#discussion_r1800520673


##########
pom.xml:
##########
@@ -838,11 +838,10 @@
       modules and cause trouble if we only rely on transitive dependencies.
     -->
     <netty3.version>3.10.6.Final</netty3.version>
-    <netty4.version>4.1.112.Final</netty4.version>
     <!-- end HBASE-15925 default hadoop compatibility values -->
     <audience-annotations.version>0.15.0</audience-annotations.version>
     <javadoc.audience-annotations.version>0.15.0</javadoc.audience-annotations.version>
-    <avro.version>1.11.4</avro.version>
+    <avro.version>1.11.3</avro.version>

Review Comment:
   revert: unwanted change introduced during rebase



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] WIP: HBASE-28883 Consume hbase-thirdparty-bom and cleanup impacted depende… [hbase]

Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #6366:
URL: https://github.com/apache/hbase/pull/6366#discussion_r1800974758


##########
pom.xml:
##########
@@ -925,13 +916,11 @@
     <lz4.version>1.8.0</lz4.version>
     <snappy.version>1.1.10.4</snappy.version>
     <zstd-jni.version>1.5.5-2</zstd-jni.version>
-    <!--
-        Note that the version of protobuf shipped in hbase-thirdparty must match the version used
-        in hbase-protocol-shaded and hbase-examples. The version of jackson-[annotations,core,
-        databind] must be kept in sync with the version of jackson-jaxrs-json-provider shipped in
-        hbase-thirdparty.
+    <hbase-thirdparty.version>4.1.10-SNAPSHOT</hbase-thirdparty.version>
+    <!--Version of protobuf that hbase uses internally (we shade our pb)
+         Must match what is out in hbase-thirdparty include.

Review Comment:
   Could not remove the hardcoding of internal.protobuf.version as with BOM seems its not possible to pass on properties. And we actually use the protobuf version property in our code in `protobuf-maven-plugin` plugin



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] WIP: HBASE-28883 Consume hbase-thirdparty-bom and cleanup impacted depende… [hbase]

Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6366:
URL: https://github.com/apache/hbase/pull/6366#issuecomment-2413014636

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   0m 40s |  |  Docker mode activated.  |
   |||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain any @author tags.  |
   |||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 16s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m  8s |  |  master passed  |
   | +1 :green_heart: |  compile  |   8m 22s |  |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 45s |  |  branch has no errors when running spotless:check.  |
   |||| _ Patch Compile Tests _ |
   | -1 :x: |  mvninstall  |   0m  7s | [/branch-mvninstall-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/1/artifact/yetus-general-check/output/branch-mvninstall-root.txt) |  root in master failed.  |
   | +0 :ok: |  mvndep  |   0m 15s |  |  Maven dependency ordering for patch  |
   | -1 :x: |  mvninstall  |   0m  6s | [/patch-mvninstall-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/1/artifact/yetus-general-check/output/patch-mvninstall-root.txt) |  root in the patch failed.  |
   | -1 :x: |  compile  |   0m  6s | [/patch-compile-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/1/artifact/yetus-general-check/output/patch-compile-root.txt) |  root in the patch failed.  |
   | -0 :warning: |  javac  |   0m  6s | [/patch-compile-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/1/artifact/yetus-general-check/output/patch-compile-root.txt) |  root in the patch failed.  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks issues.  |
   | +1 :green_heart: |  xmllint  |   0m  0s |  |  No new issues.  |
   | -1 :x: |  hadoopcheck  |   0m  4s |  |  The patch causes 13 errors with Hadoop v3.3.6.  |
   | -1 :x: |  hadoopcheck  |   0m  8s |  |  The patch causes 13 errors with Hadoop v3.4.0.  |
   | -1 :x: |  spotless  |   0m  5s |  |  patch has 13 errors when running spotless:check, run spotless:apply to fix.  |
   |||| _ Other Tests _ |
   | +0 :ok: |  asflicense  |   0m 18s |  |  ASF License check generated no output?  |
   |  |   |  15m 37s |  |  |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/1/artifact/yetus-general-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/6366 |
   | Optional Tests | dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile |
   | uname | Linux 9c85271a3c38 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / f795fc0689dc110157f8ca8574b87e5a0111a195 |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   | hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/1/artifact/yetus-general-check/output/patch-javac-3.3.6.txt |
   | hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/1/artifact/yetus-general-check/output/patch-javac-3.4.0.txt |
   | spotless | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/1/artifact/yetus-general-check/output/patch-spotless.txt |
   | Max. process+thread count | 190 (vs. ulimit of 30000) |
   | modules | C: . hbase-examples hbase-protocol-shaded U: . |
   | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/1/console |
   | versions | git=2.34.1 maven=3.9.8 xmllint=20913 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] WIP: HBASE-28883 Consume hbase-thirdparty-bom and cleanup impacted depende… [hbase]

Posted by "ndimiduk (via GitHub)" <gi...@apache.org>.
ndimiduk commented on code in PR #6366:
URL: https://github.com/apache/hbase/pull/6366#discussion_r1800961984


##########
pom.xml:
##########
@@ -925,13 +916,11 @@
     <lz4.version>1.8.0</lz4.version>
     <snappy.version>1.1.10.4</snappy.version>
     <zstd-jni.version>1.5.5-2</zstd-jni.version>
-    <!--
-        Note that the version of protobuf shipped in hbase-thirdparty must match the version used
-        in hbase-protocol-shaded and hbase-examples. The version of jackson-[annotations,core,
-        databind] must be kept in sync with the version of jackson-jaxrs-json-provider shipped in
-        hbase-thirdparty.
+    <hbase-thirdparty.version>4.1.10-SNAPSHOT</hbase-thirdparty.version>
+    <!--Version of protobuf that hbase uses internally (we shade our pb)
+         Must match what is out in hbase-thirdparty include.

Review Comment:
   Why do we need to keep `internal.protobuf.version` at all?



##########
pom.xml:
##########
@@ -1838,13 +1815,6 @@
         <artifactId>netty</artifactId>
         <version>${netty3.version}</version>
       </dependency>
-      <dependency>
-        <groupId>io.netty</groupId>
-        <artifactId>netty-bom</artifactId>
-        <version>${netty4.version}</version>
-        <type>pom</type>
-        <scope>import</scope>

Review Comment:
   Does importing boms work this way? we can get transitivity over a series of imports?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] WIP: HBASE-28883 Consume hbase-thirdparty-bom and cleanup impacted depende… [hbase]

Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #6366:
URL: https://github.com/apache/hbase/pull/6366#discussion_r1896680290


##########
pom.xml:
##########
@@ -925,13 +916,11 @@
     <lz4.version>1.8.0</lz4.version>
     <snappy.version>1.1.10.4</snappy.version>
     <zstd-jni.version>1.5.5-2</zstd-jni.version>
-    <!--
-        Note that the version of protobuf shipped in hbase-thirdparty must match the version used
-        in hbase-protocol-shaded and hbase-examples. The version of jackson-[annotations,core,
-        databind] must be kept in sync with the version of jackson-jaxrs-json-provider shipped in
-        hbase-thirdparty.
+    <hbase-thirdparty.version>4.1.10-SNAPSHOT</hbase-thirdparty.version>
+    <!--Version of protobuf that hbase uses internally (we shade our pb)
+         Must match what is out in hbase-thirdparty include.

Review Comment:
   >Maven load project model (from pom.xml) for project and all submodules at startup time. During project reading all available properties are resolved from projects and settings properties.
   >
   >This plugin (as all other) is executed in the later phase - when project model is already build in memory.
   >
   >So properties read from external files by this plugin can not by used in project definitions in items like <goal>, <version> and so on.
   
   https://www.mojohaus.org/properties-maven-plugin/#plugin-limitations
   
   https://github.com/mojohaus/properties-maven-plugin/issues/26



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] WIP: HBASE-28883 Consume hbase-thirdparty-bom and cleanup impacted depende… [hbase]

Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #6366:
URL: https://github.com/apache/hbase/pull/6366#discussion_r1800520278


##########
pom.xml:
##########
@@ -925,13 +916,11 @@
     <lz4.version>1.8.0</lz4.version>
     <snappy.version>1.1.10.4</snappy.version>
     <zstd-jni.version>1.5.5-2</zstd-jni.version>
-    <!--
-        Note that the version of protobuf shipped in hbase-thirdparty must match the version used
-        in hbase-protocol-shaded and hbase-examples. The version of jackson-[annotations,core,
-        databind] must be kept in sync with the version of jackson-jaxrs-json-provider shipped in
-        hbase-thirdparty.
+    <hbase-thirdparty.version>4.1.10-SNAPSHOT</hbase-thirdparty.version>
+    <!--Version of protobuf that hbase uses internally (we shade our pb)
+         Must match what is out in hbase-thirdparty include.

Review Comment:
   replace with: 
   "Version of protobuf that hbase uses internally (we shade our pb).
   Must be kept in sync with the version of protobuf shipped in hbase-thirdparty"



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] WIP: HBASE-28883 Consume hbase-thirdparty-bom and cleanup impacted depende… [hbase]

Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #6366:
URL: https://github.com/apache/hbase/pull/6366#discussion_r1801017514


##########
pom.xml:
##########
@@ -925,13 +916,11 @@
     <lz4.version>1.8.0</lz4.version>
     <snappy.version>1.1.10.4</snappy.version>
     <zstd-jni.version>1.5.5-2</zstd-jni.version>
-    <!--
-        Note that the version of protobuf shipped in hbase-thirdparty must match the version used
-        in hbase-protocol-shaded and hbase-examples. The version of jackson-[annotations,core,
-        databind] must be kept in sync with the version of jackson-jaxrs-json-provider shipped in
-        hbase-thirdparty.
+    <hbase-thirdparty.version>4.1.10-SNAPSHOT</hbase-thirdparty.version>
+    <!--Version of protobuf that hbase uses internally (we shade our pb)
+         Must match what is out in hbase-thirdparty include.

Review Comment:
   Sure let me explore this and come back to you



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] WIP: HBASE-28883 Consume hbase-thirdparty-bom and cleanup impacted depende… [hbase]

Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #6366:
URL: https://github.com/apache/hbase/pull/6366#issuecomment-2413612404

   > Nice. How do we provie to ourselves that this change is correct? A diff of before and after dependency:list of each module?
   
   Sure, let me share and post the dependency tree with and without this change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] WIP: HBASE-28883 Consume hbase-thirdparty-bom and cleanup impacted depende… [hbase]

Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #6366:
URL: https://github.com/apache/hbase/pull/6366#discussion_r1800992325


##########
pom.xml:
##########
@@ -1838,13 +1815,6 @@
         <artifactId>netty</artifactId>
         <version>${netty3.version}</version>
       </dependency>
-      <dependency>
-        <groupId>io.netty</groupId>
-        <artifactId>netty-bom</artifactId>
-        <version>${netty4.version}</version>
-        <type>pom</type>
-        <scope>import</scope>

Review Comment:
   Yes it seems to work!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] WIP: HBASE-28883 Consume hbase-thirdparty-bom and cleanup impacted depende… [hbase]

Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #6366:
URL: https://github.com/apache/hbase/pull/6366#discussion_r1832539298


##########
pom.xml:
##########
@@ -925,13 +916,11 @@
     <lz4.version>1.8.0</lz4.version>
     <snappy.version>1.1.10.4</snappy.version>
     <zstd-jni.version>1.5.5-2</zstd-jni.version>
-    <!--
-        Note that the version of protobuf shipped in hbase-thirdparty must match the version used
-        in hbase-protocol-shaded and hbase-examples. The version of jackson-[annotations,core,
-        databind] must be kept in sync with the version of jackson-jaxrs-json-provider shipped in
-        hbase-thirdparty.
+    <hbase-thirdparty.version>4.1.10-SNAPSHOT</hbase-thirdparty.version>
+    <!--Version of protobuf that hbase uses internally (we shade our pb)
+         Must match what is out in hbase-thirdparty include.

Review Comment:
   Sorry Nick for the delay here, got caught up with other tasks. Will come back and post an update soon!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] WIP: HBASE-28883 Consume hbase-thirdparty-bom and cleanup impacted depende… [hbase]

Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #6366:
URL: https://github.com/apache/hbase/pull/6366#discussion_r1800520673


##########
pom.xml:
##########
@@ -838,11 +838,10 @@
       modules and cause trouble if we only rely on transitive dependencies.
     -->
     <netty3.version>3.10.6.Final</netty3.version>
-    <netty4.version>4.1.112.Final</netty4.version>
     <!-- end HBASE-15925 default hadoop compatibility values -->
     <audience-annotations.version>0.15.0</audience-annotations.version>
     <javadoc.audience-annotations.version>0.15.0</javadoc.audience-annotations.version>
-    <avro.version>1.11.4</avro.version>
+    <avro.version>1.11.3</avro.version>

Review Comment:
   revert: unwanted change in rebase



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] WIP: HBASE-28883 Consume hbase-thirdparty-bom and cleanup impacted depende… [hbase]

Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #6366:
URL: https://github.com/apache/hbase/pull/6366#discussion_r1896653038


##########
pom.xml:
##########
@@ -925,13 +916,11 @@
     <lz4.version>1.8.0</lz4.version>
     <snappy.version>1.1.10.4</snappy.version>
     <zstd-jni.version>1.5.5-2</zstd-jni.version>
-    <!--
-        Note that the version of protobuf shipped in hbase-thirdparty must match the version used
-        in hbase-protocol-shaded and hbase-examples. The version of jackson-[annotations,core,
-        databind] must be kept in sync with the version of jackson-jaxrs-json-provider shipped in
-        hbase-thirdparty.
+    <hbase-thirdparty.version>4.1.10-SNAPSHOT</hbase-thirdparty.version>
+    <!--Version of protobuf that hbase uses internally (we shade our pb)
+         Must match what is out in hbase-thirdparty include.

Review Comment:
   > That's super annoying.
   > 
   > Okay but maybe there's a hack. Can we use the bundle and process goals from https://maven.apache.org/plugins/maven-remote-resources-plugin/index.html to package up this property and then import it from the hbase-protocol-shaded build via https://www.mojohaus.org/properties-maven-plugin/read-project-properties-mojo.html ?
   
   
   I tried this approach. Unfortunately this also did not work as "Properties used in plugin configurations must be available during the POM parsing phase." 
   
   We can read/inject a property only after parsing is done; So the `compile-protoc` would still build with whatever is set as initial value for `internal.protobuf.version` in pom.xml 
   
   
   Approach:
   Create a new module with hbase-thirdparty-properties-bundle/pom.xml
   
   ```
   <?xml version="1.0" encoding="UTF-8"?>
   <project xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://maven.apache.org/POM/4.0.0"
            xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
       <modelVersion>4.0.0</modelVersion>
       <parent>
           <groupId>org.apache.hbase.thirdparty</groupId>
           <artifactId>hbase-thirdparty</artifactId>
           <version>${revision}</version>
           <relativePath>..</relativePath>
       </parent>
       <artifactId>hbase-thirdparty-properties-bundle</artifactId>
       <name>Apache HBase Thirdparty - Properties Bundle</name>
       <description>
           Properties Bundle, for shared properties between HBase Thirdparty and HBase main code
       </description>
       <build>
           <resources>
               <resource>
                   <directory>src/main/resources</directory>
                   <filtering>true</filtering>
               </resource>
           </resources>
           <plugins>
               <plugin>
                   <groupId>org.apache.maven.plugins</groupId>
                   <artifactId>maven-resources-plugin</artifactId>
                   <executions>
                       <execution>
                           <id>filter-resources</id>
                           <phase>process-resources</phase>
                           <goals>
                               <goal>resources</goal>
                           </goals>
                       </execution>
                   </executions>
               </plugin>
           </plugins>
       </build>
   </project>
   
   ```
   
   ---
   
   Create a properties to be shared: hbase-thirdparty-properties-bundle/src/main/resources/dependencies.properties
   ```
   internal.protobuf.version=${protobuf.version}
   ```
   
   ---
   Consume the resource in hbase/pom.xml
   ```
     <!-- Plugins to unpack properties file from hbase-thirdparty -->
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-dependency-plugin</artifactId>
           <executions>
             <execution>
               <id>unpack</id>
               <phase>initialize</phase>
               <goals>
                 <goal>unpack</goal>
               </goals>
               <configuration>
                 <artifactItems>
                   <artifactItem>
                     <groupId>org.apache.hbase.thirdparty</groupId>
                     <artifactId>hbase-thirdparty-properties-bundle</artifactId>
                     <version>${hbase-thirdparty.version}</version>
                     <overWrite>true</overWrite>
                     <!-- Specify the output directory -->
                     <outputDirectory>${project.build.directory}/extracted-resources</outputDirectory>
                   </artifactItem>
                 </artifactItems>
               </configuration>
             </execution>
           </executions>
         </plugin>
         <!-- Properties Maven Plugin to read properties file unpacked via maven-dependency-plugin -->
         <plugin>
           <groupId>org.codehaus.mojo</groupId>
           <artifactId>properties-maven-plugin</artifactId>
           <version>1.2.1</version>
           <executions>
             <execution>
               <id>read-properties</id>
               <phase>initialize</phase>
               <goals>
                 <goal>read-project-properties</goal>
               </goals>
               <configuration>
                 <files>
                   <file>${project.build.directory}/extracted-resources/dependencies.properties</file>
                 </files>
               </configuration>
             </execution>
           </executions>
         </plugin>
   ```
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] WIP: HBASE-28883 Consume hbase-thirdparty-bom and cleanup impacted depende… [hbase]

Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #6366:
URL: https://github.com/apache/hbase/pull/6366#issuecomment-2413682833

   > > Nice. How do we provie to ourselves that this change is correct? A diff of before and after dependency:list of each module?
   > 
   > Sure, let me share the dependency tree with and without this change.
   
   mvn dependency:list
   - On Master: [list_master.txt](https://github.com/user-attachments/files/17377337/list_master.txt)
   - With BOM: [list_bom.txt](https://github.com/user-attachments/files/17377332/list_bom.txt)
   
   
   mvn dependency:tree
   - On Master: [tree_master.txt](https://github.com/user-attachments/files/17377360/tree_master.txt)
   - With BOM: [tree_bom.txt](https://github.com/user-attachments/files/17377340/tree_bom.txt)
   
   Skimmed the files, looks fine except the fact that maybe we should not manage `com.google.protobuf:protobuf-java` in PR: https://github.com/apache/hbase-thirdparty/pull/124 as it overrides the one coming from hadoop.
   
   Expected: [INFO]    com.google.protobuf:protobuf-java:jar:2.5.0:compile -- module protobuf.java (auto)
   Actual: [INFO]    com.google.protobuf:protobuf-java:jar:4.28.2:compile -- module com.google.protobuf [auto]
   
   
   > Does importing boms work this way? we can get transitivity over a series of imports?
   
   We have netty version changes as both are not in sync in master and hbase-thirdparty and this also clears the transitivity question asked earlier.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] WIP: HBASE-28883 Consume hbase-thirdparty-bom and cleanup impacted depende… [hbase]

Posted by "ndimiduk (via GitHub)" <gi...@apache.org>.
ndimiduk commented on code in PR #6366:
URL: https://github.com/apache/hbase/pull/6366#discussion_r1801009890


##########
pom.xml:
##########
@@ -925,13 +916,11 @@
     <lz4.version>1.8.0</lz4.version>
     <snappy.version>1.1.10.4</snappy.version>
     <zstd-jni.version>1.5.5-2</zstd-jni.version>
-    <!--
-        Note that the version of protobuf shipped in hbase-thirdparty must match the version used
-        in hbase-protocol-shaded and hbase-examples. The version of jackson-[annotations,core,
-        databind] must be kept in sync with the version of jackson-jaxrs-json-provider shipped in
-        hbase-thirdparty.
+    <hbase-thirdparty.version>4.1.10-SNAPSHOT</hbase-thirdparty.version>
+    <!--Version of protobuf that hbase uses internally (we shade our pb)
+         Must match what is out in hbase-thirdparty include.

Review Comment:
   That's super annoying.
   
   Okay but maybe there's a hack. Can we use the bundle and process goals from https://maven.apache.org/plugins/maven-remote-resources-plugin/index.html to package up this property and then import it from the hbase-protocol-shaded build via https://www.mojohaus.org/properties-maven-plugin/read-project-properties-mojo.html ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] WIP: HBASE-28883 Consume hbase-thirdparty-bom and cleanup impacted depende… [hbase]

Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #6366:
URL: https://github.com/apache/hbase/pull/6366#discussion_r1896680290


##########
pom.xml:
##########
@@ -925,13 +916,11 @@
     <lz4.version>1.8.0</lz4.version>
     <snappy.version>1.1.10.4</snappy.version>
     <zstd-jni.version>1.5.5-2</zstd-jni.version>
-    <!--
-        Note that the version of protobuf shipped in hbase-thirdparty must match the version used
-        in hbase-protocol-shaded and hbase-examples. The version of jackson-[annotations,core,
-        databind] must be kept in sync with the version of jackson-jaxrs-json-provider shipped in
-        hbase-thirdparty.
+    <hbase-thirdparty.version>4.1.10-SNAPSHOT</hbase-thirdparty.version>
+    <!--Version of protobuf that hbase uses internally (we shade our pb)
+         Must match what is out in hbase-thirdparty include.

Review Comment:
   >Maven load project model (from pom.xml) for project and all submodules at startup time. During project reading all available properties are resolved from projects and settings properties.
   >
   >This plugin (as all other) is executed in the later phase - when project model is already build in memory.
   >
   >So properties read from external files by this plugin can not by used in project definitions in items like <goal>, <version> and so on.
   
   https://www.mojohaus.org/properties-maven-plugin/#plugin-limitations



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] WIP: HBASE-28883 Consume hbase-thirdparty-bom and cleanup impacted depende… [hbase]

Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #6366:
URL: https://github.com/apache/hbase/pull/6366#discussion_r1896653038


##########
pom.xml:
##########
@@ -925,13 +916,11 @@
     <lz4.version>1.8.0</lz4.version>
     <snappy.version>1.1.10.4</snappy.version>
     <zstd-jni.version>1.5.5-2</zstd-jni.version>
-    <!--
-        Note that the version of protobuf shipped in hbase-thirdparty must match the version used
-        in hbase-protocol-shaded and hbase-examples. The version of jackson-[annotations,core,
-        databind] must be kept in sync with the version of jackson-jaxrs-json-provider shipped in
-        hbase-thirdparty.
+    <hbase-thirdparty.version>4.1.10-SNAPSHOT</hbase-thirdparty.version>
+    <!--Version of protobuf that hbase uses internally (we shade our pb)
+         Must match what is out in hbase-thirdparty include.

Review Comment:
   > That's super annoying.
   > 
   > Okay but maybe there's a hack. Can we use the bundle and process goals from https://maven.apache.org/plugins/maven-remote-resources-plugin/index.html to package up this property and then import it from the hbase-protocol-shaded build via https://www.mojohaus.org/properties-maven-plugin/read-project-properties-mojo.html ?
   
   
   I tried this approach. Unfortunately this also did not work as "Properties used in plugin configurations must be available during the POM parsing phase." 
   
   We can read/inject a property only after parsing is done; So the `compile-protoc` would still build with whatever is set as initial value for `internal.protobuf.version` in pom.xml 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] WIP: HBASE-28883 Consume hbase-thirdparty-bom and cleanup impacted depende… [hbase]

Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #6366:
URL: https://github.com/apache/hbase/pull/6366#discussion_r1896653038


##########
pom.xml:
##########
@@ -925,13 +916,11 @@
     <lz4.version>1.8.0</lz4.version>
     <snappy.version>1.1.10.4</snappy.version>
     <zstd-jni.version>1.5.5-2</zstd-jni.version>
-    <!--
-        Note that the version of protobuf shipped in hbase-thirdparty must match the version used
-        in hbase-protocol-shaded and hbase-examples. The version of jackson-[annotations,core,
-        databind] must be kept in sync with the version of jackson-jaxrs-json-provider shipped in
-        hbase-thirdparty.
+    <hbase-thirdparty.version>4.1.10-SNAPSHOT</hbase-thirdparty.version>
+    <!--Version of protobuf that hbase uses internally (we shade our pb)
+         Must match what is out in hbase-thirdparty include.

Review Comment:
   > internal.protobuf.version
   
   I tried this approach. Unfortunately this also did not work as "Properties used in plugin configurations must be available during the POM parsing phase." 
   
   We can read/inject a property only after parsing is done; So the `compile-protoc` would still build with whatever is set as initial value for `internal.protobuf.version` in pom.xml 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] WIP: HBASE-28883 Consume hbase-thirdparty-bom and cleanup impacted depende… [hbase]

Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #6366:
URL: https://github.com/apache/hbase/pull/6366#discussion_r1801009567


##########
pom.xml:
##########
@@ -1838,13 +1815,6 @@
         <artifactId>netty</artifactId>
         <version>${netty3.version}</version>
       </dependency>
-      <dependency>
-        <groupId>io.netty</groupId>
-        <artifactId>netty-bom</artifactId>
-        <version>${netty4.version}</version>
-        <type>pom</type>
-        <scope>import</scope>

Review Comment:
   Proof added at https://github.com/apache/hbase/pull/6366#issuecomment-2413682833



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] WIP: HBASE-28883 Consume hbase-thirdparty-bom and cleanup impacted depende… [hbase]

Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6366:
URL: https://github.com/apache/hbase/pull/6366#issuecomment-2413730941

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   0m 40s |  |  Docker mode activated.  |
   |||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  |  No case conflicting files found.  |
   | +0 :ok: |  codespell  |   0m  0s |  |  codespell was not available.  |
   | +0 :ok: |  detsecrets  |   0m  0s |  |  detect-secrets was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  |  The patch does not contain any @author tags.  |
   |||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 16s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m  5s |  |  master passed  |
   | +1 :green_heart: |  compile  |   8m 23s |  |  master passed  |
   | +1 :green_heart: |  spotless  |   0m 45s |  |  branch has no errors when running spotless:check.  |
   |||| _ Patch Compile Tests _ |
   | -1 :x: |  mvninstall  |   0m  6s | [/branch-mvninstall-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/2/artifact/yetus-general-check/output/branch-mvninstall-root.txt) |  root in master failed.  |
   | +0 :ok: |  mvndep  |   0m 16s |  |  Maven dependency ordering for patch  |
   | -1 :x: |  mvninstall  |   0m  6s | [/patch-mvninstall-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/2/artifact/yetus-general-check/output/patch-mvninstall-root.txt) |  root in the patch failed.  |
   | -1 :x: |  compile  |   0m  6s | [/patch-compile-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/2/artifact/yetus-general-check/output/patch-compile-root.txt) |  root in the patch failed.  |
   | -0 :warning: |  javac  |   0m  6s | [/patch-compile-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/2/artifact/yetus-general-check/output/patch-compile-root.txt) |  root in the patch failed.  |
   | +1 :green_heart: |  blanks  |   0m  0s |  |  The patch has no blanks issues.  |
   | +1 :green_heart: |  xmllint  |   0m  0s |  |  No new issues.  |
   | -1 :x: |  hadoopcheck  |   0m  4s |  |  The patch causes 13 errors with Hadoop v3.3.6.  |
   | -1 :x: |  hadoopcheck  |   0m  8s |  |  The patch causes 13 errors with Hadoop v3.4.0.  |
   | -1 :x: |  spotless  |   0m  4s |  |  patch has 13 errors when running spotless:check, run spotless:apply to fix.  |
   |||| _ Other Tests _ |
   | +0 :ok: |  asflicense  |   0m 18s |  |  ASF License check generated no output?  |
   |  |   |  15m 34s |  |  |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.47 ServerAPI=1.47 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/2/artifact/yetus-general-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/6366 |
   | Optional Tests | dupname asflicense javac codespell detsecrets xmllint hadoopcheck spotless compile |
   | uname | Linux 49c62118c4ec 5.4.0-192-generic #212-Ubuntu SMP Fri Jul 5 09:47:39 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / e0d907780edf95aed7cc851deb758d79b11bcff5 |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   | hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/2/artifact/yetus-general-check/output/patch-javac-3.3.6.txt |
   | hadoopcheck | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/2/artifact/yetus-general-check/output/patch-javac-3.4.0.txt |
   | spotless | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/2/artifact/yetus-general-check/output/patch-spotless.txt |
   | Max. process+thread count | 192 (vs. ulimit of 30000) |
   | modules | C: . hbase-examples hbase-protocol-shaded U: . |
   | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/2/console |
   | versions | git=2.34.1 maven=3.9.8 xmllint=20913 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] WIP: HBASE-28883 Consume hbase-thirdparty-bom and cleanup impacted depende… [hbase]

Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6366:
URL: https://github.com/apache/hbase/pull/6366#issuecomment-2413733284

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   0m 28s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  |  Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
   |||| _ Prechecks _ |
   |||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 16s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 20s |  |  master passed  |
   | +1 :green_heart: |  compile  |   2m 16s |  |  master passed  |
   | +1 :green_heart: |  javadoc  |   2m 23s |  |  master passed  |
   | +1 :green_heart: |  shadedjars  |   5m 52s |  |  branch has no errors when building our shaded downstream artifacts.  |
   |||| _ Patch Compile Tests _ |
   | -1 :x: |  mvninstall  |   0m  6s | [/branch-mvninstall-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/2/artifact/yetus-jdk17-hadoop3-check/output/branch-mvninstall-root.txt) |  root in master failed.  |
   | +0 :ok: |  mvndep  |   0m 14s |  |  Maven dependency ordering for patch  |
   | -1 :x: |  mvninstall  |   0m  6s | [/patch-mvninstall-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/2/artifact/yetus-jdk17-hadoop3-check/output/patch-mvninstall-root.txt) |  root in the patch failed.  |
   | -1 :x: |  compile  |   0m  6s | [/patch-compile-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/2/artifact/yetus-jdk17-hadoop3-check/output/patch-compile-root.txt) |  root in the patch failed.  |
   | -0 :warning: |  javac  |   0m  6s | [/patch-compile-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/2/artifact/yetus-jdk17-hadoop3-check/output/patch-compile-root.txt) |  root in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m  6s | [/patch-javadoc-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/2/artifact/yetus-jdk17-hadoop3-check/output/patch-javadoc-root.txt) |  root in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m  5s | [/patch-javadoc-hbase-examples.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/2/artifact/yetus-jdk17-hadoop3-check/output/patch-javadoc-hbase-examples.txt) |  hbase-examples in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m  5s | [/patch-javadoc-hbase-protocol-shaded.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/2/artifact/yetus-jdk17-hadoop3-check/output/patch-javadoc-hbase-protocol-shaded.txt) |  hbase-protocol-shaded in the patch failed.  |
   | -1 :x: |  shadedjars  |   0m  4s |  |  patch has 13 errors when building our shaded downstream artifacts.  |
   |||| _ Other Tests _ |
   | -1 :x: |  unit  |   0m  6s | [/patch-unit-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/2/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-root.txt) |  root in the patch failed.  |
   |  |   |  16m 40s |  |  |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/2/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/6366 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 3f74d56edd8e 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / e0d907780edf95aed7cc851deb758d79b11bcff5 |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   | shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/2/artifact/yetus-jdk17-hadoop3-check/output/patch-shadedjars.txt |
   |  Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/2/testReport/ |
   | Max. process+thread count | 173 (vs. ulimit of 30000) |
   | modules | C: . hbase-examples hbase-protocol-shaded U: . |
   | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/2/console |
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] WIP: HBASE-28883 Consume hbase-thirdparty-bom and cleanup impacted depende… [hbase]

Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on PR #6366:
URL: https://github.com/apache/hbase/pull/6366#issuecomment-2412985641

   This is a demo PR and is bound to fail to compile as it needs snapshot version of hbase-thirdparty. To test this we need to first build hbase -thirdparty https://github.com/apache/hbase-thirdparty/pull/124 locally and this one next.
   
   CC: @ndimiduk 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] WIP: HBASE-28883 Consume hbase-thirdparty-bom and cleanup impacted depende… [hbase]

Posted by "Apache-HBase (via GitHub)" <gi...@apache.org>.
Apache-HBase commented on PR #6366:
URL: https://github.com/apache/hbase/pull/6366#issuecomment-2413016116

   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime |  Logfile | Comment |
   |:----:|----------:|--------:|:--------:|:-------:|
   | +0 :ok: |  reexec  |   0m 28s |  |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  |  Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --author-ignore-list --blanks-eol-ignore-file --blanks-tabs-ignore-file --quick-hadoopcheck  |
   |||| _ Prechecks _ |
   |||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 17s |  |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   3m 19s |  |  master passed  |
   | +1 :green_heart: |  compile  |   2m 16s |  |  master passed  |
   | +1 :green_heart: |  javadoc  |   2m 24s |  |  master passed  |
   | +1 :green_heart: |  shadedjars  |   5m 52s |  |  branch has no errors when building our shaded downstream artifacts.  |
   |||| _ Patch Compile Tests _ |
   | -1 :x: |  mvninstall  |   0m  6s | [/branch-mvninstall-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/1/artifact/yetus-jdk17-hadoop3-check/output/branch-mvninstall-root.txt) |  root in master failed.  |
   | +0 :ok: |  mvndep  |   0m 13s |  |  Maven dependency ordering for patch  |
   | -1 :x: |  mvninstall  |   0m  6s | [/patch-mvninstall-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/1/artifact/yetus-jdk17-hadoop3-check/output/patch-mvninstall-root.txt) |  root in the patch failed.  |
   | -1 :x: |  compile  |   0m  6s | [/patch-compile-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/1/artifact/yetus-jdk17-hadoop3-check/output/patch-compile-root.txt) |  root in the patch failed.  |
   | -0 :warning: |  javac  |   0m  6s | [/patch-compile-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/1/artifact/yetus-jdk17-hadoop3-check/output/patch-compile-root.txt) |  root in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m  5s | [/patch-javadoc-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/1/artifact/yetus-jdk17-hadoop3-check/output/patch-javadoc-root.txt) |  root in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m  6s | [/patch-javadoc-hbase-examples.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/1/artifact/yetus-jdk17-hadoop3-check/output/patch-javadoc-hbase-examples.txt) |  hbase-examples in the patch failed.  |
   | -0 :warning: |  javadoc  |   0m  5s | [/patch-javadoc-hbase-protocol-shaded.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/1/artifact/yetus-jdk17-hadoop3-check/output/patch-javadoc-hbase-protocol-shaded.txt) |  hbase-protocol-shaded in the patch failed.  |
   | -1 :x: |  shadedjars  |   0m  4s |  |  patch has 13 errors when building our shaded downstream artifacts.  |
   |||| _ Other Tests _ |
   | -1 :x: |  unit  |   0m  5s | [/patch-unit-root.txt](https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/1/artifact/yetus-jdk17-hadoop3-check/output/patch-unit-root.txt) |  root in the patch failed.  |
   |  |   |  16m 34s |  |  |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | ClientAPI=1.43 ServerAPI=1.43 base: https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/1/artifact/yetus-jdk17-hadoop3-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/6366 |
   | Optional Tests | javac javadoc unit shadedjars compile |
   | uname | Linux 13b02440f383 5.4.0-1103-aws #111~18.04.1-Ubuntu SMP Tue May 23 20:04:10 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / f795fc0689dc110157f8ca8574b87e5a0111a195 |
   | Default Java | Eclipse Adoptium-17.0.11+9 |
   | shadedjars | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/1/artifact/yetus-jdk17-hadoop3-check/output/patch-shadedjars.txt |
   |  Test Results | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/1/testReport/ |
   | Max. process+thread count | 173 (vs. ulimit of 30000) |
   | modules | C: . hbase-examples hbase-protocol-shaded U: . |
   | Console output | https://ci-hbase.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-6366/1/console |
   | versions | git=2.34.1 maven=3.9.8 |
   | Powered by | Apache Yetus 0.15.0 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] WIP: HBASE-28883 Consume hbase-thirdparty-bom and cleanup impacted depende… [hbase]

Posted by "NihalJain (via GitHub)" <gi...@apache.org>.
NihalJain commented on code in PR #6366:
URL: https://github.com/apache/hbase/pull/6366#discussion_r1896653038


##########
pom.xml:
##########
@@ -925,13 +916,11 @@
     <lz4.version>1.8.0</lz4.version>
     <snappy.version>1.1.10.4</snappy.version>
     <zstd-jni.version>1.5.5-2</zstd-jni.version>
-    <!--
-        Note that the version of protobuf shipped in hbase-thirdparty must match the version used
-        in hbase-protocol-shaded and hbase-examples. The version of jackson-[annotations,core,
-        databind] must be kept in sync with the version of jackson-jaxrs-json-provider shipped in
-        hbase-thirdparty.
+    <hbase-thirdparty.version>4.1.10-SNAPSHOT</hbase-thirdparty.version>
+    <!--Version of protobuf that hbase uses internally (we shade our pb)
+         Must match what is out in hbase-thirdparty include.

Review Comment:
   > That's super annoying.
   > 
   > Okay but maybe there's a hack. Can we use the bundle and process goals from https://maven.apache.org/plugins/maven-remote-resources-plugin/index.html to package up this property and then import it from the hbase-protocol-shaded build via https://www.mojohaus.org/properties-maven-plugin/read-project-properties-mojo.html ?
   
   
   I tried this approach. Unfortunately this also did not work as "Properties used in plugin configurations must be available during the POM parsing phase." 
   
   We can read/inject a property only after parsing is done; So the `compile-protoc` would still build with whatever is set as initial value for `internal.protobuf.version` in pom.xml 
   
   
   Approach:
   Create a new module with hbase-thirdparty-properties-bundle/pom.xml
   
   ```
   <?xml version="1.0" encoding="UTF-8"?>
   <project xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns="http://maven.apache.org/POM/4.0.0"
            xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
       <modelVersion>4.0.0</modelVersion>
       <parent>
           <groupId>org.apache.hbase.thirdparty</groupId>
           <artifactId>hbase-thirdparty</artifactId>
           <version>${revision}</version>
           <relativePath>..</relativePath>
       </parent>
       <artifactId>hbase-thirdparty-properties-bundle</artifactId>
       <name>Apache HBase Thirdparty - Properties Bundle</name>
       <description>
           Properties Bundle, for shared properties between HBase Thirdparty and HBase main code
       </description>
       <build>
           <resources>
               <resource>
                   <directory>src/main/resources</directory>
                   <filtering>true</filtering>
               </resource>
           </resources>
           <plugins>
               <plugin>
                   <groupId>org.apache.maven.plugins</groupId>
                   <artifactId>maven-resources-plugin</artifactId>
                   <executions>
                       <execution>
                           <id>filter-resources</id>
                           <phase>process-resources</phase>
                           <goals>
                               <goal>resources</goal>
                           </goals>
                       </execution>
                   </executions>
               </plugin>
           </plugins>
       </build>
   </project>
   
   ```
   
   ---
   
   Create a properties to be shared: hbase-thirdparty-properties-bundle/src/main/resources/dependencies.properties
   ```
   internal.protobuf.version=${protobuf.version}
   ```
   
   ---
   
   Define a dummy value for 
   `<internal.protobuf.version>999.999.999</internal.protobuf.version>` so that we can still parse the pom.xml
   
   ---
   
   Next, add a plugin to consume/load the property from resource in hbase/pom.xml
   ```
     <!-- Plugins to unpack properties file from hbase-thirdparty -->
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-dependency-plugin</artifactId>
           <executions>
             <execution>
               <id>unpack</id>
               <phase>initialize</phase>
               <goals>
                 <goal>unpack</goal>
               </goals>
               <configuration>
                 <artifactItems>
                   <artifactItem>
                     <groupId>org.apache.hbase.thirdparty</groupId>
                     <artifactId>hbase-thirdparty-properties-bundle</artifactId>
                     <version>${hbase-thirdparty.version}</version>
                     <overWrite>true</overWrite>
                     <!-- Specify the output directory -->
                     <outputDirectory>${project.build.directory}/extracted-resources</outputDirectory>
                   </artifactItem>
                 </artifactItems>
               </configuration>
             </execution>
           </executions>
         </plugin>
         <!-- Properties Maven Plugin to read properties file unpacked via maven-dependency-plugin -->
         <plugin>
           <groupId>org.codehaus.mojo</groupId>
           <artifactId>properties-maven-plugin</artifactId>
           <version>1.2.1</version>
           <executions>
             <execution>
               <id>read-properties</id>
               <phase>initialize</phase>
               <goals>
                 <goal>read-project-properties</goal>
               </goals>
               <configuration>
                 <files>
                   <file>${project.build.directory}/extracted-resources/dependencies.properties</file>
                 </files>
               </configuration>
             </execution>
           </executions>
         </plugin>
   ```
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@hbase.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org