[GitHub] [directory-scimple] jsteelepfpt commented on a diff in pull request #290: Update ObjectMapperFactory.java

["jsteelepfpt (via GitHub)" <gi...@apache.org>]

jsteelepfpt commented on code in PR #290:
URL: https://github.com/apache/directory-scimple/pull/290#discussion_r1175558371


##########
scim-core/src/main/java/org/apache/directory/scim/core/json/ObjectMapperFactory.java:
##########
@@ -61,6 +61,7 @@ private static ObjectMapper createObjectMapper() {
     objectMapper.setAnnotationIntrospector(pair);
 
     objectMapper.configure(DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES, false);
+    objectMapper.configure(MapperFeature.ACCEPT_CASE_INSENSITIVE_ENUMS, true);

Review Comment:
   @bdemers @erant10 This was Eran's suggested fix when I asked him about handling "Add" vs "add" for PATCH operation values. Should probably also add a test for this somewhere, but I just wanted to get this on people's radar screen. Right now, we're getting failures during Azure AD SCIM syncs due to "Add" not being accepted as a valid PATCH operation value.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@directory.apache.org
For additional commands, e-mail: dev-help@directory.apache.org