You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Kapil Arya <ka...@mesosphere.io> on 2017/05/05 10:38:41 UTC

Re: Review Request 58760: Added default secret resolver module.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58760/
-----------------------------------------------------------

(Updated May 5, 2017, 6:38 a.m.)


Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.


Changes
-------

Rebased. Added `::create` method.


Summary (updated)
-----------------

Added default secret resolver module.


Bugs: MESOS-7418
    https://issues.apache.org/jira/browse/MESOS-7418


Repository: mesos


Description (updated)
-------

Added default secret resolver module.


Diffs (updated)
-----

  src/Makefile.am 29da17bee13226e18757e2ad3a7a091427fd35f4 
  src/secret/resolver.cpp PRE-CREATION 


Diff: https://reviews.apache.org/r/58760/diff/4/

Changes: https://reviews.apache.org/r/58760/diff/3-4/


Testing
-------


Thanks,

Kapil Arya

Re: Review Request 58760: Added default secret resolver module.

Posted by Vinod Kone <vi...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58760/#review174240
-----------------------------------------------------------


Fix it, then Ship it!





src/secret/resolver.cpp
Lines 40 (patched)
<https://reviews.apache.org/r/58760/#comment247355>

    The comment about default resolver behavior in the previous review should be here instead.



src/secret/resolver.cpp
Lines 72 (patched)
<https://reviews.apache.org/r/58760/#comment247356>

    new line above.


- Vinod Kone


On May 8, 2017, 10:19 p.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58760/
> -----------------------------------------------------------
> 
> (Updated May 8, 2017, 10:19 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-7418
>     https://issues.apache.org/jira/browse/MESOS-7418
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added default secret resolver module.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 40d921ee7026f5ac47efbf0243e1cafab57825f9 
>   src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a 
>   src/secret/resolver.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58760/diff/6/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>

Re: Review Request 58760: Added default secret resolver module.

Posted by Gilbert Song <so...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58760/#review174913
-----------------------------------------------------------


Fix it, then Ship it!





src/secret/resolver.cpp
Lines 76 (patched)
<https://reviews.apache.org/r/58760/#comment248183>

    Newline above.



src/secret/resolver.cpp
Lines 78 (patched)
<https://reviews.apache.org/r/58760/#comment248184>

    Newline above.


- Gilbert Song


On May 12, 2017, 10:52 a.m., Kapil Arya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58760/
> -----------------------------------------------------------
> 
> (Updated May 12, 2017, 10:52 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Vinod Kone.
> 
> 
> Bugs: MESOS-7418
>     https://issues.apache.org/jira/browse/MESOS-7418
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added default secret resolver module.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt 40d921ee7026f5ac47efbf0243e1cafab57825f9 
>   src/Makefile.am 6bb81fd49b4564a0afa993b2cef6baa9d370ee7a 
>   src/secret/resolver.cpp PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58760/diff/8/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kapil Arya
> 
>