You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by ravipesala <gi...@git.apache.org> on 2018/05/17 09:00:00 UTC

[GitHub] carbondata pull request #2304: [CARBONDATA-2477]Fixed No dictionary Complex ...

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2304#discussion_r188885269
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/datastore/page/VarLengthColumnPageBase.java ---
    @@ -202,9 +249,36 @@ private static ColumnPage getLVBytesColumnPage(TableSpec.ColumnSpec columnSpec,
         lvEncodedOffset = 0;
         for (int i = 0; i < numRows; i++) {
           length = rowLength.get(i);
    -      page.putBytes(i, lvEncodedBytes, lvEncodedOffset + 4, length);
    -      lvEncodedOffset += 4 + length;
    +      page.putBytes(i, lvEncodedBytes, lvEncodedOffset + lvLength, length);
    +      lvEncodedOffset += lvLength + length;
         }
    +    return page;
    +  }
    +
    +  private static ColumnPage getComplexParentBytesColumnPage(TableSpec.ColumnSpec columnSpec,
    --- End diff --
    
    Check and remove if not required


---